Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Shea Levy <shea@shealevy.com>
To:     Palmer Dabbelt <palmer@sifive.com>, linux-kernel@vger.kernel.org
Cc:     linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: Implement free_initrd_mem.
In-Reply-To: <mhng-96c45513-b898-42bc-af9e-f24d9909f489@palmer-si-x1c4>
References: <mhng-96c45513-b898-42bc-af9e-f24d9909f489@palmer-si-x1c4>
Date:   Thu, 08 Mar 2018 14:14:52 -0500
Message-ID: <87efkuv0pf.fsf@xps13.shealevy.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Palmer,

Palmer Dabbelt <palmer@sifive.com> writes:

> On Tue, 20 Feb 2018 05:50:43 PST (-0800), shea@shealevy.com wrote:
>> Signed-off-by: Shea Levy <shea@shealevy.com>
>> ---
>>  arch/riscv/mm/init.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> index c77df8142be2..1c832b541e95 100644
>> --- a/arch/riscv/mm/init.c
>> +++ b/arch/riscv/mm/init.c
>> @@ -66,5 +66,11 @@ void free_initmem(void)
>>  #ifdef CONFIG_BLK_DEV_INITRD
>>  void free_initrd_mem(unsigned long start, unsigned long end)
>>  {
>> +	if (start =3D=3D initrd_start)
>> +		start =3D round_down(start, PAGE_SIZE);
>> +	if (end =3D=3D initrd_end)
>> +		end =3D round_up(end, PAGE_SIZE);
>> +
>> +	free_reserved_area((void *)start, (void *)end, -1, "initrd");
>>  }
>>  #endif /* CONFIG_BLK_DEV_INITRD */
>
> It looks like everyone is doing something slightly different here:
>
> * arm64 doesn't round to a page size, and has keep_initrd.
> * arm calls poison_init_mem(), and has keep_initrd.
> * sparc64 doesn't round, and doesn't have a keep_initrd.
> * mips doesn't round, and doesn't have a keep_initrd.
> * x86 rounds end to a page size but not start, and doesn't have a keep_in=
itrd.
>
> It feels like this should be something generic.  I'm adding linux-kernel =
to see=20
> what people think.

Should I try to whip up something generic?

Thanks,
Shea

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE6ESKvwKkwnxgMLnaXAvWlX2G/icFAlqhi6wACgkQXAvWlX2G
/iffVBAA4qtJpbFtTcIC6XNUw8OLEJswBW5JvCF++W4wn+A+b2M5CrfnRshamvz5
CYqvxYL4MbOhVEn7UysMfipsC3MMdnq4Nd9//6BgpXESVB0Ona6YauGYuqebkeMC
HmavSIh/TeirfJfjhAVKz5KlAd/OaKHCSsf/3EneNSdavw4+7nlBen9eXAOP83L0
bPNpKpBY74BvTJvyzPCDs+of4Cq5AkPLF3xaJxntcvDxH4LvUoFhNC3NrPAKJ/AJ
0suL3OqMF5sFf9Icvia1pHUCdJ9ADPmNU7Prv5HHwP/qHqppVFwnIABdwwc9hC0f
B+hRLhzjGsB0D7akYy77mxJLctwE1qglvC+KNnbGoCtHhX5fgc2ci4UDErjq10Qd
PykOk5vpwvWezEkQHD+/nhRrytA0EZ9wPaYBPLnZbHuS9hrjHQemoe9+7IGmo8xJ
HwY+bmAxemw1PA9IwNqQmUHI2HsQAHiJ+wrWNPhN97ONrPT9twC7ORuvTiaZDTQp
aP6/kLZ8dF/KCaEPSuRCGs6bjZPDApsElEf7Yy7B2074dYXrMwB+5zG5VBTcxHRV
UVjpXJlpVH4gUUCNs/i3Y19Ca7Xyir1soidEWlxtyWROsVpDCyA+NeU0aRSS9rjJ
KeqhRe0MG9dIL0AJ3WRmsVJRE8c80o8pHjjGc87MP1c5occ22CY=
=5mB5
-----END PGP SIGNATURE-----
--=-=-=--