Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270230AbTHGPzb (ORCPT ); Thu, 7 Aug 2003 11:55:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270081AbTHGPzB (ORCPT ); Thu, 7 Aug 2003 11:55:01 -0400 Received: from pc1-cwma1-5-cust4.swan.cable.ntl.com ([80.5.120.4]:38788 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S263861AbTHGPym (ORCPT ); Thu, 7 Aug 2003 11:54:42 -0400 Subject: Re: pivot_root solved by patch to 2.4.22-pre7 From: Alan Cox To: Jason Baron Cc: Rene Mayrhofer , Linux Kernel Mailing List In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Message-Id: <1060271448.3123.75.camel@dhcp22.swansea.linux.org.uk> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 07 Aug 2003 16:50:49 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 20 On Iau, 2003-08-07 at 16:26, Jason Baron wrote: > it clearly makes a difference. > > the unshare_files change causes init to no longer share the same fd table > with the other kernel threads. thus, when init closes or opens fds it does Ah yes.. because of do_basic_setup. Having /sbin/init sharing with kernel threads doesn't actually strike me as too clever anyway although none of them should be using fd stuff. In which case I guess we should call unshare_files directly before we open /dev/console in init/main.c. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/