Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0
 CPUs too
To:     Joao Martins <joao.m.martins@oracle.com>,
        linux-kernel@vger.kernel.org
Cc:     Juergen Gross <jgross@suse.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Robert Moore <robert.moore@intel.com>,
        linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org,
        devel@acpica.org, Erik Schmauss <erik.schmauss@intel.com>,
        Len Brown <lenb@kernel.org>
References: <20180308105751.8176-1-joao.m.martins@oracle.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com>
Date:   Thu, 8 Mar 2018 17:33:56 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180308105751.8176-1-joao.m.martins@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 03/08/2018 05:57 AM, Joao Martins wrote:

> @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv)
>   
>   	pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk);
>   
> +	/* It has P-state dependencies */
> +	if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) {
> +		__set_bit(acpi_id, acpi_id_psd_present);
> +
> +		pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n",
> +			 acpi_id, acpi_psd[acpi_id].coord_type,
> +			 acpi_psd[acpi_id].domain);
> +	}


I should have noticed this earlier, but do you really need 
acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL?

Sorry for missing it in the first patch.

-boris