Received: by 10.223.185.116 with SMTP id b49csp186787wrg;
        Thu, 8 Mar 2018 15:23:22 -0800 (PST)
X-Google-Smtp-Source: AG47ELufcwPFbhaREiPZsFYkyvwtIp+vZm+9yP4xRQBDfuLVKTwOy7eOlXVf/VGjM84XIUSynE5b
X-Received: by 10.101.66.1 with SMTP id c1mr21061519pgq.137.1520551401978;
        Thu, 08 Mar 2018 15:23:21 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1520551401; cv=none;
        d=google.com; s=arc-20160816;
        b=wwIQE/wnCaAj2w/DllrSZFDe6bG6aHawHcDA8lhOT2OngWVw18N7fxa/BthQ6tIL+b
         YtOmHFP6ch6zWdU4Lliy5ewlTawhribni0j+h+vZch6qgkxf+47jy+ZW4XTR/FCgAFHC
         /j8xb/c+tahGhhBcKTE/o3+XMSQMBWNScds6WlY0VLevpD+RUay2h0s0/8Od8z2hAjiW
         nHGi8Py+Aqixid0L1atKrzwtBiods2KzRWJVZ8ap34q9n0BhoDXuXnI1XZ1tp4ZTY6WA
         IlAO13rEj+QhMS1akuoFWZhPcyS/bOm3+jgvgB8mdRVAXKTZKwAR9P810zRm3ZYJ4ehn
         Eeeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:to:subject:arc-authentication-results;
        bh=ZS0rUh+sO7Ma/ss4J9xFBdo2bvVxCkE9DWfcfVY7PR8=;
        b=Rd7/c9hGubuFhbVpNiYXAbZ8VdSHv7xCX91bPLNV/xOm0HoYijmi2rxCrvJ/OQzrEu
         gK8GgHqOBrHlXxg2YguSJsQ0YQzz3bP4imLlWlICWOVYysmLmh5oZIWo5gIpWdD0pnk9
         B/xXcYh4YBLN+7EghVHF1SkX0CcDmEbUu/w1vgE7LpnjfaowW2MmIm1o/vfneapDc1mr
         62TLb/V+KvqC2w0EGHCL9uqsqe1+l9kaio1pIvGDxdqSvbfnBkowkE4HNSdDJk9yEAQN
         D/W2M3KuYQOrPovev37f0f2nN4r9bjtyLbAbOhkVKv+roOrbSvxSxmnVDbCrBHEneNum
         cGFg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 23si2753529pfs.275.2018.03.08.15.23.07;
        Thu, 08 Mar 2018 15:23:21 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751227AbeCHXVr (ORCPT <rfc822;arandomawesomegeek@gmail.com>
        + 99 others); Thu, 8 Mar 2018 18:21:47 -0500
Received: from hqemgate15.nvidia.com ([216.228.121.64]:11099 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750942AbeCHXVp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Mar 2018 18:21:45 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com
        id <B5aa1c5900000>; Thu, 08 Mar 2018 15:21:52 -0800
Received: from HQMAIL104.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 08 Mar 2018 15:21:45 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 08 Mar 2018 15:21:45 -0800
Received: from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL104.nvidia.com
 (172.18.146.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 8 Mar
 2018 23:21:44 +0000
Received: from [10.26.11.23] (10.26.11.23) by UKMAIL101.nvidia.com
 (10.26.138.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 8 Mar
 2018 23:21:40 +0000
Subject: Re: [PATCH v3 07/11] dt-bindings: tegra: Update DFLL binding for PWM
 regulator
To:     Peter De Schrijver <pdeschrijver@nvidia.com>,
        <linux-tegra@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <devicetree@vger.kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
References: <1517934852-23255-1-git-send-email-pdeschrijver@nvidia.com>
 <1517934852-23255-8-git-send-email-pdeschrijver@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <c747bc00-8c04-c297-e945-784e45655421@nvidia.com>
Date:   Thu, 8 Mar 2018 23:21:40 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1517934852-23255-8-git-send-email-pdeschrijver@nvidia.com>
X-Originating-IP: [10.26.11.23]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com
 (10.26.138.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 06/02/18 16:34, Peter De Schrijver wrote:
> Add new properties to configure the DFLL PWM regulator support. Also
> add an example and make the I2C clock only required when I2C support is
> used.
> 
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
>  .../bindings/clock/nvidia,tegra124-dfll.txt        | 76 +++++++++++++++++++++-
>  1 file changed, 74 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt b/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> index dff236f..a4903f7 100644
> --- a/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> +++ b/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> @@ -23,7 +23,8 @@ Required properties:
>  - clock-names: Must include the following entries:
>    - soc: Clock source for the DFLL control logic.
>    - ref: The closed loop reference clock
> -  - i2c: Clock source for the integrated I2C master.
> +  - i2c: Clock source for the integrated I2C master (only required when
> +	 using I2C mode).
>  - resets: Must contain an entry for each entry in reset-names.
>    See ../reset/reset.txt for details.
>  - reset-names: Must include the following entries:
> @@ -45,10 +46,28 @@ Required properties for the control loop parameters:
>  Optional properties for the control loop parameters:
>  - nvidia,cg-scale: Boolean value, see the field DFLL_PARAMS_CG_SCALE in the TRM.
>  
> +Optional properties for mode selection:
> +- nvidia,pwm-to-pmic: Use PWM to control regulator rather then I2C.
> +

Do we need this property? Seems that we should be able to detect if it
is I2C or PWM based upon the other properties.

Cheers
Jon

-- 
nvpublic