Received: by 10.223.185.111 with SMTP id b44csp34656wrg;
        Fri, 9 Mar 2018 00:16:21 -0800 (PST)
X-Google-Smtp-Source: AG47ELtx42MUqrWzqENoTLuJCMdIv4Wd/aBF5m8lh5crmqTsWujqTA65bXLfkKE3KGd8aFzEXtbh
X-Received: by 2002:a17:902:7c16:: with SMTP id x22-v6mr26690100pll.23.1520583380953;
        Fri, 09 Mar 2018 00:16:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1520583380; cv=none;
        d=google.com; s=arc-20160816;
        b=GWbS0u7q3YGko13AFWAhXRdroFfvOrekSCDhqA2AsEQxGvYiZm004CAlfoEjiRL+gV
         kfQ2TSuBtKlEdHFPUCsNwzX1sj7tgIyEvM5spRgsBP1KwB/00TC2mO2GHPQryQE+7T6c
         MU4j8swUZ+0mFZKdviPhB+M9E4WCgolIdcW2iisfUlF9CLv+fwEmcCch53PVm0tFrT3f
         93UQ6b6t8CW8KI4TTE6XlplbBkxfYGplMgtdglLeiVh3U60HqbTNxGjqu+q0vUpwYmJ7
         f+vkTxujz4eTedH+YqthSIM1FcdjOqb1X9Fa+yvvswnUw2eMkorV09Uu7RKi+f20CiTk
         uVpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:arc-authentication-results;
        bh=RLOrm7vlGPhC57Cs6gmCdqCLdvg26SA6XxY3U1EGNZE=;
        b=Rr+DKlv7HWU2QT5gwFkfhNy/Znk30tpRslPgisBsmJvFnBCPiB7+xlBYuYnyvzd0BM
         94/rYjD5rCOh2mGR8HilyE2PmzngJiB9n1x6ksOvyOIV3JL2rXe+l/j7nmDqIXtiU3p9
         E/t/yHvT8smdwIKUsxtxHqg+p+f20nhTeuDJzZl6149E0GrR8tvL04xauAwjC0zaiduU
         7VrVjfWqRoOGgHo3otoBu1/8VJLPedqvxHgEKlHnuhjEGUEvlgdHPQVZcB+X6ri2tIaJ
         DbJz5kqRBlHT/MEaVZ6djtJ7OfMhblDvqU8CcH29qlpd6Cy7SgseqBN/LtcpEHGQBKle
         hLPA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 70-v6si470378ple.465.2018.03.09.00.16.06;
        Fri, 09 Mar 2018 00:16:20 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751984AbeCIIOp (ORCPT <rfc822;arandomawesomegeek@gmail.com>
        + 99 others); Fri, 9 Mar 2018 03:14:45 -0500
Received: from hqemgate14.nvidia.com ([216.228.121.143]:13584 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751434AbeCIIOn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Mar 2018 03:14:43 -0500
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com
        id <B5aa242650000>; Fri, 09 Mar 2018 00:14:29 -0800
Received: from HQMAIL103.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Fri, 09 Mar 2018 00:14:42 -0800
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Fri, 09 Mar 2018 00:14:42 -0800
Received: from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL103.nvidia.com
 (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 9 Mar
 2018 08:14:42 +0000
Received: from tbergstrom-lnx.Nvidia.com (10.21.24.170) by
 UKMAIL101.nvidia.com (10.26.138.13) with Microsoft SMTP Server (TLS) id
 15.0.1347.2; Fri, 9 Mar 2018 08:14:38 +0000
Received: by tbergstrom-lnx.Nvidia.com (Postfix, from userid 1002)
        id 83C01F80500; Fri,  9 Mar 2018 10:14:38 +0200 (EET)
Date:   Fri, 9 Mar 2018 10:14:38 +0200
From:   Peter De Schrijver <pdeschrijver@nvidia.com>
To:     Jon Hunter <jonathanh@nvidia.com>
CC:     <linux-tegra@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <devicetree@vger.kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/11] cpufreq: tegra124-cpufreq: extend to support
 Tegra210
Message-ID: <20180309081438.GO6190@tbergstrom-lnx.Nvidia.com>
References: <1517934852-23255-1-git-send-email-pdeschrijver@nvidia.com>
 <1517934852-23255-10-git-send-email-pdeschrijver@nvidia.com>
 <b7a25613-44b4-5e63-e8c7-91ce2b7cb56e@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b7a25613-44b4-5e63-e8c7-91ce2b7cb56e@nvidia.com>
X-NVConfidentiality: public
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [10.21.24.170]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com
 (10.26.138.13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 08, 2018 at 11:25:04PM +0000, Jon Hunter wrote:
> 
> On 06/02/18 16:34, Peter De Schrijver wrote:
> > Tegra210 has a very similar CPU clocking scheme than Tegra124. So add
> > support in this driver. Also allow for the case where the CPU voltage is
> > controlled directly by the DFLL rather than by a separate regulator object.
> > 
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > ---
> >  drivers/cpufreq/tegra124-cpufreq.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
> > index 4353025..f8e01a8 100644
> > --- a/drivers/cpufreq/tegra124-cpufreq.c
> > +++ b/drivers/cpufreq/tegra124-cpufreq.c
> > @@ -64,7 +64,8 @@ static void tegra124_cpu_switch_to_pllx(struct tegra124_cpufreq_priv *priv)
> >  {
> >  	clk_set_parent(priv->cpu_clk, priv->pllp_clk);
> >  	clk_disable_unprepare(priv->dfll_clk);
> > -	regulator_sync_voltage(priv->vdd_cpu_reg);
> > +	if (priv->vdd_cpu_reg)
> > +		regulator_sync_voltage(priv->vdd_cpu_reg);
> >  	clk_set_parent(priv->cpu_clk, priv->pllx_clk);
> >  }
> >  
> > @@ -89,10 +90,10 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev)
> >  		return -ENODEV;
> >  
> >  	priv->vdd_cpu_reg = regulator_get(cpu_dev, "vdd-cpu");
> > -	if (IS_ERR(priv->vdd_cpu_reg)) {
> > -		ret = PTR_ERR(priv->vdd_cpu_reg);
> > -		goto out_put_np;
> > -	}
> > +	if (IS_ERR(priv->vdd_cpu_reg) != -EPROBE_DEFER)
> > +		priv->vdd_cpu_reg = NULL;
> > +	else
> > +		return -EPROBE_DEFER;
> 
> I am still not sure that we should rely on the fact that the regulator
> is not present in DT to imply that we do not need it. I think that we
> should be checking if we are using I2C mode here.
> 

The cpufreq driver doesn't know this however. Also the current approach of
setting the same voltage when switching to pll_x is incorrect. The CVB
tables when using pll_x include more margin than when using the DFLL.

Peter.