Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Roger Quadros <rogerq@ti.com>, Baolin Wang <baolin.wang@linaro.org>
Cc:     USB <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume
In-Reply-To: <5bc56ef5-66b1-d40c-1639-e748fe18cdbd@ti.com>
References: <1519730526-22274-1-git-send-email-rogerq@ti.com> <87sh9l5z4l.fsf@linux.intel.com> <94cd6377-1327-2309-8d69-6ab0de2bdfd4@ti.com> <87po4i3o1v.fsf@linux.intel.com> <a907787a-dea2-5f15-3d25-693680a42b71@ti.com> <CAMz4kuKOnAPckX1=nqVPyF7O5u-0YrekTfMddYwe0WC2-0AFDw@mail.gmail.com> <87k1uq3ho6.fsf@linux.intel.com> <8ec0485e-89af-568b-e34a-b0cd490817d0@ti.com> <CAMz4kuJpBXY92zhG7s_VRkpcTHeLCE_vBLLSFVxLWjN2GQvyyw@mail.gmail.com> <87h8puwyn5.fsf@linux.intel.com> <5bc56ef5-66b1-d40c-1639-e748fe18cdbd@ti.com>
Date:   Fri, 09 Mar 2018 11:23:19 +0200
Message-ID: <87muzha9h4.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Roger Quadros <rogerq@ti.com> writes:

<snip>

>>> When we set up the DWC3_DEPCMD_ENDTRANSFER command in
>>> dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC,
>>> then there will no endpoint command complete interrupts I think.
>>>
>>> cmd |=3D DWC3_DEPCMD_CMDIOC;
>>=20
>> I remember some part of the databook mandating CMDIOC to be set. We
>> could test it out without and see if anything blows up. I would,
>> however, require a lengthy comment explaining that we're deviating from
>> databook revision x.yya, section foobar because $reasons. :-)
>>=20
>
> This is what the v3.10 databook says
>
> "When issuing an End Transfer command, software must set the CmdIOC
> bit (field 8) so that an Endpoint Command Complete event is generated
> after the transfer ends. This is necessary to synchronize the
> conclusion of system bus traffic before the End Transfer command is
> completed."
>
> with a note
>
> "If GUCTL2[Rst_actbitlater] is set, Software can poll the completion
> of the End Transfer command by polling the command active bit to be
> cleared to 0."
>
> fyi.
>
> Rst_actbitlater - "Enable clearing of the command active bit for the
> ENDXFER command after the command execution is completed.  This bit is
> valid in device mode only."
>
> So I'd prefer not to clear CMDIOC for all cases.
>
> Could we some how just tackle the dwc3_gadget_exit case like I did in
> this patch?

if you can send a version that doesn't iterate over all endpoints twice,
sure. We still need a comment somewhere, and I fear we may get
interrupts later in some cases. How would we deal with that?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlqiUocACgkQzL64meEa
mQbDNRAAlQAftJ6UAfjPtOiHl04ULWtantMA+aTybY9FVEVs7XHuL/a4DQU3BrFa
KTceNsZLgTlYO5d9sn3dXiBc2U5qsj7mwLS1Tne4HdizFCiLB/nQFz5xLOQLckRM
xeScvVRDRa05HeaJhipnVUyH9/eKV4rXgXcW6bOEtSIzU5Be49GxZR2rOyZShuI4
Xc9Ab7D0idZZ3KkxZFu9cEXB/lzvmrNPYcW9wL8ZvpagEzTJE4vr0bqWXIbT7acY
tTgAQA1AtVOFOfcIe6+q1Ek5M+hEmuvzxsvEAhgG4pLmzHtFNr2d7RiU0A6pvEG9
kakaWsO8IoC+m1tyAdsAMDYVOnC5fuvfAQ0NS+7eo1Fp5Q3gvT6WCCvuaRgvFMeA
dNMgdSZYoFoe1UFSLk81qp2VNkThJSHmY9z+zYnoISiEsU+ORqPP4C4Owq6F5i1m
rDbBNgq7bTTfcsex7E+S1FDJ7ahFa9MWxc89HiccH9aNlS3z4+HoMhWxAcieO8qB
26mOAKN9jL9Ok8OfB5bnUQ0Cx0/qyYzFOKrOfDn7V4nzY1xYcn5CzYCLrRWri/Sa
CWAJQ7s7EBw10V0hnbq/dKJPe+hFKJFuPw97qZqkj1KJ+MpEwjLH/7ZHxJgGH7YO
aG0MU5A9cm66AOn011Dit6mHmgFLuv8WRCetfRmw1Yasp14pAhA=
=yZpY
-----END PGP SIGNATURE-----
--=-=-=--