Received: by 10.223.185.111 with SMTP id b44csp93213wrg; Fri, 9 Mar 2018 01:34:49 -0800 (PST) X-Google-Smtp-Source: AG47ELvJUp7kxwW2vSa6M/hBU9kVmOzyoaCKNAkQeg4mYXgiXQXOfD1nAfzXPMUUEhHaLVqwoqy8 X-Received: by 10.98.214.218 with SMTP id a87mr29483994pfl.146.1520588089412; Fri, 09 Mar 2018 01:34:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520588089; cv=none; d=google.com; s=arc-20160816; b=l2+QLas1hSdPpHxfj094OSPvwi47YUf/HwF9+Ax+8GhJtTSQMyuVT8Dj7Bf39J+WZa U+jUe4t+M1mYmka471/IG5HpvVR5Xl6I8AWkx5osH8MY1rmhgQLKxDNDFPVKJ5YP75D6 sHsGAZnetUPINbteLL6LSPfbWiyuhhONsH/oNkGMBaX9h8KtBfxSz5le8sRERm5GLXWw CEDjONfX8fABNk91JynDKP6qs/TseaWrrU0azgYgAz2Kpt1Cpa5shzmjHu8vkWIDZNuz NYhLZieN2gveqjuY2Gi7K9trZTGg7+9Y4vB9pGH12InKyWXbRn0FCCAAZgkHsLstAGNc IDHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=vpf2uQiquzCxCLyfkIzGDlYB277t5U1+JMZX352FOhc=; b=OizFyYl0sU49E2Hl8I8uU02irw9yAVGfIx6Yitlf0QcMtVCggl8D/XDK2cnXMIXzRw /mT+NPFQTbMtrhOYQ637Mp3awAB+tKmCV5J8k+WJjvFZI/VHXYYZUZhIdA88lJpZY9ND DFtLYg5LcO3w8GCPLnChClzrK275qER+WHfORJ/5Xv4hzdlZ+D5FhfRNDS7/1Rb2skuN JFC+BJfOEOxDUfGlsn8pXVKTSC8/SQ+l0oYDZ0/HJujWmDyr4Wc0CHqoMZgj3Bv6cKFU yVHhKI7HvIFU/G0rw7vm0cm1wNSrY8uv+TJLH5nW2/sdndYLvRq9jkF5tlTD0wKZJNFp U1lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MJpcp8pt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si482935pge.494.2018.03.09.01.34.34; Fri, 09 Mar 2018 01:34:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MJpcp8pt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751159AbeCIJda (ORCPT + 99 others); Fri, 9 Mar 2018 04:33:30 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:37528 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbeCIJd2 (ORCPT ); Fri, 9 Mar 2018 04:33:28 -0500 Received: by mail-it0-f68.google.com with SMTP id k79-v6so2128554ita.2 for ; Fri, 09 Mar 2018 01:33:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vpf2uQiquzCxCLyfkIzGDlYB277t5U1+JMZX352FOhc=; b=MJpcp8ptz++S9qWfHebm8J5y3tdysuEIiIWeFDVOpVsoVUXt9yqIp3MFOc/ZUpy0Ca 0vLEIqQg4nwOEMswjDlrAFHRznaduUGWHuZMXYEOnaEeIraePBYFeOeVVha71bbEGAbz 3JPJGZsMiDjhknD5zvZ3gVIGuUlm/gFgQNX4o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=vpf2uQiquzCxCLyfkIzGDlYB277t5U1+JMZX352FOhc=; b=nCCJqECKUt+GsuhBeri5cdNVML8PfjzljBdgFcugO42gGJPJzXIOv9/fHoZqnGjDgp 4vuA6uBeA1DH/MvpwzlhtIGPKKcgT9ud/Qxke7dutNoNRVArp7MiB8aPM/onH0MqDq3A KnjWJzddLS2hbC8rO/xRhU56cmgE8tUt+CZxT7Tu1V9ZpNcAjbNQY2CuC+rY5+9eCQMe NCcTwsJ57pbWqsvAcitMNW0EMEWs3+GL1vFM8on38sX9HCkxFowV1vciLCyOaF870itO U6u03rhqFTriK3yEPzr1TgmR/BvKEsm6OsJ9lGyMT535wtAZImZ8+nUk9E2NlLXE3H4S OuKQ== X-Gm-Message-State: AElRT7Gp0XxiwiKn8s4mEHuMPPBv5dlJSvnFQ2LpGAPZX5mOmAnLIOev qM6Za6wcI37/Oa5VHh6iQuUaiw== X-Received: by 10.36.225.72 with SMTP id n69mr2698354ith.82.1520588007388; Fri, 09 Mar 2018 01:33:27 -0800 (PST) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id t21sm559603ioa.64.2018.03.09.01.33.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Mar 2018 01:33:26 -0800 (PST) Date: Fri, 9 Mar 2018 18:33:47 +0900 From: AKASHI Takahiro To: Dave Young Cc: vgoyal@redhat.com, bhe@redhat.com, mpe@ellerman.id.au, bauerman@linux.vnet.ibm.com, prudo@linux.vnet.ibm.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres Message-ID: <20180309093346.GF25863@linaro.org> Mail-Followup-To: AKASHI Takahiro , Dave Young , vgoyal@redhat.com, bhe@redhat.com, mpe@ellerman.id.au, bauerman@linux.vnet.ibm.com, prudo@linux.vnet.ibm.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, akpm@linux-foundation.org References: <20180306102303.9063-1-takahiro.akashi@linaro.org> <20180308010502.GA2600@dhcp-128-65.nay.redhat.com> <20180309060254.GA9728@dhcp-128-65.nay.redhat.com> <20180309064412.GA5327@dhcp-128-65.nay.redhat.com> <20180309071813.GE25863@linaro.org> <20180309074613.GA6331@dhcp-128-65.nay.redhat.com> <20180309075547.GA6718@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180309075547.GA6718@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave, On Fri, Mar 09, 2018 at 03:55:47PM +0800, Dave Young wrote: > On 03/09/18 at 03:46pm, Dave Young wrote: > > Hi AKASHI, > > > > On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > > > Dave, > > > > > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > > > On 03/08/18 at 09:05am, Dave Young wrote: > > > > > > [Cc Andrew] > > > > > > > > > > > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > > > > > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > > > > > > > > > > > It was originally included in a arm64 patch set[1], but Philipp is also > > > > > > > working on their kexec_file support on s390[2] and some changes are now > > > > > > > conflicting. > > > > > > > > > > > > > > So these common parts were extracted and put into a separate patch set for > > > > > > > better integration. What's more, my original patch#4 was split into a few > > > > > > > small chunks for easier review after Dave's comment. > > > > > > > > > > > > > > As such, the resulting code is basically identical with my original, and > > > > > > > the only *visible* differences are: > > > > > > > * renamings of _kexec_kernel_image_probe() and > > > > > > > _kimage_file_post_load_cleanup() > > > > > > > * change one of types of arguments at prepare_elf64_headers() > > > > > > > Those, unfortunately, require a couple of trivial changes on the rest > > > > > > > (#1, #6 to #13) of my arm64 kexec_file patch set[1]. > > > > > > > > > > > > > > Patch#1 allows making a use of purgatory optional, particularly useful > > > > > > > for arm64. > > > > > > > Patch#2 commonalizes arch_kexec_kernel_{image_probe, image_load, > > > > > > > verify_sig}() and arch_kimage_file_post_load_cleanup() across architectures. > > > > > > > Patch#3-#7 is also intended to generalize parse_elf64_headers(), along with > > > > > > > exclude_mem_range(), to be made best re-use of. > > > > > > > > > > > > > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-February/561182.html > > > > > > > [2] http://lkml.iu.edu//hypermail/linux/kernel/1802.1/02596.html > > > > > > > > > > > > > > > > > > > > > Changes in v2 (Mar 6, 2018) > > > > > > > * use IS_ENABLED() instead of #ifdef's in kexec_calculate_store_digests() > > > > > > > * rename _kexec_kernel_*() and make them static for now except for > > > > > > > kexec_image_probe_default() which is actually used by arch(powerpc) code > > > > > > > (Note: kexec_image_post_load_cleanup_default() will also be exported by > > > > > > > arm64 patches.) > > > > > > > * change a type of kernel_map in prepare_elf64_headers() to "int" > > > > > > > * check for a total number of system ram regions in full_up_crash_elf_data() > > > > > > > and use vzalloc() instead of vmalloc() > > > > > > > > > > > > > > AKASHI Takahiro (7): > > > > > > > kexec_file: make an use of purgatory optional > > > > > > > kexec_file,x86,powerpc: factor out kexec_file_ops functions > > > > > > > x86: kexec_file: purge system-ram walking from prepare_elf64_headers() > > > > > > > x86: kexec_file: remove X86_64 dependency from prepare_elf64_headers() > > > > > > > x86: kexec_file: lift CRASH_MAX_RANGES limit on crash_mem buffer > > > > > > > x86: kexec_file: clean up prepare_elf64_headers() > > > > > > > kexec_file, x86: move re-factored code to generic side > > > > > > > > > > > > > > arch/powerpc/Kconfig | 3 + > > > > > > > arch/powerpc/include/asm/kexec.h | 2 +- > > > > > > > arch/powerpc/kernel/kexec_elf_64.c | 2 +- > > > > > > > arch/powerpc/kernel/machine_kexec_file_64.c | 39 +--- > > > > > > > arch/x86/Kconfig | 3 + > > > > > > > arch/x86/include/asm/kexec-bzimage64.h | 2 +- > > > > > > > arch/x86/kernel/crash.c | 334 ++++++---------------------- > > > > > > > arch/x86/kernel/kexec-bzimage64.c | 2 +- > > > > > > > arch/x86/kernel/machine_kexec_64.c | 45 +--- > > > > > > > include/linux/kexec.h | 32 ++- > > > > > > > kernel/kexec_file.c | 240 +++++++++++++++++++- > > > > > > > 11 files changed, 338 insertions(+), 366 deletions(-) > > > > > > > > > > > > > > -- > > > > > > > 2.16.2 > > > > > > > > > > > > > > > > > > > AKASHI, thanks for another update, looks good to me: > > > > > > > > > > > > Acked-by: Dave Young > > > > > > > > > > Hold on the ack, during today's tests kexec kernel can not boot, it > > > > > hangs early. Will see if it is caused by this series and come back > > > > > later. > > > > > > > > AKASHI, it seems the first patch causes the hang, can you take a look? > > > > > > Sure, but can you first tell me specifics about what you have observed? > > > > It is a kexec load test like below: > > kexec -s -l /boot/vmlinuz-`uname -r` --reuse-cmdline > > sync > > sync > > kexec -e > > > > And it hangs after the message "Starting new kernel". Now I'm not sure > > how I tested the vmcore parsing before, maybe I forgot to add "-s" > > option in kexec-tools.. > > BTW kdump kernel also failed to boot. > I use linus tree, the git HEAD is > 86f84779d8e9 (origin/master, origin/HEAD, master) Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace > > It is a little odd for my testing, for kdump testing I did before, I do > not need add "-s" explictly since Fedora will take it automatically in > case Secure Boot and I always enabled Secure Boot. Oops, please apply the fix below to my first patch ("kexec_file: make an use of purgatory optional"). My screw-up is trivial here :) Please let me know if you think that I should repost my patch set. Thanks, -Takahiro AKASHI ===8<=== diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index 6dbbb89cbbac..ab1dced677fd 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -532,7 +532,7 @@ static int kexec_calculate_store_digests(struct kimage *image) struct kexec_sha_region *sha_regions; struct purgatory_info *pi = &image->purgatory_info; - if (!IS_ENABLED(ARCH_HAS_KEXEC_PURGATORY)) + if (!IS_ENABLED(CONFIG_ARCH_HAS_KEXEC_PURGATORY)) return 0; zero_buf = __va(page_to_pfn(ZERO_PAGE(0)) << PAGE_SHIFT); ===>8=== > > > > Thanks > > Dave > > > > > > > > Thanks, > > > -Takahiro AKASHI > > > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > Dave > > > > > > > > > > Thanks > > > > > Dave