Received: by 10.223.185.111 with SMTP id b44csp157502wrg; Fri, 9 Mar 2018 02:53:36 -0800 (PST) X-Google-Smtp-Source: AG47ELt7ZIyR0f3TsMWL//7gYM2BPhcmxPYy0Yy5rZnJb2T4uA7dATywJIcxQlTa46OzBmekMM3u X-Received: by 10.101.65.203 with SMTP id b11mr24028995pgq.118.1520592816469; Fri, 09 Mar 2018 02:53:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520592816; cv=none; d=google.com; s=arc-20160816; b=xWNoOQuhhlHqm+JbbuBgBnJb0PM7Ofc7Is/a55OO/LHlgnZD8aotRKW6uY8pmzkgFT lKg47q4tmpUBaA9r2WHgRQ3b4CWBpz1fiYSyAN6O6PV9LxdTshjZ+5GErObHmdVeo1cl 6LdK9SqnWVCSCFWV323zUBiYjanRCZ0Fg/XmZrO14D3ijXuvUPo2akzogcHKVOpOAi/c WDnvYOg2jCzOt6iibFae0dU4fePQEl0O+awQ0qjxtmUnjnsa5a9AemaMJ+zNbsxDqM77 j7LzKV1CFVFMRyQsuKXa0xXBj/HXjjUvgxA93+7w7XMM3hCN6JvsZRPBo7doE6aMOhjr 3kKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=kpJubRdB8eA+ETWzHMyjp8zIQpO2j4j+nQayyOS3088=; b=mWsMXqxug5o+AyN23UNloey6xneKT3Ywn5Qp8v+9oYRTvZ4Xt5s61yLx0G2CaS7FRU lJZyBdGPqc/z8sQTBd5rwQKYPc320Twk9Cnq/6eHRS1jvixIrmQyoLhtLTyRpPflWlje 9UvjLy6/gW+aPDhyn2nwzFcaLUGXX6UXIHaI0lRCNJeS4af598I7H775dEmGL3cEvEiN EytvBGBfitxTV3ANYXzVecVtbWiy9fqe6yK3zxXs24wISD6+lQ01bJDrgEuYuVpAuHwf oDHOaimQmSfUwSUVsmNT0mlY7SLbh/IlEKG2+zQ2pTZgsdSh8sY5T5ScDm+PHN7RBn8l n/NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qSU5Dnri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m32-v6si681591pld.125.2018.03.09.02.53.22; Fri, 09 Mar 2018 02:53:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=qSU5Dnri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751226AbeCIKvw (ORCPT + 99 others); Fri, 9 Mar 2018 05:51:52 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:41080 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbeCIKvt (ORCPT ); Fri, 9 Mar 2018 05:51:49 -0500 Received: by mail-io0-f194.google.com with SMTP id q24so3102376ioh.8 for ; Fri, 09 Mar 2018 02:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=kpJubRdB8eA+ETWzHMyjp8zIQpO2j4j+nQayyOS3088=; b=qSU5Dnri8rN86Gj5HhmWDue5O3MHnEe/W7mpYkl2MJMf6ED0Xm2GIcDirIPkzqowaC YkORbgjHlKED8utgd4DsVMPREAZXRBoLHN1TpcraM0Gkne3M48IcGwINwKSkVzwJfQTG nIT55/LAgL8Y3WSoIUhYYcqH/V3hfZukvAU6iUp+WiXAL5slUPz85siWa9IORpjA1EHB qBdvKEZFJX8M8v6yYg9zmE5tiXBUwrFPisvKpDlA/36jp20nhJurEIRFQ0HRi38Dw5iD q+xO4Z1LIKXszD2IUppsGq1ejRQA8udp0hN/qX7m47QAKl9QMmfknMDqytEawbgwjQde Yb+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=kpJubRdB8eA+ETWzHMyjp8zIQpO2j4j+nQayyOS3088=; b=htcAQm3w/+8nGxd2havR4OUl4UM70hNvTlAwe0BvdZOc6PncYWsepW4hl46pBs+Mpr Mt/B1mHTVqWAJ9ZCI11hdRYz4FWz+TU6Higz1HTex/z1f9KdpQrSMqOyMeyXFc093DIk qQNdgQd20gjYbcXfCXaIE7gPPGA/DIyZoAEuBHeycxyG3TRMtfOET5VQLashqHou0MGX 0rYRl3kK7r7xLHpECu2dHbPzt02cidn2xYmX3WEN6zIEmoAIGkWMCC5+rU/2GOCjLmu2 uWp2PydaOthBpfmivAHJdPnzeUddcy1xHillsaiQ08oR7pAsuWcy5j7uApkd+BBWGu4d F0Eg== X-Gm-Message-State: AElRT7FmFvnmVWkl/daiiYg+v6qRLbZdqFAeda31S5lzDOwxETWMb7ga SCKk4wl8smVWnTVt5NPTlkI= X-Received: by 10.107.205.134 with SMTP id d128mr15026506iog.35.1520592707888; Fri, 09 Mar 2018 02:51:47 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id y4sm739890ioi.45.2018.03.09.02.51.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 02:51:47 -0800 (PST) From: Arvind Yadav To: dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, dedekind1@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: [PATCH 1/2] mtd: use put_device() if device_register fail Date: Fri, 9 Mar 2018 16:20:48 +0530 Message-Id: <39c4af723ea37cd05976a17cb9c1fbc975496ffd.1520592440.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/mtd/mtdcore.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 28553c8..4d77ca2 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -586,6 +586,7 @@ int add_mtd_device(struct mtd_info *mtd) return 0; fail_added: + put_device(&mtd->dev); of_node_put(mtd_get_of_node(mtd)); idr_remove(&mtd_idr, i); fail_locked: -- 1.9.1