Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0
 CPUs too
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Robert Moore <robert.moore@intel.com>,
        linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org,
        Len Brown <lenb@kernel.org>,
        Erik Schmauss <erik.schmauss@intel.com>, devel@acpica.org
References: <20180308105751.8176-1-joao.m.martins@oracle.com>
 <4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com>
From:   Joao Martins <joao.m.martins@oracle.com>
Message-ID: <165abeed-3194-fe35-74f6-e2c68543c92c@oracle.com>
Date:   Fri, 9 Mar 2018 12:56:28 +0000
MIME-Version: 1.0
In-Reply-To: <4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/08/2018 10:33 PM, Boris Ostrovsky wrote:
> On 03/08/2018 05:57 AM, Joao Martins wrote:
> 
>> @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv)
>>   
>>   	pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk);
>>   
>> +	/* It has P-state dependencies */
>> +	if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) {
>> +		__set_bit(acpi_id, acpi_id_psd_present);
>> +
>> +		pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n",
>> +			 acpi_id, acpi_psd[acpi_id].coord_type,
>> +			 acpi_psd[acpi_id].domain);
>> +	}
> 
> 
> I should have noticed this earlier, but do you really need 
> acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL?
>

Oh yes! I was trying to be consistent with the rest of the module, but we surely
don't need that array of longs. Will respin after testing.

> Sorry for missing it in the first patch.
>
Thanks for the feedback!

> -boris
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
>