Received: by 10.223.185.111 with SMTP id b44csp324403wrg; Fri, 9 Mar 2018 05:41:06 -0800 (PST) X-Google-Smtp-Source: AG47ELuAldsXPmCiyV/QA6tXduadV+OV3hyipUTkFqo8MvZAv6UEuIq1kCTpCI9bdMRKCpzfxOj9 X-Received: by 10.101.93.71 with SMTP id e7mr24693399pgt.248.1520602866080; Fri, 09 Mar 2018 05:41:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520602866; cv=none; d=google.com; s=arc-20160816; b=ZCHk51s0f/2OMcH+0s4ivZwbXyKcFZ2EvRaescxjKu1/ZQfatoSkCCU2RTRm30JyIU 6K6TRsjOmtjPCGiZ7GrqZt+TEI4Fzfdn0D7q6RdC1fdhx+66m9fTA48CLm/FYrH1V9Ku EXcb33LvuNf+w5Y7Edl6UDlqVvJ/mVQv2jglxb/N1y21R1xBkco63cxnvIusPctfndnJ r7NhCic9VIL8mtvxqkHbhqnMytkKQVxYVM/dvsiFZNzKfiGxsMhWSOJxx/uOXrQuC5eb 5JC4aYOJI4Mh3zXvoOQIDHxEMPuKeXHJD0H7HbIEMB0sXoEkGO6bDskNqXS1U6wVE4Mi ldpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=Nx5RHRChIkmo7atIEE28jvFI4DRm/ub+barvdkYABdw=; b=oIWnH64JfkfLP5zPW0ApuUpWLKLF3ci0PKPU6XMUJwOpLGBQ1bYqtKXtFSMn8wI7uf u8TrG5iMb1hO/nyFJ1ahCN51QqCBHc2eGE37z3Gbybff1ZwO6Fg3yak7GpM0Mw5kkweQ Cg+spiOiTPGeGs37NXCGa9bGNtjPIm23ASQEmkTtZ0xlbKykZgT1Tzy4cFn3NQF/U4ib QkbfcC+FZtEBcMDTFEsEH2jfgAZ1WEu8LocG2qcgRXH8NZvUAtNiZ3cc8hmAR+Tyt6Lb LIboSl7pSQ2EOW3IBrv/i8Xfa4eu1fWgEYtWUDyVSZc2offZ6L+sbxOkRxSiZA6ypj8n Cgrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Q2f0TunO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l24si742408pgo.580.2018.03.09.05.40.51; Fri, 09 Mar 2018 05:41:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Q2f0TunO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932150AbeCINj5 (ORCPT + 99 others); Fri, 9 Mar 2018 08:39:57 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:54726 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbeCINjz (ORCPT ); Fri, 9 Mar 2018 08:39:55 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id w29DdsZC012672; Fri, 9 Mar 2018 07:39:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1520602794; bh=TgVCsTAebTizGM58wHzVmWpYypUGjCyzCEkQGPqMUBg=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Q2f0TunOxMRIWZSeSFziNYCJRRvtpwfB1jaYcXHOZOIuChYOvq8waf+oywP0QHOCU zoJaOj1uFM5taxuI301st7nLBh2PoJyZbI/8rY9hPFyeArFr4cbvowrH0VQZcNJPau qUcoQr352g84lPaTSRaY644xv9YDcaflPWk/SAhs= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w29DdsPr006529; Fri, 9 Mar 2018 07:39:54 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Fri, 9 Mar 2018 07:39:53 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Fri, 9 Mar 2018 07:39:53 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w29DdrWK031227; Fri, 9 Mar 2018 07:39:53 -0600 Date: Fri, 9 Mar 2018 07:39:53 -0600 From: Bin Liu To: Merlijn Wajer CC: , , Greg Kroah-Hartman , , Subject: Re: [PATCH] usb: musb: Fix external abort in musb_remove Message-ID: <20180309133953.GL14921@uda0271908> Mail-Followup-To: Bin Liu , Merlijn Wajer , ivo.g.dimitrov.75@gmail.com, linux-omap@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180308204049.29474-1-merlijn@wizzup.org> <20180308211525.GJ14921@uda0271908> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2018 at 11:17:48PM +0100, Merlijn Wajer wrote: > Hi, > > On 08/03/18 22:15, Bin Liu wrote: > > > please add patch version numbers in the subject when necessary. This > > helps cross-referencing. > > Will do. I naively assumed that the first patch would implicitly be > number 1. Will send out v2 now. Sorry, my bad, I forgot the first patch was a RFC. You are doing it right. > > >> > >> + musb_writeb(musb->mregs, MUSB_DEVCTL, 0); > > > > Does it solve the issue if not moving this line? I'd like to have > > minimum change if possible. > > Yes, it does. The only reason I moved musb_writeb is because I > understood you wanted me to move both (per previous message: "This can > be move down to out side of holding the spinlock"). Typically the comments would only applies to the modified code. Otherwise the comments have to be explicit to avoid confusion. No worries here anyway, confusion does happen sometimes ;) Regards, -Bin.