Received: by 10.223.185.111 with SMTP id b44csp630586wrg; Fri, 9 Mar 2018 10:38:24 -0800 (PST) X-Google-Smtp-Source: AG47ELs5R8SEHR2Mf0OUmL4adF7jXp8br3szIF6VwaAohd1v7Iffzd/jf+TDIGVD2lENtLnvaoqF X-Received: by 10.98.198.92 with SMTP id m89mr22459619pfg.73.1520620704216; Fri, 09 Mar 2018 10:38:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520620704; cv=none; d=google.com; s=arc-20160816; b=yVbOfgl7IA1FwuolXuU0oWH9NqOtdzpiJ/Q6q0002/vRI4VD7QdU6kUkCyDquzmcCq NRMPD3n6u8DAOBJ48OQG9CdmefCenbd6qJQPsj29kTWw+9air344xsqRyanfsQ5N3uS7 JZvng569tkW5hq9bz0noSg/kpFs/InpQojUWCF1k9k54uZamm1rjxnrE5DhPJhr4j8tx qxUEUVfMgqXAT410QS2lQxZwBQ8bPJzPhz1456m9cEGyCrLV4o0w2Hr/EjxrqThBjy0x bYPyNqQRFJYfuYYuaULMVbpuN5sZtcNH8gXQpdH8lkNtfPVpiwbcsj7F1sQaLok/Ak/B 52xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=yU6k1VUjRzWEYSJpsedzyHNDs6Qc22yusmRaeLQWcS8=; b=s1otGxzUHQYSSeyuJaBzATsJVPOtvS51bkb9Lc8uEN4hW+pepj3h3Orj/ZbWeqaWL1 rV4hdy+qtgw8W6wa3MEpnylgOPa2vvrrbxXRbmZLDnCg8D100VgcrsX6K979DOw9WIzx ncAv2W1sjp4aKR6AcYXSya1VbapUxiBlJwYpOOzAXptMHAiUx06LG/jcR8TOtv4Sv9m7 CLOEoEBGQn52VY0CDggjUvd1hbsKZ3B5u5PpwqyZ9fC1/fKFGF4KQlCdpyZ6UGxTNIEW EUTPMwEa0O306+zbkYyVwEEt0MxpA8ZPkQq2vdVXcyomXgxermJhMsJeKhtzzznrqxwT BfDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=Mbzz+3yU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2-v6si1247263pls.46.2018.03.09.10.38.09; Fri, 09 Mar 2018 10:38:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=Mbzz+3yU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbeCIShN (ORCPT + 99 others); Fri, 9 Mar 2018 13:37:13 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:46546 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbeCIShL (ORCPT ); Fri, 9 Mar 2018 13:37:11 -0500 Received: by mail-lf0-f51.google.com with SMTP id u26-v6so3299887lfk.13 for ; Fri, 09 Mar 2018 10:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yU6k1VUjRzWEYSJpsedzyHNDs6Qc22yusmRaeLQWcS8=; b=Mbzz+3yU88NQt0/eYcZrOvnhukRqB9ti4MKaPc2r6k4rIaP7dTw6eEjnEBu31EJBVb snHhAmyH1uv8NHImVL70Ha+nc0qMOxnFdVfgLtFLKrIFCjQ+9SYbspNCYYIJQ3CefdDL LPZJ/HkauZV5/UiOcOJvEwOk4jla8tt5nLxZu9BRJCMfratHljWqt182UpNSGKuRiAD4 2rXLYduwHUh4BCZ+LseNQkJkq5mOiSf/2upz+Zh9IfObSXcLpSaTLlpajAj2PW3Jcv82 gQ7UerhVyavKwtGEvJ6SZMEMBGhBfxbJ/J+UxZ7gWfC9x59OLzBiMf5cmAB8lEl/7z+7 f21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yU6k1VUjRzWEYSJpsedzyHNDs6Qc22yusmRaeLQWcS8=; b=XXSwiNUaq45c0+DQ5vvLjskI2/3WuCqadihc5dWdv153WeWxF06co81KdQFNeL/yxG ay0iZPd1uck7RESVBbVmEwY2eNSFlg8BE2uS7Askhq4OezKTJROmiTH0sLaLFiSpYQea XfHzC18ptlU0ACTbB6oAHfmgENmLN98AimM8EF8BZM02f+wK6bdaI5PZTiGJtbmHmPU5 VD2/ojwhU4h69ANXbQjJpjP5eDWY+s5qQXW9WTttVBGM7gRvkacRE3ZJpy0VCGLfHKcb iNKUxaGvdZug+Xn67B5s93dumwX+Hysc9hJZw9NySZ9jeQ27+cAnCqCDPsU8xTgFP6si YyGw== X-Gm-Message-State: AElRT7HT5MY/MnKLHYbDRELmcZs/sgaWfpQ1YV/aWGAcruYcI4TANnlZ ZUuPzboD2ATau87elDdiogZbqQ== X-Received: by 10.46.74.2 with SMTP id x2mr21629298lja.33.1520620629713; Fri, 09 Mar 2018 10:37:09 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.81.26]) by smtp.gmail.com with ESMTPSA id s62-v6sm406682lfk.79.2018.03.09.10.37.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Mar 2018 10:37:09 -0800 (PST) Subject: Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast To: Mohammed Gamal , netdev@vger.kernel.org Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, sthemmin@microsoft.com, davem@davemloft.net, vkuznets@redhat.com, otubo@redhat.com References: <1520601923-26931-1-git-send-email-mgamal@redhat.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <6fcea84b-505b-68bc-709c-d793802f7f6d@cogentembedded.com> Date: Fri, 9 Mar 2018 21:37:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1520601923-26931-1-git-send-email-mgamal@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 03/09/2018 04:25 PM, Mohammed Gamal wrote: > Commit 009f766 intended to filter multicast/broadcast, however At least 12 digits needed here, and the summary line too, just like you do for the Fixes: tag. > the NDIS filter wasn't set properly in non-promiscuous modes, > which resulted in issues like DHCP timeouts. > This patch sets the filter flags correctly. > > Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast") > > Signed-off-by: Mohammed Gamal [...] MBR, Sergei