Received: by 10.223.185.111 with SMTP id b44csp632551wrg; Fri, 9 Mar 2018 10:40:49 -0800 (PST) X-Google-Smtp-Source: AG47ELu9E/WLaZPLV9I4iyOd1N30DWfruH70kQ+GX8gjYEv1NWIVxHw3D4B/5qpcE4oZ1HsC5oe3 X-Received: by 10.101.66.76 with SMTP id d12mr24899366pgq.234.1520620849842; Fri, 09 Mar 2018 10:40:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520620849; cv=none; d=google.com; s=arc-20160816; b=NYrLntAFTEMkw2I/5Oa9QDmUwAv9F0zfFquJmYP102+dNdbN3mf3pG1MQHy4vgBV4n pPSNuNFev7L6EHlFJpKON2IgCnUNQgodbUfeeKLPee/2BVJJ6kPVyHeJ6uwfgEO2EdBQ aUEFsuAjJR0Eay9nb0onWY2pw5njAfIg+cz+21A1Fsa4kAI4AJRFRgCMORVS9vle1R6s Kkoif+EGo3NIu7yBOjamEA3UZDcD6UtIHwFydCC0Pay1QjhZrI4tj+XJtv0Y9xqwMx6Y Q1PtLKypk1NGlYQzBeHwoYjwPTZt0oaH+nCEmoe6PwhPU/5CM9CSwPP/OBPsl8MCAiTX C4BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:references:cc:to:from:subject :dkim-signature:arc-authentication-results; bh=NXHjrCwvSR6DMZ3eRKWXXZnm0huIxlRWqw5zl0qdE50=; b=VF+HIL4tYHZ1sCBTFnDN5OihehmtXkUsm6jIaHG4RC+4CIViAilnpKrvyZHPWRUUzL Rb8vMnOZlZ4SKO9zkq7mHagUAmtH85y+BNDPWXLS8S9/aoNiOTja4pR6zq7xhDfmF+oG E3DxKeXzNPtU7UiB/x2iL7ZKt1MDsSll+eHrSn2eDuqVBmlTbISXVQcPXBl9PbKdiHbH 60dOsZqiaAmK1YzM2LPxpiLMB7Lto61BPD4WplV0Jze0vLWFoi330K+ijEI+6aoN015s D83qqnqCSn2CjHU9SOfTh9DfL2aI9hjXm3FfcDGTrcUgoElBYYBkWN9FOr6fcbMTWKpf sPww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=o3+BDxp2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q126si1281467pfc.43.2018.03.09.10.40.35; Fri, 09 Mar 2018 10:40:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=o3+BDxp2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbeCISid (ORCPT + 99 others); Fri, 9 Mar 2018 13:38:33 -0500 Received: from mail-lf0-f53.google.com ([209.85.215.53]:36456 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbeCISic (ORCPT ); Fri, 9 Mar 2018 13:38:32 -0500 Received: by mail-lf0-f53.google.com with SMTP id e28-v6so5572861lfc.3 for ; Fri, 09 Mar 2018 10:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NXHjrCwvSR6DMZ3eRKWXXZnm0huIxlRWqw5zl0qdE50=; b=o3+BDxp2xBdDVM8/4yOnVzWuKxMU26eVx9Dt+zRbFLjyFnK28vF36E9pJXDbK/BAzZ wfp2fzRypJ+tR6/5F2oS1sNFmUWwuljHB637Pb7JURxjKg945sDIs/sUI4A833g5nrUc h9kg8J6FOSnuCYp0MY5x20hgsWtJ4W5rqbxMRuF5YMuFcbeePo60dQuCWdZ9wO121iLh 7Ly/gXUEr1s6WSjomrjt030ViKRfplc2pBSYroTceZC9204hP44tW1f8qZbP0hsMuIQE /cHyqEgH69dZQDWJOUnOq3dSRO3IARorxQD664V6plt4H1n5Z9Clx1d13kuUDgwWI9WT d+wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NXHjrCwvSR6DMZ3eRKWXXZnm0huIxlRWqw5zl0qdE50=; b=rNvkKgPz1Cw2f75zWZgn+HPduHFRyFiCCWpm/V03wFoYCijORNo/6rO7bww/ueGdKu HwmGr2YC6zzySKESdw04MZSdHZzNYyzzV//PdCkA5L/otD/zLXfINS+86zIdqgD3QHWo 9SWDpyvfVoyBVPYnKlc9dqzxgdSL27tLfy6Bp8gNRZRGO7Rg0Fv7/FXeexDLGfwsIxs8 EMynrE6gcQkutLR6r2k8bsTVpO8PnEhhpxtv0Jb77b1h/1ZflLcdNhG7yIv4/xMx+4JI C5abOOkt5QEgrMLm/WUxvZ2VLIQNfUwPf41DSqcjiXKKOdf1B8evR8DN1cYlX8/dDaub K4zA== X-Gm-Message-State: AElRT7EfHxWuLkFjW4h8XrKEsoqKS1I96LOqHTj6ZOabwytXXG95O27I KyWTmdh4aIDQqdEMjGUeCLBZzw== X-Received: by 10.25.142.72 with SMTP id q69mr22807650lfd.82.1520620710492; Fri, 09 Mar 2018 10:38:30 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.81.26]) by smtp.gmail.com with ESMTPSA id 202sm402449ljj.2.2018.03.09.10.38.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Mar 2018 10:38:30 -0800 (PST) Subject: Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast From: Sergei Shtylyov To: Mohammed Gamal , netdev@vger.kernel.org Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, sthemmin@microsoft.com, davem@davemloft.net, vkuznets@redhat.com, otubo@redhat.com References: <1520601923-26931-1-git-send-email-mgamal@redhat.com> <6fcea84b-505b-68bc-709c-d793802f7f6d@cogentembedded.com> Organization: Cogent Embedded Message-ID: Date: Fri, 9 Mar 2018 21:38:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6fcea84b-505b-68bc-709c-d793802f7f6d@cogentembedded.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2018 09:37 PM, Sergei Shtylyov wrote: >> Commit 009f766 intended to filter multicast/broadcast, however > > At least 12 digits needed here, and the summary line too, just like you do > for the Fixes: tag. > >> the NDIS filter wasn't set properly in non-promiscuous modes, >> which resulted in issues like DHCP timeouts. >> This patch sets the filter flags correctly. >> >> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast") 12 digits needed here as well. >> >> Signed-off-by: Mohammed Gamal > [...] MBR, Sergei