Received: by 10.223.185.111 with SMTP id b44csp652264wrg; Fri, 9 Mar 2018 11:03:00 -0800 (PST) X-Google-Smtp-Source: AG47ELtrANOiEAXNMYZHnH5lkZDeG/N44cQeT538mOQIeX0WRQ84pq7Q3+H3JU8QWMf+KJPALdOZ X-Received: by 10.99.122.71 with SMTP id j7mr24850895pgn.151.1520622180565; Fri, 09 Mar 2018 11:03:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520622180; cv=none; d=google.com; s=arc-20160816; b=eQm2nByHe86GQOwsxXLYnKwnqtguq8GXkOFLRHwdkIlcnDpAa6btHjwxZtJAqWMKLp 6V8z+GXzXOVt6A036/YZxoaV3CRXtMGu62O7KZYGyVpoOQ9KeuAe75x7qVkOSFDgDZay xyCU8l2ZX/QeJPj1TQ+91gOYofDDXiAHtTCc9QAiqzfHqSf+PN0o0FkJ74w4tgV4EdxK gq8ahxCTw5bGbVAOcm8SF7fRe2JDYb+S8RiTA7IEotGjj5F7S6QxNrsMxYVZADcNMYvZ a5lCQV5M6YGMI7TB6tgmzeqWsxXYLglR1LeouXx+iRDegDmzlsIaideOFpjxIP5M/h7i i71A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dmarc-filter:arc-authentication-results; bh=eX/ITnpPUtdJlcj3XsiTf6frk1HxJzsDgu6SuOPSSx8=; b=PnAA8nHYYYff+xYt0EKTSgsDtMeZS3nYu6cHCsl2x9k03xFo8+UpPfznhqC7T1zbgp FXb+bzLz8CFjYVvKFmysz5tIjWqf0pSnIdjDqhD8oErUYTPYWo++DUN0yAao69C0Dxa3 PbhCQFz4jidgM0Qn2h25Y/h1t7UoGGCYnhS1+pNlBUl77MVVGRaa2EeCKtorPI8I8apY Z+k2YqaIjoNdibmMVT4jOOyLhWrZ5fCkjB9OQMxzmtmaFdn0ObsWeK+o2n5Hh+9yCXdM klcibHFe5wf2bpZ8NmvoQHMlH8RTk0mxoLmNiYdAggqAXVBoXLLoA/M3HqGXAmeSHXmr mzXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si827416pgn.46.2018.03.09.11.02.45; Fri, 09 Mar 2018 11:03:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932612AbeCITAD (ORCPT + 99 others); Fri, 9 Mar 2018 14:00:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:40656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932468AbeCITAB (ORCPT ); Fri, 9 Mar 2018 14:00:01 -0500 Received: from localhost (unknown [104.132.51.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6287B21771; Fri, 9 Mar 2018 19:00:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6287B21771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Subject: [PATCH v2 02/13] PCI/PM: Move pcie_clear_root_pme_status() to core From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Keith Busch , Sinan Kaya , Lukas Wunner , Frederick Lawler Date: Fri, 09 Mar 2018 13:00:00 -0600 Message-ID: <152062200018.77693.9632596426168244205.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <152062141493.77693.9630397416694091342.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <152062141493.77693.9630397416694091342.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas Move pcie_clear_root_pme_status() from the port driver to the PCI core so it will be available even when the port driver isn't present. No functional change intended. Signed-off-by: Bjorn Helgaas Reviewed-by: Rafael J. Wysocki --- drivers/pci/pci.c | 9 +++++++++ drivers/pci/pci.h | 1 + drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_pci.c | 9 --------- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..120e3393fc35 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1683,6 +1683,15 @@ int pci_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state state) } EXPORT_SYMBOL_GPL(pci_set_pcie_reset_state); +/** + * pcie_clear_root_pme_status - Clear root port PME interrupt status. + * @dev: PCIe root port or event collector. + */ +void pcie_clear_root_pme_status(struct pci_dev *dev) +{ + pcie_capability_set_dword(dev, PCI_EXP_RTSTA, PCI_EXP_RTSTA_PME); +} + /** * pci_check_pme_status - Check if given device has generated PME. * @dev: Device to check. diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index fcd81911b127..813ca2c895d8 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -71,6 +71,7 @@ void pci_update_current_state(struct pci_dev *dev, pci_power_t state); void pci_power_up(struct pci_dev *dev); void pci_disable_enabled_device(struct pci_dev *dev); int pci_finish_runtime_suspend(struct pci_dev *dev); +void pcie_clear_root_pme_status(struct pci_dev *dev); int __pci_pme_wakeup(struct pci_dev *dev, void *ign); void pci_pme_restore(struct pci_dev *dev); bool pci_dev_keep_suspended(struct pci_dev *dev); diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index d4009e35702c..7086086e45d0 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -93,8 +93,6 @@ void pcie_port_bus_unregister(void); struct pci_dev; -void pcie_clear_root_pme_status(struct pci_dev *dev); - #ifdef CONFIG_HOTPLUG_PCI_PCIE extern bool pciehp_msi_disabled; diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c index 977bd3cca2e5..d6f10a97d400 100644 --- a/drivers/pci/pcie/portdrv_pci.c +++ b/drivers/pci/pcie/portdrv_pci.c @@ -49,15 +49,6 @@ __setup("pcie_ports=", pcie_port_setup); /* global data */ -/** - * pcie_clear_root_pme_status - Clear root port PME interrupt status. - * @dev: PCIe root port or event collector. - */ -void pcie_clear_root_pme_status(struct pci_dev *dev) -{ - pcie_capability_set_dword(dev, PCI_EXP_RTSTA, PCI_EXP_RTSTA_PME); -} - static int pcie_portdrv_restore_config(struct pci_dev *dev) { int retval;