Received: by 10.223.185.111 with SMTP id b44csp660483wrg; Fri, 9 Mar 2018 11:11:48 -0800 (PST) X-Google-Smtp-Source: AG47ELsPk7I59AHWwJaMUEKNUHgeyc1Ni1rEg05J5PFT943EYsJK/i98cS4Sd7cR1SB9lSG73a5c X-Received: by 10.101.89.6 with SMTP id f6mr25277372pgu.22.1520622707871; Fri, 09 Mar 2018 11:11:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520622707; cv=none; d=google.com; s=arc-20160816; b=xe1U8g3sX8Yfb4vtH/+0flI6xXN02z/jyxLJC2xhElEoUWTHdqy4BkXLEvZqKDRbAm HYEQZSAO8ddrEsFYphnX8fjS5cbnGebyX9SC7VSgyUkGo1xEhvx22tDNxNGovuLsrPHQ VtaqalaklheiK8ltcfQczzhzWLV0ALxqEAbNg6wmaPIsiv5tWCsXPJxCZl6kROuCE/9l yIXGZT5vN8+J2GC6fuxCIflhzsWvILBcnrR7ofZzfsMTLX3HRrWbQGH40ZKL7P6cIIUA H1sm2FBwc+928R2WiKw1q9kJUQGe0WzqiryCkMHrpiz18TXJEOtH3QZeel65zu/G6aXc RoAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:date:from:dkim-signature :arc-authentication-results; bh=8vcPAICI3z/WqLO/FGiqoziN3s9MmbuYi1zjbOuCTSY=; b=q2Whk1dyxKC7qy9IwmrEH32vyISwBbHc5VwTXs/bjtYD2+6p66rwGla10Una6FMIoQ sTSa1Pnu59daxYekW6lTQlAcnhAgIlu4sTXpPM2HR+nwtGe1cb4KNc9tKHIOJQHNM8QY eMtsYtLocnBXkp+SbclLFr7RftyEXQ7LkQHyJmZbZ0A8kKibXuUPcacthFNVjvANEJxd Bkl0BOlW84K2lPm//N5ug2h0JSju0KKriNUyyKioe4IEEAHeokyXu2ZBs5wkLglIawtN DrgGvl9BqocQUrkYrgU0pZnuyvAq7qoMVJYeuuiegPNJXyVMuwKm2O7L0VCRAk3+DSf2 I4GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@maine.edu header.s=google header.b=HchKD/lY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10-v6si1281824plh.403.2018.03.09.11.11.32; Fri, 09 Mar 2018 11:11:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@maine.edu header.s=google header.b=HchKD/lY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932486AbeCITKg (ORCPT + 99 others); Fri, 9 Mar 2018 14:10:36 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:34372 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183AbeCITKe (ORCPT ); Fri, 9 Mar 2018 14:10:34 -0500 Received: by mail-it0-f67.google.com with SMTP id n128-v6so3586889ith.1 for ; Fri, 09 Mar 2018 11:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maine.edu; s=google; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=8vcPAICI3z/WqLO/FGiqoziN3s9MmbuYi1zjbOuCTSY=; b=HchKD/lYmwv7NOvpyZI3babfDp58twoxLMzZ1xk4UIBaRwNj1soUDhbes2gLet+nxb 9GRLhVBIuIYsk2Ok9JGp5NHl5nlKwBHszvkJeSVwcpHpnDyVe8Mc2+8Hr0hNoDkZYk/Z 4+ZgC/1sW30JzrZ+qN2PTaVNPCFxhLELXHpr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=8vcPAICI3z/WqLO/FGiqoziN3s9MmbuYi1zjbOuCTSY=; b=KMTwu2RuqFOC1G3v7oQBka0FW35vtCq6tRKIa90ngPpN0msSfSP22BoLBqgYQSwhT5 okbaGZb9bTEOqZH+g9bv/yf3T2kLU9Uq/rv90/4VcdS/LARVh5VTxvCEloh7jd0fP7Zk S6Yty7MmShIYlwCA+5JYJe8VEnA4MyhP3dmHtp5kyatedxCoIlpayg7LA/df9fsByxMz y2sE0AEkZSZMnSn3KDRr8T1x9VUuQUh5BIBhxEDTZGa9qUzXJrTkOvtfGgQ01jjpxkx4 0zqnIWWG/GbvNxzOQBAlCpIbCdQr0A0uNPFxRkHqcO+YfHD+9thtrk6LipkuyDIpappW T3Sg== X-Gm-Message-State: AElRT7GTFnfWLq1svfeUVpBI4fJD6eEhqYygOf6jewE/4VTl7S6O05jL 5+rKYG0em5fxlJlzCBRPq/TD5xPH X-Received: by 10.36.79.12 with SMTP id c12mr4881986itb.37.1520622633848; Fri, 09 Mar 2018 11:10:33 -0800 (PST) Received: from macbook-air (weaver.eece.maine.edu. [130.111.218.23]) by smtp.gmail.com with ESMTPSA id w130sm226535iod.25.2018.03.09.11.10.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Mar 2018 11:10:32 -0800 (PST) From: Vince Weaver X-Google-Original-From: Vince Weaver Date: Fri, 9 Mar 2018 14:10:30 -0500 (EST) X-X-Sender: vince@macbook-air To: Peter Zijlstra cc: Vince Weaver , kan.liang@linux.intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, eranian@google.com, acme@redhat.com, hpa@zytor.com, alexander.shishkin@linux.intel.com, mingo@kernel.org, jolsa@redhat.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] perf/x86/intel: Disable userspace RDPMC usage for large PEBS In-Reply-To: <20180309174218.GB4064@hirez.programming.kicks-ass.net> Message-ID: References: <1518474035-21006-6-git-send-email-kan.liang@linux.intel.com> <20180309174218.GB4064@hirez.programming.kicks-ass.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Mar 2018, Peter Zijlstra wrote: > On Fri, Mar 09, 2018 at 09:31:11AM -0500, Vince Weaver wrote: > > On Fri, 9 Mar 2018, tip-bot for Kan Liang wrote: > > > > > Commit-ID: 1af22eba248efe2de25658041a80a3d40fb3e92e > > > Gitweb: https://git.kernel.org/tip/1af22eba248efe2de25658041a80a3d40fb3e92e > > > Author: Kan Liang > > > AuthorDate: Mon, 12 Feb 2018 14:20:35 -0800 > > > Committer: Ingo Molnar > > > CommitDate: Fri, 9 Mar 2018 08:22:23 +0100 > > > > > > perf/x86/intel: Disable userspace RDPMC usage for large PEBS > > > > > > > > > So this whole commit log is about disabling RDPMC usage for "large PEBS" > > but the actual change disables RDPMC if "PERF_X86_EVENT_FREERUNNING" > > > > Either the commit log is really misleading, or else a poor name was chosen > > for this feature. > > Its the same thing, and yes that might want renaming I suppose. I apologize for noticing these things so late in the game, but I haven't had time to keep up with a full lkml feed recently so I only see these things once I'm CC'd on them. So to summarize this: rdpmc is only disabled on a per-event basis, and only if that event is doing multi-pebs sampling? If that's true, then I don't think I have an issue with this. We finally got rdpmc support in a released PAPI, and it is a massive improvement when self-monitoring (even moreso if KPTI is enabled) so I was just trying to make sure this wouldn't suddenly disable rdpmc out from under us. Vince