Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180309213327.GA2806@codeaurora.org>
References: <20180302164317.10554-1-ilina@codeaurora.org> <20180302164317.10554-2-ilina@codeaurora.org>
 <152036550693.218381.11708415467260101936@swboyd.mtv.corp.google.com> <20180309213327.GA2806@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
Date:   Fri, 9 Mar 2018 13:37:12 -0800
Message-ID: <CAE-0n53SY8MgNpvDXXC=52Ddo9gvYBV3PZuL1fHBx8BZHbfd0w@mail.gmail.com>
Subject: Re: [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for
 QCOM SoCs
To:     Lina Iyer <ilina@codeaurora.org>
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        rnayak@codeaurora.org, bjorn.andersson@linaro.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 9, 2018 at 1:33 PM, Lina Iyer <ilina@codeaurora.org> wrote:
> Hi Stephen,
>
> I will address all the comments in the next spin of the patch. Here are
> some responses to the questions.
>
> On Tue, Mar 06 2018 at 12:45 -0700, Stephen Boyd wrote:
>>
>> Quoting Lina Iyer (2018-03-02 08:43:08)
>
> [...]
>>
>> +#include <linux/module.h>
>>
>> If the driver doesn't become tristate, this should become export.h
>> instead of module.h
>>
> MODULE_DEVICE_TABLE seems to need this.
>

If you don't have tristate then MODULE_DEVICE_TABLE isn't needed.