Received: by 10.223.185.111 with SMTP id b44csp821258wrg; Fri, 9 Mar 2018 14:31:11 -0800 (PST) X-Google-Smtp-Source: AG47ELtN6Ir9j83NMq4w6YLCsdIyhCmvWjlSvU2b6O7/Ktm5FTKbbXIyW2xCECVNZI+LzP3LdC3Z X-Received: by 2002:a17:902:12e:: with SMTP id 43-v6mr56314plb.77.1520634671520; Fri, 09 Mar 2018 14:31:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520634671; cv=none; d=google.com; s=arc-20160816; b=jD0zvVb76Rmp56ahrboxYUMe61rJdx3ZuGav4lxDx6lH1OMd9/8gbEML4ZG1FFDDCg hw/SVVlhhDNf814IZ+DEOVhGCjD1VfeA6gu8TDdfv5PPMy8CUL+yd3D9un8SFvSx5pew vtAx+OA+Kj4G32FgE5FUzkf4e8gdEtaNbxt3QDDlyTTKKugvXdMJguBIOibuGyUtJJGj 2I/j93UiofJMnqZZifq2iDDTcgf9MePoxQ1qdEhYVXf9WcWd66nNKA22Dvb5F/uvn11v wR3xBwIlTby+owSG7lh64r8vqI15u4GEC++Almbq09U4qIAZYfbLILfVhXbR2Ouu8F3s twjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=U3xnTS6ryJZ7fcXyXzmYcXNmpI/9s5MvlS/SrXhm72k=; b=cPl9u88Hud9m96W/zuCz9Z8H9ePKk7sryQun75YeNH/T+gb1IUXudPES75Si6+ExGg 3fBYHqfZX3MmY49DGJ7MPZTd6IEJ0FEXYFp0ZTzwhWRYe0mSyvJMGtjTwWdXYz2CD9D+ X3U2Vti1eL+JSE64YL1Wd01uNUZoSDL/+h0/FZX6CHG5+FFgi/6oC8dytcpqar3Lshf0 aeoh4UBR/0AQLrq1Ij9L0RDqqU+oC05OLARK6EDFkRp3z16tUNVGMqwp7ZGaZt//3yQx WhVG1Gpiod3Kf4xXW8FBbUb7Ijd0SJFkDJ2/8Ti77JN+PikPEVBRjcVRliTqR5oo7rTA Vreg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w190si1245857pgb.460.2018.03.09.14.30.56; Fri, 09 Mar 2018 14:31:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932844AbeCIW3b (ORCPT + 99 others); Fri, 9 Mar 2018 17:29:31 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42758 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933070AbeCIWYg (ORCPT ); Fri, 9 Mar 2018 17:24:36 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 7EF892761CB From: Enric Balletbo i Serra To: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, heiko@sntech.de Cc: dri-devel@lists.freedesktop.org, dianders@chromium.org, a.hajda@samsung.com, ykk@rock-chips.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, linux-input@vger.kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, jeffy.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com, wzz@rock-chips.com, hl@rock-chips.com, jingoohan1@gmail.com, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, Laurent.pinchart@ideasonboard.com, kuankuan.y@gmail.com, hshi@chromium.org, Enric Balletbo i Serra Subject: [PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config Date: Fri, 9 Mar 2018 23:23:12 +0100 Message-Id: <20180309222327.18689-22-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180309222327.18689-1-enric.balletbo@collabora.com> References: <20180309222327.18689-1-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go continue and the streamclk is ok if we wait enough time, it does no effect on display. Let's change this error to warn. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 1f1cb624414d..d76e1652b1fd 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -921,8 +921,9 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp) done_count = 0; } if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { - dev_err(dp->dev, "Timeout of video streamclk ok\n"); - return -ETIMEDOUT; + dev_warn(dp->dev, + "Ignoring timeout of video streamclk ok\n"); + break; } usleep_range(1000, 1001); -- 2.16.1