Received: by 10.223.185.111 with SMTP id b44csp862648wrg; Fri, 9 Mar 2018 15:27:55 -0800 (PST) X-Google-Smtp-Source: AG47ELsI5dNA+niu1iMf9zvXK3QeG5mw4bE7PntA4ssnQbWsPxl4fGrxukfx86Xc6KWTp64oqMOc X-Received: by 10.98.75.129 with SMTP id d1mr187788pfj.19.1520638075471; Fri, 09 Mar 2018 15:27:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520638075; cv=none; d=google.com; s=arc-20160816; b=k+D+fKSTX2sY1ksMAb3gqoIkz81pknpq3IBL7B1gKKdrTFkC1G8k7z/4X4q4h0cbaR nS9XzckmOJCiD7vWgMTHmwme/8bJm8NdKv7TS3u7T8VKPBBA5udU2oHBm0Qv8JCVbGqx z6pdSILEgHc48nP9mwaOryO+1281N5OQBn8KE7N8S6aY5izM6cSnuxu2OPATqwU6sRXf j3D1hO7nThNQxHxd0nIXjK1JcDec2eButndq4QPXc/kCp5Y60UiF5Ht3a5OMCzriOZcC 8SGzH/E5DtfSwoyWDtjuwEEMjzZTJXVFY4V/adxhAHztX0jDQQqLHemOoj4XkNR85jiE Yg7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=XeEXh1lt7+wzaUc6/wO8dyYHw2dhb5Ooa/ljXR12ws4=; b=jLPS3g2kFxYODF/aFaD9unWIqTRT6xTQgLBNoFqhnpyeL/vB7X+F9twDZ8sL5Y58Pl 0jIHHyE5C3OmSDuWUQFJVI2XU7BFXOOocrlGzTpP2kNy9afMn44Z9/qtBLWowJ5blbuj TmfIiqKv7fNeYcKNArs5aivpGroEQDoLio8HJzgu7nuufKPBtMQsb9SXJnDASIZYdpO2 2XkDfLmio2SqvCljN5PI5hwfJXOuWUb7l4NTPaE2gA1CFy+0lqPKTB5Tv+BrTZJ09adW I8utiImpd6dEI8pw+f0D5gml4WsF/ZrjiTaiUGjFSkGrGITFqSI/WkgpNiEMiNMBK8qy BEeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=crtAx23H; dkim=pass header.i=@codeaurora.org header.s=default header.b=H/F3wLSS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si1411565pgv.414.2018.03.09.15.27.40; Fri, 09 Mar 2018 15:27:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=crtAx23H; dkim=pass header.i=@codeaurora.org header.s=default header.b=H/F3wLSS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932868AbeCIX0C (ORCPT + 99 others); Fri, 9 Mar 2018 18:26:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53796 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932757AbeCIXZ4 (ORCPT ); Fri, 9 Mar 2018 18:25:56 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7AA8760A60; Fri, 9 Mar 2018 23:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520637955; bh=MHWZHXV+OvAEihQtoRZCNxxNnKz750XbrH4xViazJ6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=crtAx23HudvqcNiUXd2fASoE1lOd7t3mBH3WdFyNHAeq79zObyZ+kns2yg1KjQiUr HCZ0FgPPPkBxt90VZ56CiWDAn8Pn7x4G8t+evmQbKitSy6N3skUWmVkXFgroyXCxGu W5b9V3sZuXXRuSI4nlHax1Ww3x00mlqXpDjl19qM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from codeaurora.org (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9F12860858; Fri, 9 Mar 2018 23:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520637954; bh=MHWZHXV+OvAEihQtoRZCNxxNnKz750XbrH4xViazJ6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H/F3wLSS80QLZeRuYvj6pEryALvCyc/zK1DJilp+Mflqy1aU13gDETP2FQ83JRKoD tqJXG+sDKPied31HihrxLSTtxWoH7+rjdv2ZErAJqQqxgjcLPTSK/U+sYLl/N+Axai 5tQUqnPmmwmaj2zraKk+wBxNaB6ITVo3exg7T12o= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9F12860858 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org From: Lina Iyer To: andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org Cc: linux-soc@vger.kernel.org, rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, sboyd@kernel.org, Lina Iyer Subject: [PATCH v4 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS Date: Fri, 9 Mar 2018 16:25:38 -0700 Message-Id: <20180309232543.24636-6-ilina@codeaurora.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180309232543.24636-1-ilina@codeaurora.org> References: <20180309232543.24636-1-ilina@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sleep and wake requests are sent when the application processor subsystem of the SoC is entering deep sleep states like in suspend. These requests help lower the system power requirements when the resources are not in use. Sleep and wake requests are written to the TCS slots but are not triggered at the time of writing. The TCS are triggered by the firmware after the last of the CPUs has executed its WFI. Since these requests may come in different batches of requests, it is the job of this controller driver to find and arrange the requests into the available TCSes. Signed-off-by: Lina Iyer --- drivers/soc/qcom/rpmh-internal.h | 9 ++- drivers/soc/qcom/rpmh-rsc.c | 120 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 128 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/rpmh-internal.h b/drivers/soc/qcom/rpmh-internal.h index 125f9faec536..638662721086 100644 --- a/drivers/soc/qcom/rpmh-internal.h +++ b/drivers/soc/qcom/rpmh-internal.h @@ -14,6 +14,7 @@ #define MAX_CMDS_PER_TCS 16 #define MAX_TCS_PER_TYPE 3 #define MAX_TCS_NR (MAX_TCS_PER_TYPE * TCS_TYPE_NR) +#define MAX_TCS_SLOTS (MAX_CMDS_PER_TCS * MAX_TCS_PER_TYPE) struct rsc_drv; @@ -45,6 +46,8 @@ struct tcs_response { * @ncpt: number of commands in each TCS * @lock: lock for synchronizing this TCS writes * @responses: response objects for requests sent from each TCS + * @cmd_cache: flattened cache of cmds in sleep/wake TCS + * @slots: indicates which of @cmd_addr are occupied */ struct tcs_group { struct rsc_drv *drv; @@ -55,6 +58,8 @@ struct tcs_group { int ncpt; spinlock_t lock; struct tcs_response *responses[MAX_TCS_PER_TYPE]; + u32 *cmd_cache; + DECLARE_BITMAP(slots, MAX_TCS_SLOTS); }; /** @@ -69,7 +74,7 @@ struct tcs_group { * list of responses that needs to be sent to caller * @tcs: TCS groups * @tcs_in_use: s/w state of the TCS - * @drv_lock: synchronize state of the controller + * @drv_lock: synchronize state of the controller */ struct rsc_drv { const char *name; @@ -85,6 +90,8 @@ struct rsc_drv { int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg); +int rpmh_rsc_write_ctrl_data(struct rsc_drv *drv, + const struct tcs_request *msg); void rpmh_tx_done(const struct tcs_request *msg, int r); diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index c5cde917dba6..58fc7254b6f3 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -171,6 +171,12 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv, case RPMH_ACTIVE_ONLY_STATE: type = ACTIVE_TCS; break; + case RPMH_WAKE_ONLY_STATE: + type = WAKE_TCS; + break; + case RPMH_SLEEP_STATE: + type = SLEEP_TCS; + break; default: return ERR_PTR(-EINVAL); } @@ -439,6 +445,107 @@ int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg) } EXPORT_SYMBOL(rpmh_rsc_send_data); +static int find_match(const struct tcs_group *tcs, const struct tcs_cmd *cmd, + int len) +{ + int i, j; + + /* Check for already cached commands */ + for_each_set_bit(i, tcs->slots, MAX_TCS_SLOTS) { + for (j = 0; j < len; j++) { + if (tcs->cmd_cache[i] != cmd[0].addr) { + if (j == 0) + break; + WARN(tcs->cmd_cache[i + j] != cmd[j].addr, + "Message does not match previous sequence.\n"); + return -EINVAL; + } else if (j == len - 1) { + return i; + } + } + } + + return -ENODATA; +} + +static int find_slots(struct tcs_group *tcs, const struct tcs_request *msg, + int *m, int *n) +{ + int slot, offset; + int i = 0; + + /* Find if we already have the msg in our TCS */ + slot = find_match(tcs, msg->cmds, msg->num_cmds); + if (slot >= 0) + goto copy_data; + + /* Do over, until we can fit the full payload in a TCS */ + do { + slot = bitmap_find_next_zero_area(tcs->slots, MAX_TCS_SLOTS, + i, msg->num_cmds, 0); + if (slot == MAX_TCS_SLOTS) + return -ENOMEM; + i += tcs->ncpt; + } while (slot + msg->num_cmds - 1 >= i); + +copy_data: + bitmap_set(tcs->slots, slot, msg->num_cmds); + /* Copy the addresses of the resources over to the slots */ + for (i = 0; i < msg->num_cmds; i++) + tcs->cmd_cache[slot + i] = msg->cmds[i].addr; + + offset = slot / tcs->ncpt; + *m = offset + tcs->offset; + *n = slot % tcs->ncpt; + + return 0; +} + +static int tcs_ctrl_write(struct rsc_drv *drv, const struct tcs_request *msg) +{ + struct tcs_group *tcs; + int m = 0, n = 0; + unsigned long flags; + int ret; + + tcs = get_tcs_for_msg(drv, msg); + if (IS_ERR(tcs)) + return PTR_ERR(tcs); + + spin_lock_irqsave(&tcs->lock, flags); + /* find the m-th TCS and the n-th position in the TCS to write to */ + ret = find_slots(tcs, msg, &m, &n); + if (!ret) + __tcs_buffer_write(drv, m, n, msg); + spin_unlock_irqrestore(&tcs->lock, flags); + + return ret; +} + +/** + * rpmh_rsc_write_ctrl_data: Write request to the controller + * + * @drv: the controller + * @msg: the data to be written to the controller + * + * There is no response returned for writing the request to the controller. + */ +int rpmh_rsc_write_ctrl_data(struct rsc_drv *drv, const struct tcs_request *msg) +{ + if (!msg || !msg->cmds || !msg->num_cmds || + msg->num_cmds > MAX_RPMH_PAYLOAD) { + pr_err("Payload error\n"); + return -EINVAL; + } + + /* Data sent to this API will not be sent immediately */ + if (msg->state == RPMH_ACTIVE_ONLY_STATE) + return -EINVAL; + + return tcs_ctrl_write(drv, msg); +} +EXPORT_SYMBOL(rpmh_rsc_write_ctrl_data); + static int rpmh_probe_tcs_config(struct platform_device *pdev, struct rsc_drv *drv) { @@ -512,6 +619,19 @@ static int rpmh_probe_tcs_config(struct platform_device *pdev, tcs->mask = ((1 << tcs->num_tcs) - 1) << st; tcs->offset = st; st += tcs->num_tcs; + + /* + * Allocate memory to cache sleep and wake requests to + * avoid reading TCS register memory. + */ + if (tcs->type == ACTIVE_TCS) + continue; + + tcs->cmd_cache = devm_kcalloc(&pdev->dev, + tcs->num_tcs * ncpt, sizeof(u32), + GFP_KERNEL); + if (!tcs->cmd_cache) + return -ENOMEM; } drv->num_tcs = st; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project