Received: by 10.223.185.111 with SMTP id b44csp917986wrg; Fri, 9 Mar 2018 16:50:19 -0800 (PST) X-Google-Smtp-Source: AG47ELsto1TbxJXhzQ54P0VzIETFMSC/oONhGnTL2vwpMP95t6V53z2auVqgxIB2KUfGOf+dqd6N X-Received: by 10.98.238.2 with SMTP id e2mr389949pfi.68.1520643019250; Fri, 09 Mar 2018 16:50:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520643019; cv=none; d=google.com; s=arc-20160816; b=fgNXnLeRRsBDd1OKGepfUsCzI8W1fprvqwDwbLlcMVf+h9GB84otHjpg+Ug5uOotL8 TBt4xPbYci4UZ8HQf/IJ+K65drAkCsRyQ/PJWrXlfm0/CIFER6Nru72k0ENbdt8wQnHy /fcKYX4NjKZoO9WN8KS5NbgWk0DatxzuwnLqXeirWi6S7Otnak8cEbIQ600+PhQcGyMC Qff+tXP8DeCV9mnbxV7kxQ1QZ8ts68iLpKoxTfjNOJy5RKuL39NuPoZN3gCZSgYGusz7 F1anac4Dcm5oYNsElffU0qwZu61lgfCa4N2UfME9HsxjcxFI5cgWXRTSU6HsFWlA4Jmj mDKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=/tsOHJOwoOmuaa8Y5iERAIialYpAhMEGQusGSBnJVmU=; b=Km+v3F8uq+LkbsA6VAtIsZ6GXABFFH2PKPqhU3PMwrXGpror+2NXsIYWnnuqYQojEc vf1UIuOUbSKDJUOhedpbTXi2scMSL/bjafjCdcP9WFquq4OrV1d7dcOqLzPFt8CD0DM4 XiZPRh2KlNlaczu6jJuJAr5U/XXfzf7iE4Yjdke0VXxwL7o2JrfA0cNyag/T+3d7r4SO 6mc3+q9yBql/dYGIltxYk/Ew9KrfHN/rWndCwFbM+aslf04kZ74J9G5VNQkX/C5sGae+ WJ6VU/NupraiZjVKVdKwhevOcrkGRjJh0uQT5TxNc8G1O7gTCeBpJRbtgz4yuxxHsBKz F5Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t9-v6si536470plq.321.2018.03.09.16.50.05; Fri, 09 Mar 2018 16:50:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933077AbeCJATg (ORCPT + 99 others); Fri, 9 Mar 2018 19:19:36 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38706 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932727AbeCJATc (ORCPT ); Fri, 9 Mar 2018 19:19:32 -0500 Received: from localhost (unknown [185.236.200.248]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 1AACBE6A; Sat, 10 Mar 2018 00:19:32 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Berg , Nicolas Dichtel , "David S. Miller" Subject: [PATCH 3.18 12/21] netlink: ensure to loop over all netns in genlmsg_multicast_allns() Date: Fri, 9 Mar 2018 16:18:34 -0800 Message-Id: <20180310001801.811483018@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180310001801.045114869@linuxfoundation.org> References: <20180310001801.045114869@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicolas Dichtel [ Upstream commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 ] Nowadays, nlmsg_multicast() returns only 0 or -ESRCH but this was not the case when commit 134e63756d5f was pushed. However, there was no reason to stop the loop if a netns does not have listeners. Returns -ESRCH only if there was no listeners in all netns. To avoid having the same problem in the future, I didn't take the assumption that nlmsg_multicast() returns only 0 or -ESRCH. Fixes: 134e63756d5f ("genetlink: make netns aware") CC: Johannes Berg Signed-off-by: Nicolas Dichtel Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/netlink/genetlink.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -1058,6 +1058,7 @@ static int genlmsg_mcast(struct sk_buff { struct sk_buff *tmp; struct net *net, *prev = NULL; + bool delivered = false; int err; for_each_net_rcu(net) { @@ -1069,14 +1070,21 @@ static int genlmsg_mcast(struct sk_buff } err = nlmsg_multicast(prev->genl_sock, tmp, portid, group, flags); - if (err) + if (!err) + delivered = true; + else if (err != -ESRCH) goto error; } prev = net; } - return nlmsg_multicast(prev->genl_sock, skb, portid, group, flags); + err = nlmsg_multicast(prev->genl_sock, skb, portid, group, flags); + if (!err) + delivered = true; + else if (err != -ESRCH) + goto error; + return delivered ? 0 : -ESRCH; error: kfree_skb(skb); return err;