Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 64DFD602A0
Date:   Fri, 9 Mar 2018 21:47:32 -0700
From:   Lina Iyer <ilina@codeaurora.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     andy.gross@linaro.org, david.brown@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        rnayak@codeaurora.org, bjorn.andersson@linaro.org,
        linux-kernel@vger.kernel.org, sboyd@kernel.org
Subject: Re: [PATCH v4 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in
 FTRACE
Message-ID: <20180310044732.GB2806@codeaurora.org>
References: <20180309232543.24636-1-ilina@codeaurora.org>
 <20180309232543.24636-4-ilina@codeaurora.org>
 <20180309185223.19aa6c84@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20180309185223.19aa6c84@gandalf.local.home>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 09 2018 at 16:52 -0700, Steven Rostedt wrote:
>On Fri,  9 Mar 2018 16:25:36 -0700
>Lina Iyer <ilina@codeaurora.org> wrote:
>
>> Log sent RPMH requests and interrupt responses in FTRACE.
>>
>> Cc: Steven Rostedt <rostedt@goodmis.org>
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> ---
>>
>> Changes in v4:
>> 	- fix compilation issues, use __assign_str
>> 	- use %#x instead of 0x%08x
>
>Hmm, I don't believe libtraceevent (used by trace-cmd and perf)
>supports "%#x". But that needs to be fixed in libtraceevent and you
>don't need to modify this patch.
>
>+			 __field(bool, wait)
>
>Usually I would recommend against 'bool' in structures, but it
>shouldn't affect the tracing code. Might want to look at how it
>converts it in the /sys/kernel/tracing/events/rpmh/rpmh_send_msg/format
>file. It probably makes no difference if it was an int.
>
>Other than that... Looks good.

field:bool wait;        offset:32;      size:1; signed:0;

-- Lina
>
>Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
>-- Steve
>
>
>> Changes in v3:
>> 	- Use __string() instead of char *
>> 	- fix TRACE_INCLUDE_PATH
>> ---