Received: by 10.223.185.111 with SMTP id b44csp1384160wrg; Sat, 10 Mar 2018 04:52:23 -0800 (PST) X-Google-Smtp-Source: AG47ELusSXWd5c+1jfqxYlBxbUOVUv1ZWj4WBLksbL/0Jho1UKbevMBKjO2pb2qs0dEBFxcAe0uO X-Received: by 2002:a17:902:b690:: with SMTP id c16-v6mr2024048pls.264.1520686343319; Sat, 10 Mar 2018 04:52:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520686343; cv=none; d=google.com; s=arc-20160816; b=seZSjJQbeI/zEGjQN/Er5dRm59UeIJfnlg0N9TlukqplNNEYluUF9VcZv4o5EGWyR5 ZN629EpHoLAXHsCqD+5Xx0sNEpHknxzkwHS3hDvDGNYvPua8+FNIFNQHe5KQsaQ/LsQZ ndgP9xIUiUSbBOR1zOuKzv7SmOdaUGwlwffD8+/SeYLGxkKaPE8P9acC+UguqaUS/eDT uXqW0Wj/G7DCbqg0NCPgUAicaGwvZS4ip6dle3fjtFC8pJb43kMnBXY2UEkm9ygZcMmJ 9MDw6Zg0u5b2LCHQzSe/uAVwOiARlskQTRhd/6kQJe1+OOkZqhfNQMQ1kMk2bGuSspKf nrBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=NuPztkW9A8wiirwwRDaS7VamTdPZ2U/ZIquL2jkjNI8=; b=UPxjdq8E27wqYvSme9bv+1yxduVeo6gX5UVOnbuIUksK4Nj4wcVJc7DEpWOVIm8ahR Bd/kM/i6i792d7PWkMvdePBvqXcsEAyKo2UbDX0Cux7pZYY+G6CXLFv5O0E4SgXMZBWC TlOLTH8I8WCt4Ky7ypQosedDyIM7UDSD3LZhkmvKYTb5hSNZqT1DbyI900V4MF2X9mOq txfD+HSgrbUBJGaQCZpn1nY4UpCiCNOJFSDjzNHnHAA2SS1uuW32HyJFP06xz8wFPq00 9h57X43w+4kcB5p8+Y0dqDsG1ZUSdch9tioaXGKrBKiL7Nh7cuX1uXYVFVffRPJ/J5MD IyPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si2625529pff.122.2018.03.10.04.52.09; Sat, 10 Mar 2018 04:52:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932906AbeCJMvR (ORCPT + 99 others); Sat, 10 Mar 2018 07:51:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:41598 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932130AbeCJMvQ (ORCPT ); Sat, 10 Mar 2018 07:51:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4E386AE5E; Sat, 10 Mar 2018 12:51:15 +0000 (UTC) Date: Sat, 10 Mar 2018 13:51:13 +0100 From: Jean Delvare To: Alex Hung Cc: LKML Subject: Re: [PATCH][V2] firmware: dmi_scan: add DMI_OEM_STRING support to dmi_matches Message-ID: <20180310135113.61683f08@endymion> In-Reply-To: References: <1519800494-32107-1-git-send-email-alex.hung@canonical.com> <20180309143315.354ad0be@endymion> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Mar 2018 10:56:07 -0800, Alex Hung wrote: > On Fri, Mar 9, 2018 at 5:33 AM, Jean Delvare wrote: > > However it doesn't make sense to commit this change unless there will > > be at least one user of it. What is the status of the piece of code > > which was supposed to use this new feature? > > The original use of DMI on _OSI is no needed anymore - the OEM _OSI > string will always enabled; however, this patch is still needed > because DMI_OEM_STRING are more suitable for many DMI quirks, > especially for Dell systems, and many, if not all, DMI quirks for Dell > systems with DMI_PRODUCT_NAME can be (and should be) replaced by > DMI_OEM_STRING because 1) OEM string contains system id, 2) multiple > product names can be used for the same system id and 3) the number DMI > quirks can be reduced. > > For example, the DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 9020M") in > commit 1f59ab2783aed04f131 can be replaced by > DMI_MATCH_EXACT(DMI_OEM_STRING, "1[0669]") > > I will start sending DMI quirks with DMI_OEM_STRING myself and perhaps > sending a clean up patch to replace DMI_PRODUCT_NAME by DMI_OEM_STRING > for the Dell systems I have access to. With this patch in place first, > I am able to convince others to use DMI_OEM_STRING because there will > fewer risks to spend time in vain. Fair enough. I've fixed the blank line issue and queued your patch for kernel v4.17, thanks for your contribution. -- Jean Delvare SUSE L3 Support