Received: by 10.223.185.111 with SMTP id b44csp1403334wrg; Sat, 10 Mar 2018 05:15:42 -0800 (PST) X-Google-Smtp-Source: AG47ELtODXqJ1MPCrVIGSPZeyuWFe3FvtiO53S8qcPczP4aomdRkQwX9a5ST5s03o9TS1hSc4jLi X-Received: by 10.99.105.7 with SMTP id e7mr1644791pgc.193.1520687742387; Sat, 10 Mar 2018 05:15:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520687742; cv=none; d=google.com; s=arc-20160816; b=wBT7CaZ5tDXQm9yfWfpyI5Dze5ngSOl3q7Zp8WpUdr4sznHx30Z0g2vERAynWUubWs kAudZgJT6Y2FiLKlYPeoVohcJ4zgzeH0e9hrhPHPO6R4FdK4LqkAZt+XT4sZfrb/c40q xACZ7GiWxocpdzlboUPy4PwdkCcVuab1Sb5QkiXjpWASb1v6HZSxrkjtD+PzIk9RpxOK N2GG9HO6B+uv7fvytJOl+FjsnPUWRwpmpWTAiN30y7CWpTC/Tp6FIO9uAgPj8r5jztQ1 vnS5TT4sTIsedPqNc1mOu0bI2zzZrLiq5UPyB8Fmx70jzSiKFnowCNNPNivb5uhzLBJn lfOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=22jpH2Au9IzRifWSHWvuWofMvLQeF7JSK7///wbYmAQ=; b=n2PqJlowoiaP2Yo8f1XsDPZg4sHPyJQaVDDN3DVAU0e/MBRx/UoAypCz61kvCtCNfY tZE2j7Nr4A/E9XWsRcTpOpYr/pdbcbgyGdH5S/BISiH2Y2Hoi9sncY9FAfOB0UvYXbGN gsXcWMUUuvXW/zutV4TNVw41KhPDYSe3rnkt3B5ysnFvkvmbl0cSrSjBz/ZUjgPO9mQm 8s9L4nO6z8RQ2Fi4YU9zfWuPIM1euk0NJ8DBtJGEd9lU20n9a/NocctHcD/c6OUdOA8f w2/AFekWpa2ixQQp8oXgg0HYTr6PWxyYDuh3O9tzXNx6j9hineCUtVOq4SLQkCx9gGWp JpLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j66si2660487pfj.181.2018.03.10.05.14.32; Sat, 10 Mar 2018 05:15:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932966AbeCJNMU (ORCPT + 99 others); Sat, 10 Mar 2018 08:12:20 -0500 Received: from mail.skyhub.de ([5.9.137.197]:55150 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932130AbeCJNMT (ORCPT ); Sat, 10 Mar 2018 08:12:19 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EW7WivtJlY-H; Sat, 10 Mar 2018 14:12:18 +0100 (CET) Received: from pd.tnic (p200300EC2BD4CE00596C69A920A9793D.dip0.t-ipconnect.de [IPv6:2003:ec:2bd4:ce00:596c:69a9:20a9:793d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CCCDB1EC024C; Sat, 10 Mar 2018 14:12:17 +0100 (CET) Date: Sat, 10 Mar 2018 14:12:02 +0100 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/microcode/AMD: check microcode file sanity before loading it Message-ID: <20180310131202.GB8261@pd.tnic> References: <34e9d679-2eca-90cf-9a95-3864f0be060e@maciej.szmigiero.name> <20180310091838.GA8261@pd.tnic> <2cfade76-7d3d-38be-8da6-5927a043a91b@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2cfade76-7d3d-38be-8da6-5927a043a91b@maciej.szmigiero.name> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 10, 2018 at 01:26:00PM +0100, Maciej S. Szmigiero wrote: > Without them, it is easy to crash the driver when just playing with > microcode files You're not supposed to play with the microcode files. If you do and something breaks, you get to keep the pieces. If the official microcode files have a problem, then I'm all ears. Anything else contrived which doesn't actually happen unless someone manipulates them is not an issue the microcode loader should protect against. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.