Received: by 10.192.245.15 with SMTP id i15csp927411imn; Sat, 10 Mar 2018 13:01:03 -0800 (PST) X-Google-Smtp-Source: AG47ELvYrEW9q8dS85pwnHKgX/sghK4xYl2JEBe+/8vYVK2MIEJlqw25vK6g9OBsjz9Z+TLE73/N X-Received: by 10.98.238.2 with SMTP id e2mr2986835pfi.68.1520715662961; Sat, 10 Mar 2018 13:01:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520715662; cv=none; d=google.com; s=arc-20160816; b=utJVmqadchCmdVvHoKyYd085S4vX+1Tc2HdWgW+pWoGTeKq+Scr6vku25+G+PBYSi+ iU9gZM8HYI+IKrikVXdPJYt2JFqsrv+OpimzjFJifjhGgARzJI+B2SaQPyJaj5CNaXNu QOgpAN5k2FiXKP+/hN8R1/1zHGltQh1AEL9OBLLiaBjgH1XHl233O06QN9E9rJ5c7Lfi HELjwyrgpvmjP31AD7nZHYR7R0d5UYx9xwehFP8GEXEb9mPFMps7esg28S3ZPXzXfkpP +hKMvQR6x7x2LOq8XL2+u9PbNCWnSbYfulwtegBlZP5XL2b3fEMJV74up9Sy6XRiErRu kLuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=j2n5hDL8Ixt6QBsQaHc403BRFT+jpyM5Bmgg/ZJRDeg=; b=wHIRs8MppBCtL/29AlBfkt2fL9Do/CCPhGNX8NVP7MVHQUmqziF24gqfc3zYqJQ9UI tkAo9aHOoFZLeFu0NppiBx2ZoUEb6LXEIMhxzgKXHbQQK9tI6nWdlfvYUHbYrj/Rrr4K 9DDsGiwlFSBXDblN/19Jrf58yAUwoB79XvRne7qzbwqGs7/zfOdPyy6up86G8d1yg5eM EZF9m0cwexj9036c+rMj+cJ6iCLoUwU+yPFSZCdX7+RBgO5dYVC7LS4C3q3aEDV7plzK wRAgFZ4C8DGDZM8czU672En3o67wO96toYvhT4vd24dZSoqiCMd2Lym0BMft+5mQtBWd +PGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.co.uk header.s=amazon201209 header.b=E4M/vj8W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si2749701pgp.41.2018.03.10.13.00.48; Sat, 10 Mar 2018 13:01:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.co.uk header.s=amazon201209 header.b=E4M/vj8W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbeCJU7z (ORCPT + 99 others); Sat, 10 Mar 2018 15:59:55 -0500 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:9949 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbeCJU7x (ORCPT ); Sat, 10 Mar 2018 15:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1520715592; x=1552251592; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:mime-version: content-transfer-encoding; bh=j2n5hDL8Ixt6QBsQaHc403BRFT+jpyM5Bmgg/ZJRDeg=; b=E4M/vj8W6gdSaW2d0jDZ1U/ZNHTqHQhAAMSLJo1jYA3N1nlJ+flSsmIx AOiNXkp/GB3iQ17W4WtNPjVkw5DT9wjQ9VPdBE5ZrbpMcVKqZKI5f8qhY QVjM7E0CQbH4Z+JqKhCDakU20yG1Pokz+gUDrOCgjkKyIKbWCY1oKHT9x Q=; X-IronPort-AV: E=Sophos;i="5.47,452,1515456000"; d="scan'208";a="335194601" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-7c3c5f85.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Mar 2018 20:59:50 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2a-7c3c5f85.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id w2AKxllK107279 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 10 Mar 2018 20:59:48 GMT Received: from EX13D02EUB003.ant.amazon.com (10.43.166.172) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Sat, 10 Mar 2018 20:59:48 +0000 Received: from EX13D02EUB001.ant.amazon.com (10.43.166.150) by EX13D02EUB003.ant.amazon.com (10.43.166.172) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Sat, 10 Mar 2018 20:59:47 +0000 Received: from EX13D02EUB001.ant.amazon.com ([10.43.166.150]) by EX13D02EUB001.ant.amazon.com ([10.43.166.150]) with mapi id 15.00.1236.000; Sat, 10 Mar 2018 20:59:47 +0000 From: "Tautschnig, Michael" To: "x86@kernel.org" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jaswinder Singh , Andi Kleen Subject: Re: [PATCH] x86: always use SYSCALL_DEFINE* Thread-Topic: [PATCH] x86: always use SYSCALL_DEFINE* Thread-Index: AQHTuLIpRQ4EwEJShkmMNsa2rpeMXKPJ9BKA Date: Sat, 10 Mar 2018 20:59:46 +0000 Message-ID: <6490B647-209A-4CE6-BFDC-5EC2F62B466D@amazon.com> References: <14A5C8D0-3F9D-486F-A20C-55849D70FC80@amazon.com> In-Reply-To: <14A5C8D0-3F9D-486F-A20C-55849D70FC80@amazon.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.246] Content-Type: text/plain; charset="us-ascii" Content-ID: <7E3E0FFC7CEC3645BBC232E601217066@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 Mar 2018, at 20:55, Tautschnig, Michael wrote: > = > All syscall arguments are passed in as types of the same byte size as > unsigned long (width of full registers). Using a smaller type without a > cast may result in losing bits of information. SYSCALL_DEFINE* introduce > adequate type casts. All definitions of syscalls in x86 except for those > patched here have already been using the appropriate SYSCALL_DEFINE*. [...] Additional context: I had previously made an attempt to ensure type consistency of sys_ioperm as "Syscall arguments are unsigned long (full registers)" (https://lkml.org/lkml/2016/7/4/336). I hope the new proposal is more acceptable. Best, Michael Amazon Web Services UK Limited. Registered in England and Wales with regist= ration number 08650665 with its registered office at 1 Principal Place, Wor= ship Street, London, EC2A 2FA, United Kingdom.