Received: by 10.192.245.15 with SMTP id i15csp936302imn; Sat, 10 Mar 2018 13:34:04 -0800 (PST) X-Google-Smtp-Source: AG47ELuuT4jQ/rzMR5NKeu8QFR2/to2LOQHbd9Ba+aeA8xiESIxFLE2JOQ+vpqr9QCvBmivdWCVs X-Received: by 10.101.100.90 with SMTP id s26mr239923pgv.102.1520717644292; Sat, 10 Mar 2018 13:34:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520717644; cv=none; d=google.com; s=arc-20160816; b=D9e8HDvD9ZF5e+vgLPf76FppclA/vSdfTTD3iAks1jxPw1rjdcgf6GhZuFdpKZTQ2C gLz+FZQIrfBV3wH+JrmFOKbApK7kb6Kj3NS/3tqngtlZCPX82qnLJIwJVpK6pbuj6Gwm EnRQZhWdWO5DXEk6y+LBQAlsPc05hfy+x+3g/6sm7OxKMNVcan14mtSYfpxSJ2uBut3c +3VdA699vUD23MK5TX/Dy/5gdEkzgJ0polrVOO9AxenSOextTQM+YVP1UqGs1hz2c/lh NQksSYeJgYYdjwcpk3p0SxlvQU9ls+X5vCOyp7j6/w0vBJysc1qUXM654CG6sxgYhICW mJPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:arc-authentication-results; bh=fMe+qmdvyLPLL81p2Z+LbJ9k1ah++DamBsn6wKscrLs=; b=dCPQu/wU40pmtVo1miPwb8ATy2J/olxuhnZN3SC9O1h8cCHiZrf3ch1bYGyISu0fpD OR75+PI4iXQQDQF6ed3ohOEuPJnEHtnYiyGQ5vChi5UFdq0hpa3ujyCu5d4kJgVs9szg GDUBRuDAtDW/Eptgv2j4IhLD6l+n7HvRgp4pIjlnU+qVcx9AYOARxN8MvSKTlpvyzInR 90+F938MiVz66EqANnmzzp/UwRyRvc1CN3uOvdS+IYtYNuDrBjxrVuZlg/Dn6BS1lMWk jVMnP4OBKxlPDznnenHuk+cyvZg/vDZjX6sgvDQ7bADS5rTO/e/diupDO9J4AV0KKESu Wn+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b91-v6si3251796plb.268.2018.03.10.13.33.49; Sat, 10 Mar 2018 13:34:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932087AbeCJVcv (ORCPT + 99 others); Sat, 10 Mar 2018 16:32:51 -0500 Received: from mout.web.de ([212.227.15.14]:43801 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbeCJVct (ORCPT ); Sat, 10 Mar 2018 16:32:49 -0500 Received: from [192.168.1.2] ([78.48.54.123]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M4EJn-1ee4Ge42mx-00rqvw; Sat, 10 Mar 2018 22:32:44 +0100 Subject: [PATCH 2/3] wlcore: Return directly after a failed kzalloc() in wl1271_acx_sta_rate_policies() From: SF Markus Elfring To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Colin Ian King , Kalle Valo Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <8ef461f4-5103-9181-b68d-e31720206ee3@users.sourceforge.net> Date: Sat, 10 Mar 2018 22:32:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:zoadzWvpykN4eCs0r7C+kA+K7rw4bhElcaU4tdKarkbDhSk6V3o t3U/Rof8jzeTPX+YmH2lnX/a+Ko/XXhN2t/inKIsh93S0vptWAyVhdiKSaqUWTwJNJp/BZG 2cbTZUSHqRBVckTQgxsN6kiju7rrnd/K14aSTFAdTJTTikva0qtvoRv9kkPZHQHM+Dpmqhw NariMnWaGdJTI7dB4HXtQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:4T86/VfMj08=:GwFeejgDwRfoZbiIk+d5CF sOQP8y9Pj0xQmDBj7n0pYbmBsCF0RZCwFPPGhil6IENTOLOns2fXoj/PmcJIVCtDPzsMtULrX orkKYcDCzPJzVfKKCHEf7m4fNlYVENhr79T6FA3JkQtMvgXpoU9sBWN/6Upz7WefDb5PI2JlV BPddSGPNhuCtaZ/8EAFFf/q9GAESGFMSussJc/WFTEQ7+MskkxZVhF4GsGK0iZyHed7es54cH ND/HdLnVXer9SScDWKCU/jjlTsG8EjqvS1L455aRauX/mdjf+iC4ow5Ly+U1L8n6fvh9XSyVE xIPuwtFBDC9bXz+ZQguiLPHCyjrEPlw2OS1mxzSX7IQT0NYvo5e/CXGm931Wq/3GhB9UVIwEI e0d2xUDstoRSm9Tiy3EcXPpoMXBucPG122wd639l0c5KP5GSY+xoK0V1CL5unO1Augookj/Ld lKQ+s0MIKobFRtlC+/nzNBeQz9g+6hFB/VxUAx5NUBB0K4LHfu3bheBRIHkn9DXszT9EHtkXA UdVY7hTJTNlBiR2pjNhNtlREn+sJPbRGX8Frymf39V9jHNCDh+sz3n+dCbCYQ3aGblo0YZlBK xEP9Kqa8Yb9LusyiagC5yTFvRZXk/a2Ux9yrLmYY6lhhqmSRP9P/JmfYmDp2d1TPe+k0pbOIY LmFly13QsgFIgCd8UBb+7VsHCWJ/mfrrSTx54w7BX7ZegFQRLHAhIfqaLMI7bj6/DsU9xJP1f Qx4n4B+ArhYImo6CiIiWh12djp9mJg6E8N8D8q3Ut/WuoeBQWyo3Dqza/SD06ok5BktxvOJu7 bsVPqMJNl/bNugbxGVuP7/PaQ5L2ol5LR5oMqN1C/h1z2tU6JY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Mar 2018 22:00:31 +0100 Return directly after a call of the function "kzalloc" failed at the beginning. Signed-off-by: Markus Elfring --- drivers/net/wireless/ti/wlcore/acx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c index 6991fee8fe61..1cc5bba670e1 100644 --- a/drivers/net/wireless/ti/wlcore/acx.c +++ b/drivers/net/wireless/ti/wlcore/acx.c @@ -743,11 +743,8 @@ int wl1271_acx_sta_rate_policies(struct wl1271 *wl, struct wl12xx_vif *wlvif) wl1271_debug(DEBUG_ACX, "acx rate policies"); acx = kzalloc(sizeof(*acx), GFP_KERNEL); - - if (!acx) { - ret = -ENOMEM; - goto out; - } + if (!acx) + return -ENOMEM; wl1271_debug(DEBUG_ACX, "basic_rate: 0x%x, full_rate: 0x%x", wlvif->basic_rate, wlvif->rate_set); -- 2.16.2