Received: by 10.192.245.15 with SMTP id i15csp1048432imn; Sat, 10 Mar 2018 22:00:49 -0800 (PST) X-Google-Smtp-Source: AG47ELtDCbVBrKqXcai1Ve/aFgqL1IItjvuLvtOWgD+6HdlOZ0uv9Jctzf0ozItA7qcJn9KDHQkV X-Received: by 10.98.204.69 with SMTP id a66mr3937287pfg.33.1520748049028; Sat, 10 Mar 2018 22:00:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520748049; cv=none; d=google.com; s=arc-20160816; b=bLDU7B7k19HVTQm3MxJll3T13LBifCCtyqwQXXOrqERzVh2LW0yrR/eIk4LLMqEvZH lUJiBbj0os3ugRhsfH5YUYDkoY9JIzGWTtHldYlXWPYnRrlpih47gJ3Fi9/jmPxoEZhT 0C+XG9OcyvIuEK9Wdu8jvhlaV/aYyCjIXc0RJMbvm2LgByxaq1AfjxraJi5Wc9ecf0/x uQhGK5MCnVI9RHuu5Abpy6UgeMMNfja504VfwEm7ww8YldEruXw9W0EamAa9qg69L6Tv 7CAfLCFfcyowTF8BQDzK08S7kNdHIXicAiayOF872xMNgMl5cZz/cqoqvsGKgQDNhQbO 3YPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=xGEPx0+pk8HbrW216HMDt7fFG3uNxoukemKM9i9hd+Y=; b=DajPGeyxpgv1GGqLo+6QAiA9lfm5aV9g+YA0CsX6ZaKPW+LyA0Q01zNMSxM8YrXtuV qY1Q3yUa10o23bpeQSra2qSQ53djAqGeezubTDwXQXKoKs2n8hr9lI1Q9eN30j6bx744 hYY3pPsH8dsA3xZgvIsIY9AJn3Z5qMyBxHhD59G4HItq9iKWE4jnbxyJPEsIDWLrVr8Q +0f8nO4k8pQeXgM3aqVRe5vfemwtbSf1peHg/O8bfuhlbJd2RuzIjx2mm0m8NdvVGkn9 lfUqs4W9ZY5anM+P6s/4ps7O/TkmzEtAtLkKxAV/mfHjKu9Eyagl/0y3hZ25w2dEgTcJ Lzqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Kel7/spI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o81si3795559pfk.67.2018.03.10.21.59.34; Sat, 10 Mar 2018 22:00:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Kel7/spI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932168AbeCKF4V (ORCPT + 99 others); Sun, 11 Mar 2018 00:56:21 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:34255 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932129AbeCKF4S (ORCPT ); Sun, 11 Mar 2018 00:56:18 -0500 Received: by mail-pl0-f67.google.com with SMTP id u13-v6so7530293plq.1 for ; Sat, 10 Mar 2018 21:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=xGEPx0+pk8HbrW216HMDt7fFG3uNxoukemKM9i9hd+Y=; b=Kel7/spItaOpxuc/skdYI8yl/hxPhAT0FzrwOrgQr0fVilz533Kxo+wdhDIBluzrSI LQ+S2Z1bCLtvuWcqzNsg4R1M1M/3JeXV6nNTsp/T3mBFFJPGucbc+9ZZt2HGGf+BVtDo xwvk6QVN73BIYEMZkq5s19SBy1VMURjv80AHABd5QaUQdwhz3pRIINMKcGPJy2AbY6Xe xiK0lobctmJzewb2u6/cEPbXCYiBH+35qbe8v2B2qJ3dUREEnyS+JjpDbMFUa7kPw2gh KY0Wf9b4tPtNuw5yR3I4qv9HjoQFeCVwOR/3AFNaTUISOEQemMYhpimq8fEdpX44L3FQ JHKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=xGEPx0+pk8HbrW216HMDt7fFG3uNxoukemKM9i9hd+Y=; b=T7Tdd8jHrbgtNQGFWQY/b9CToS40VhqGFuRdoNsegotqHuiY3ZbuZ5UvwMdjqSafXx sHQYl0x4d3Qpjn/9C+yuSkfufvaA+wUtVaQokz+DNQXsmVPUGEHZruQOOPLwhpQguI7O 0isZ+rMPUPbwYOeMavAnqbfzpA44dTiZ2CiMsQHMr6Dzt1UOF9HE4npD83E7oe82fLPK 1htvp8hCFIml8//2JTDupUJKmMxfCDNfAGuZF3kRWkJIgBEHAJ0Q5OofUyoPdgDmnOZw Zj1cIo0eF2X2BVXzHfc1mmTMzGfJoN6OFGCQ+fFZ3Z9IxjL3ErjDH8ZBGUOSSjEGRz8m OlPg== X-Gm-Message-State: AElRT7EhY4woZoYSZra8VZ/SF7aY+U/2MpZkAm+FBnX+efgwNfpf0oUi YaKIC/YnbLXqeKILTdjpJUuQmQ== X-Received: by 2002:a17:902:bcc5:: with SMTP id o5-v6mr4120384pls.86.1520747777971; Sat, 10 Mar 2018 21:56:17 -0800 (PST) Received: from localhost.localdomain ([106.51.29.61]) by smtp.gmail.com with ESMTPSA id r62sm11267584pfi.52.2018.03.10.21.56.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 10 Mar 2018 21:56:17 -0800 (PST) From: Arvind Yadav To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/4] driver core: platform: use put_device() if device_register fail Date: Sun, 11 Mar 2018 11:25:49 +0530 Message-Id: <3118280595730def453e9ed89a16c9a8783490f3.1520747459.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/base/platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index f1bf7b3..8075ddc 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -1153,8 +1153,10 @@ int __init platform_bus_init(void) early_platform_cleanup(); error = device_register(&platform_bus); - if (error) + if (error) { + put_device(&platform_bus); return error; + } error = bus_register(&platform_bus_type); if (error) device_unregister(&platform_bus); -- 2.7.4