Received: by 10.192.245.15 with SMTP id i15csp1048435imn; Sat, 10 Mar 2018 22:00:49 -0800 (PST) X-Google-Smtp-Source: AG47ELt9G1xPGknobAo2iqMni4gqXdasG+Vret42GFlInoP1xuVWPrJPFubCOd6CqPh5CRqPxFuk X-Received: by 10.98.11.145 with SMTP id 17mr3935471pfl.150.1520748049025; Sat, 10 Mar 2018 22:00:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520748048; cv=none; d=google.com; s=arc-20160816; b=CKtZTNm/WPfzufK697q4d2MQZaolxt8DiEWgT0sPUU6iIU816OfuxVEuSt40qxuyxD VtrR0gPgd3+o0pe90TGdOMH5E0AC9ixpUOok7u+bzN4kxn9Lcom+rhq8E0lIK+wjn835 +EWn2zeQ52Xtl1J20mFlPOz3W7XnbXw0LKszak5mQKD/0+zzGNZhhMolP3vCSLKemTKk jdxqOyUrSMICmEFABRpP09HD6iX7F45oo10yB01qCJSgBBwzEf2xNbC01e/F36npwBGu KCPxytZv3SnEH3Qty7eox6gV1toyM4Ta2F4mvBu1gVtEZceI5L0Qu5TyJvczh0ToDaAy qBXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=8rotcdPDVPzk+xgtW7Kp1q9KE228hCFS45Nk+YqJPdM=; b=xDKNgZUmACMREQDdO5wF6RXPFGPiEUGwYTYrP+Eru7EpJ3GN+kOcgJGaKR8E6dFh1C i52E1zb386CgcJJod59AcDXPmj0ziaS0OQcImaQSdqT+ACX/tPRTexeqR26Tlu/4ZUzU Kko8SWtgYEpN+1DtqGDkb9Hsl81nKpkvlMee1ZmxFWxrV8b22XXtfD7F8K5tNT/u4HCq RtX9uklpSbf65VRMsTN/X6y8PX2oyX2Iw9SGecg7cdvgvcWOQRZx57IGy2rcux2NFQpD NMTnRmb53qMKsXsHssNLb8YdPgpDpjJY5BfKc9RtO10OAgVl/HTAwkYTeKrbO8CkRoMu LHTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RWQ+6CsK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1-v6si3905209plb.73.2018.03.10.21.59.34; Sat, 10 Mar 2018 22:00:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RWQ+6CsK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214AbeCKF4s (ORCPT + 99 others); Sun, 11 Mar 2018 00:56:48 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:47040 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbeCKF4U (ORCPT ); Sun, 11 Mar 2018 00:56:20 -0500 Received: by mail-pl0-f65.google.com with SMTP id y8-v6so7502114pll.13 for ; Sat, 10 Mar 2018 21:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=8rotcdPDVPzk+xgtW7Kp1q9KE228hCFS45Nk+YqJPdM=; b=RWQ+6CsKQpOxWn+uNmirb5eaQkywxcZ4pbKt/aCVDVqWR2CU45+GtPSnJ1nhBnQrpL gazyeoLp7XaoY/EyqcJaiODFT8paWo+76uX9OM0b5dPtBOZ/4ZlNLMN0ykEU6yvKFBZs w6XsZ50FuSyzfFO3BKwJ/mfEdpTYh/Z9ipuHQMcGJnZtfRSiXhiTbApFAzeB1/WPfExG N6dlgEsAqk65h23C4NDz9KxB9UZXhq4JbkjkJKrrNk2OioMHJO5EFI9Mv6YUgKnpVUdT jfHJHw4ouMjhlIdIhKzsVeWOZHspHUEId5fcF78ExwB0/n1GWlg7Np5j6/VAXh+KmKQM 0fzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=8rotcdPDVPzk+xgtW7Kp1q9KE228hCFS45Nk+YqJPdM=; b=C3I/P3etlizSFXXd/+Flw5Hm5LB+E76uwUgbKY16xVtnvIjZCk4gzLX5Fsl2NbHoV+ r31EmNPJSmC3Yut/Q588mFogHPamyhVpupEe9X2XHd37ktKkVD6CoYFNy2BrLdoPSbBr NQLETsqrRTjXudjr1b/UIYYe8eEa9Lm28hxFqUsEv8e2SCZp6puaW3SRvXbuy23sONVO 4bFhgQx9g9T3IcIYQsDLkaijFQ3SW5dYdz4zZM4p3g7hDLGZls+o6OPcYVq1N348GH0m g9uEoJmH2Hcj7o8w52R8Rprno3uUyK58dw3Ypn9G9vPV6XySCCnWGhOZEc8nGfjntjfE j4gg== X-Gm-Message-State: AElRT7GPOygItK9qk2PkObOBU2tTLn1vNNuyMDlIjwPiqpSPEjHOHmro Bh2df++jb8VxdXEEgQQQgyM= X-Received: by 2002:a17:902:20e5:: with SMTP id v34-v6mr4170657plg.66.1520747779564; Sat, 10 Mar 2018 21:56:19 -0800 (PST) Received: from localhost.localdomain ([106.51.29.61]) by smtp.gmail.com with ESMTPSA id r62sm11267584pfi.52.2018.03.10.21.56.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 10 Mar 2018 21:56:19 -0800 (PST) From: Arvind Yadav To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/4] driver core: node: use put_device() if device_register fail Date: Sun, 11 Mar 2018 11:25:50 +0530 Message-Id: <0511fce261db8e05ebdc58aa50558e208ae99ac6.1520747459.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/base/node.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index ee090ab..c5f81fc 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -315,7 +315,9 @@ static int register_node(struct node *node, int num) node->dev.groups = node_dev_groups; error = device_register(&node->dev); - if (!error){ + if (error) + put_device(&node->dev); + else { hugetlb_register_node(node); compaction_register_node(node); -- 2.7.4