Received: by 10.192.245.15 with SMTP id i15csp1048649imn; Sat, 10 Mar 2018 22:01:31 -0800 (PST) X-Google-Smtp-Source: AG47ELv+ke/aoE2nIAaEfAPVcPtQtKBIve/+cpyd/d6EivAyAxMjftUjv/J0ekrTsUOWpYjJmTor X-Received: by 10.99.127.7 with SMTP id a7mr3360305pgd.52.1520748091415; Sat, 10 Mar 2018 22:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520748091; cv=none; d=google.com; s=arc-20160816; b=PuLWb8bl2p2cpkRko5WTWjH4GPSoTVQMbGtv5o1il5pV1F2GbrtYmWypM5J4Y0lXmq R2+B0+TprVuSrzsC43qEOah91F2bOyKDMZps5oDBmXudYGeIsg4y8jz4f9QFa37d8bDF szQoG5TboJhfdQTc6NPoPnm1Lj7yAc3c+t8f8M06lkrvNBR7SvCCJZVTHapEMh6TdL3m 5IC4JCOwsCmbjz6slmG4dkLILJp1XcLxBJsrxLE7vvW3em0xOZ1TlmePx8Hsw7pITO7I pDtD61tIEYHBkfHD56rhjTaG9tI/p/uDNqYdTKWIu/8uWwnZQG3dVYPpP9yHydrOYMgl z83w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Bed9ywE2+nYJEKoggZM90kNrX2F8ic0tzHIHmoNZUYw=; b=Z5szaW0r2Ahwh+d4CUmOv7epiAiNSQgoTa0089WSi/nCQQyG3tZbsg6UupcnOyfXf3 3TxNxbwj+x9SvW1K7cI6rXiEWu8MWPD7yY/hYGSGM4wWpTyipjPg0sj2AmLQ8uKgUMkZ JI26PtC95KrDGLc/M+A/3QzSxKqJb7YXwOKRttTDm0Pu6uYhICtzTHuFIQTisZnH6RGe reeK1krHzNGCxqCae4j806Zh9o3vlkqH6RKhUalJgYk8jxGOJsBVv9l737r6S9sVT7/Z vjgkfjAn0a/FAAC9+/Y4S3c/zoXIkf+5fx99nEHUQf4s19Y4MVow1jWS7f7R5ABSPL8W h0ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jvQjF29L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e39-v6si3887492plg.364.2018.03.10.22.01.17; Sat, 10 Mar 2018 22:01:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jvQjF29L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbeCKF4S (ORCPT + 99 others); Sun, 11 Mar 2018 00:56:18 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:41058 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbeCKF4Q (ORCPT ); Sun, 11 Mar 2018 00:56:16 -0500 Received: by mail-pl0-f67.google.com with SMTP id d9-v6so7517390plo.8 for ; Sat, 10 Mar 2018 21:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Bed9ywE2+nYJEKoggZM90kNrX2F8ic0tzHIHmoNZUYw=; b=jvQjF29LBKFpa0oecM91VORWP++9mrNKc7n5+f1KDxKW0wBp9CWCPm6etxaZytk/hx FmP477u16owt1bkupvkucldjFpvX2jmFswTvXrvsrRxuSuYO42bIBW3GgrIIhAy7Z5xG olCtfk6ZGwl5pplOGbAMufvVK/20TGreeCj4AQitAGPeHCBqtYWjZND3x+mnJJ5oATpf r5jrGYiZvO1NypqIYU9YjxRrGlxZQ/DS6xELKkbFH8yCGIxrhoDkglEz6ApT8xjdmCGo d2Lt3sopWkYmiBeY1DyZanBfo0zmoAMK7KDeIdlb8nVL1jT51lJoRAUTAQjnlpm8xXDI 8iEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=Bed9ywE2+nYJEKoggZM90kNrX2F8ic0tzHIHmoNZUYw=; b=KorUsN6lEOQllFcHxSOwTamlhCnwElDbujPsienfljWvAXWZG6xebKsHZsb5s7rZrQ SBr1GYlYz7NSkldYUM/PiopeAygiIP3XdZAdZ0sMQshcbVqFHHJ5Moxape3kseH1MiH9 t9kOweUCvjhsz5yBulr5dowSDeJlHSO5ONey1nANglygnF9N+TAJygy6hjEJED/Zpjwo I0m0VPDhg3Gt2QnhZ3p0mYMcJ3p7+Ji2F5LitA21rwzHMvf6lQGp6w1ZNPR/9ot8bMtv tDEKL3B91KqC8HkRgCUvhrq9fPxa9zWr6icHpcmlpQ0DPjXoHUJBMKGKLutQis2rRedj EeTw== X-Gm-Message-State: AElRT7GAQODLxx+8OvksGuRoGjULeBQLi2QzVvAH7BdYTO507dgAuz1Y H/g87DAEKRw3rAp7FLOooqE= X-Received: by 2002:a17:902:5906:: with SMTP id o6-v6mr4122507pli.60.1520747776213; Sat, 10 Mar 2018 21:56:16 -0800 (PST) Received: from localhost.localdomain ([106.51.29.61]) by smtp.gmail.com with ESMTPSA id r62sm11267584pfi.52.2018.03.10.21.56.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 10 Mar 2018 21:56:15 -0800 (PST) From: Arvind Yadav To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/4] base: soc: use put_device() instead of kfree() Date: Sun, 11 Mar 2018 11:25:48 +0530 Message-Id: <9acdde3143458faf8cdc5cf6eae08c3c306bf025.1520747459.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/base/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/soc.c b/drivers/base/soc.c index 4e80f48..10b280f 100644 --- a/drivers/base/soc.c +++ b/drivers/base/soc.c @@ -150,6 +150,8 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr out3: ida_simple_remove(&soc_ida, soc_dev->soc_dev_num); + put_device(&soc_dev->dev); + soc_dev = NULL; out2: kfree(soc_dev); out1: -- 2.7.4