Received: by 10.213.65.16 with SMTP id m16csp10810imf; Sun, 11 Mar 2018 12:11:53 -0700 (PDT) X-Google-Smtp-Source: AG47ELtFpmG+kpaJMkJ1GqSLPOr0EPdklQcgu771+poIQObOE9cT/uwypjFSL1ga/5Qir96g7YCT X-Received: by 10.99.36.193 with SMTP id k184mr4544665pgk.80.1520795512985; Sun, 11 Mar 2018 12:11:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520795512; cv=none; d=google.com; s=arc-20160816; b=I4Cwmzh0JnMxF0hezRxLnn1qUJKopWgGwUmyEUiEGel4wNYAtXtxc3OrRTCmMzKk0V Dbvlkq4KifcqNTR1S3zIrGltiKaPun6GG5EdDeuiqtdt05zXpb1VJ2nimrlouriNTLpQ LEuSCLbu4CsrXgrjP7qGxGXXdjXnqhoOJg40/O59ERT3o6HCQvlFKgmRWC24qH/V6OOx DBLwe1x69uxTiLtxXwCrg14Pu4INIlHhRXY9pNGAo2V+Lgq+lLv907OjV3xILqrVF4Xe cHs8voLgGjCSGGKgqP3RvX9pxBJ5nsdO+jED2xF5NYGpMzqJ8jAgG7znJwMeD/Aj6dpm x//g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=3pqJJHGwteqKnct8WvGUWm66U7EVz8acI8+0YFmzn8E=; b=0u2evXPCUSBO++sMWr8saYscK0/477IXglL1mYjSPyOV3lms4dKgUUoJalcaYqHOVH N6dZw/um2fLfq+T3l/44TdCaQpoKQvxd3j0ypwqv1ut59Lwv71el8mGtPVKaUsNGKp72 ErJpqiB3/Pj0wzpkts+VY1tL51UsX2kDKwDOyfmbBMdzBIvIdsUTNHUh8mapD6RK6MiS i4MLVlCOgfYFrDww99V+VfrHUnnetWh2u9qU7xTzxqlEee5mbi+LZpDKieCIcMRFCCmY oRYVMeST0QsQhFX1y+B6+vssCCkuX0r/Lx2oYno+U4dQj+RFVFpY7UxC73ekJl+IZxB+ 2H1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DmBpvqty; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si3905109pgc.281.2018.03.11.12.11.08; Sun, 11 Mar 2018 12:11:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DmBpvqty; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbeCKTJy (ORCPT + 99 others); Sun, 11 Mar 2018 15:09:54 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:44952 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932141AbeCKTJx (ORCPT ); Sun, 11 Mar 2018 15:09:53 -0400 Received: by mail-pl0-f65.google.com with SMTP id 9-v6so8101391ple.11; Sun, 11 Mar 2018 12:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3pqJJHGwteqKnct8WvGUWm66U7EVz8acI8+0YFmzn8E=; b=DmBpvqtyN94k7izGnnblU8HLa8OEbQPNVOQqsRYmt+I+7nfnloY7xGlhieA1W6Av1U CwnCnSQCsOheDiRqiWxIinSvxcd6n9m9qF+YBKxazDERvIbiXSeZAguiNBESelT1Slxq jDRvP6Ii8kLYw/MX5U7uqm+0w/X35by38BVlppQkJ4t3QW+U5eg9LYAyKKhvhn69NstA +h73r4pHc8/ftI8WVkXZpBuLxWDJUAgoHknHRVVX1rAqETA+ob99kbddLj9wUWCPsR3x aIe08g1/Ls9gnpYIqfpesfsllil/idLzlcbbZ3w3eRrEOrHrlgQNVNviqwZBuLsp5+Wy JObg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3pqJJHGwteqKnct8WvGUWm66U7EVz8acI8+0YFmzn8E=; b=Aqdu1vNmZqHDqZA7n+mPMyfeEE8DudK8pwGjGEwHj7/3JrxDHc76YZ4tuf1sB/5ybK TXSSdFQXv/jv5quBMX1H4e+aLsVBLEHQkVpktTsV5bN9UMFL2WOzJYdiD7gp05KFlXJx rgHS5YDGa7iDAHyTJJVh56rJ6uRbDvVTacNXGPHanrouqyqUboWdUX3/KWdferCBmdnx mc/EJ6fStEXX55cGeIm8ok3AIlo4QO+wSGEelb8ptpn2BHiodFhsAf7pZkHbQJHZC+Qv HP1XHOzYQwvdlP7NZ6NXBvJwK8qB7twEomqJ2PzlfBc/LrqBU6jSQuePSaQ/67Gtn2fN uIug== X-Gm-Message-State: AElRT7Fjsd76AY8F5ZflUKvMXsYnkZ578c0O+7S+Mg1VGjlixAyEz+1O PD9gQFHjAFVnAPD5Ng6Lx4zdNk8R X-Received: by 2002:a17:902:2862:: with SMTP id e89-v6mr5208299plb.348.1520795392094; Sun, 11 Mar 2018 12:09:52 -0700 (PDT) Received: from ziggy.stardust ([93.176.145.166]) by smtp.gmail.com with ESMTPSA id 75sm14287477pfl.169.2018.03.11.12.09.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Mar 2018 12:09:51 -0700 (PDT) Subject: Re: [PATCH v3 01/15] dt-bindings: clock: mediatek: add missing required #reset-cells To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org References: <7365f2286ff2cebcfb590715cb4a15dedd089046.1518895232.git.sean.wang@mediatek.com> From: Matthias Brugger Message-ID: <6e155672-2544-3148-e664-72b830d1cdc2@gmail.com> Date: Sun, 11 Mar 2018 20:07:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <7365f2286ff2cebcfb590715cb4a15dedd089046.1518895232.git.sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2018 08:54 PM, sean.wang@mediatek.com wrote: > From: Sean Wang > > All ethsys, pciesys and ssusbsys internally include reset controller, so > explicitly add back these missing cell definitions to related bindings > and examples. > > Signed-off-by: Sean Wang > Cc: Rob Herring > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Reviewed-by: Rob Herring Reviewed-by: Matthias Brugger > --- > Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt | 1 + > Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt | 2 ++ > Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 ++ > 3 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt > index 6cc7840..8f5335b 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ethsys.txt > @@ -9,6 +9,7 @@ Required Properties: > - "mediatek,mt2701-ethsys", "syscon" > - "mediatek,mt7622-ethsys", "syscon" > - #clock-cells: Must be 1 > +- #reset-cells: Must be 1 > > The ethsys controller uses the common clk binding from > Documentation/devicetree/bindings/clock/clock-bindings.txt > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt > index d5d5f12..7fe5dc6 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pciesys.txt > @@ -8,6 +8,7 @@ Required Properties: > - compatible: Should be: > - "mediatek,mt7622-pciesys", "syscon" > - #clock-cells: Must be 1 > +- #reset-cells: Must be 1 > > The PCIESYS controller uses the common clk binding from > Documentation/devicetree/bindings/clock/clock-bindings.txt > @@ -19,4 +20,5 @@ pciesys: pciesys@1a100800 { > compatible = "mediatek,mt7622-pciesys", "syscon"; > reg = <0 0x1a100800 0 0x1000>; > #clock-cells = <1>; > + #reset-cells = <1>; > }; > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt > index 00760019..b8184da 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,ssusbsys.txt > @@ -8,6 +8,7 @@ Required Properties: > - compatible: Should be: > - "mediatek,mt7622-ssusbsys", "syscon" > - #clock-cells: Must be 1 > +- #reset-cells: Must be 1 > > The SSUSBSYS controller uses the common clk binding from > Documentation/devicetree/bindings/clock/clock-bindings.txt > @@ -19,4 +20,5 @@ ssusbsys: ssusbsys@1a000000 { > compatible = "mediatek,mt7622-ssusbsys", "syscon"; > reg = <0 0x1a000000 0 0x1000>; > #clock-cells = <1>; > + #reset-cells = <1>; > }; >