Received: by 10.213.65.16 with SMTP id m16csp17514imf; Sun, 11 Mar 2018 12:34:54 -0700 (PDT) X-Google-Smtp-Source: AG47ELvtAPAOoPwWh8+h6rlnNn61yZaQNSpOk+8fJqvRAi5a7Ptdw+MMhLF4wMC8BZPUEyOTDTg6 X-Received: by 10.101.70.65 with SMTP id k1mr4649600pgr.61.1520796894537; Sun, 11 Mar 2018 12:34:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520796894; cv=none; d=google.com; s=arc-20160816; b=KIrga7oOLlvNLuABMkWfQqatXpym+FKB5dy2WSjNFZurUWKTcCyTCqbgQsT+0vTV9M ALY/YMEUbiVqeAdkst0AJx/OlFkgenTqGWNplK32IRFdAgiOwS7h5FBGTUng7WpOFap6 kCN3QrYiskZP2fBusWQj81p0W/RCGXhyNoyaZJpIdntAqrkMqXt8qFzfNullUmHBDFIO qgFcyCsdwsr2Dnf9PBKzDbzRHrApPKqS8ajd9YAMUTxYMonoZ+rR0h4zh9vHq+MM+a98 SxjuDg+T+LEesGMSJ7jVmZgaB8c6RKiMTS1QziaE3xQXTlDTb3E787OJsWSd5/0RQv9B CXMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=dG3PqBzDlWwyjWNEvUSX2cIhqf0SqAgIIx7AwThCsDI=; b=vzBpzEYfGW3Xpb0D/C+j3IeAVZC7l1dbLNviAl7421pXdfIg3qovzWkPuXVztmWF2J Rckroezt+ylAKxwCH1+kzAgMC2lM/7pKB1W5uYfzOvU5F7PI5ZCUgHGlz/rNVgEIPouH ++R2PEFGo9G9EVnWVSPr3QGmR6nTLSPCJBZpKXtfj7v2wtF3Za52p9SBWXD6TmLku1+4 qh0Q/vyrUpc+3xL/odl9RyO2VyjjwxW4Bo2a/VSTWgQHwzHIA8x2n5+RtB91pVltYt4U e2vty7sLQd9dYKDO0i2sRKDAj4t59MiXhT+E2yOgjZvP4sLpzNb2EsXl0TfGdwVmYQ7i tt4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c66si4513611pfc.416.2018.03.11.12.34.38; Sun, 11 Mar 2018 12:34:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932187AbeCKTdn convert rfc822-to-8bit (ORCPT + 99 others); Sun, 11 Mar 2018 15:33:43 -0400 Received: from lilium.sigma-star.at ([109.75.188.150]:37612 "EHLO lilium.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932141AbeCKTdm (ORCPT ); Sun, 11 Mar 2018 15:33:42 -0400 Received: from localhost (localhost [127.0.0.1]) by lilium.sigma-star.at (Postfix) with ESMTP id CD32818000079; Sun, 11 Mar 2018 20:33:40 +0100 (CET) From: Richard Weinberger To: Arvind Yadav Cc: dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, dedekind1@gmail.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 0/2] mtd: use put_device() if device_register fail Date: Sun, 11 Mar 2018 20:35:12 +0100 Message-ID: <3975609.gPYExXdWMR@blindfold> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 9. M?rz 2018, 11:50:47 CET schrieb Arvind Yadav: > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Arvind Yadav (2): > [PATCH 1/2] mtd: use put_device() if device_register fail > [PATCH 2/2] mtd: ubi: use put_device() if device_register fail Uhh, this is not obvious. Does device_register() really always return with a reference held in all (error) cases? Thanks, //richard