Received: by 10.213.65.16 with SMTP id m16csp199487imf; Sun, 11 Mar 2018 23:56:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELvKstxEfdybx/Nun13hipZQntWTcmRFm9byo9hLO4g0ZFTgDWQME6Vk5qn9TeXJ+7uV6KBN X-Received: by 10.101.100.144 with SMTP id e16mr5890662pgv.315.1520837784244; Sun, 11 Mar 2018 23:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520837784; cv=none; d=google.com; s=arc-20160816; b=ruyExF6QyDU1+myf3r68hS2CwG5Bd5DSLbJoA2T8jv8FcVacLE5mPk9zNLjbvNwinV DIGcRNU+r1yPdAGdkiIagAHSJVnsm9eJ7bMD/6gScoovYv8FNwEGX3YXMMslxaEdIhm6 sHx0Olz3sSrJ4BTVBf6gOA8HWorZjCoEXvVXSkyD9WXhe4mJR7YCnK11MSpRVNahFZ5Z K38tOHONCgffvaecjqZ1Gn7WlGAVZYd3o7+CQvvwL6K0P9NbWEo1hqIebH0oiPb6lySr i4F0sh5L8+26Bs1KITJIIJ44lGsk9S5BhsmlcsTmszLtMOSEWEkJuCViDXKD3mGzwr4W 72Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=JgPTEWeIOUpjfGVbjC1tuLxaPLRiOzmxNGZQ2vCijHw=; b=bl6w9W6XgNQcPcaJHxWNH8I+mNJldO2IiSHRFvp3AYJGv9gteWcqvbIAb2ldNCblcl H6PQEwGza1fakiRTLfpJR4QK2CP3OZHvPLliz/GVfNaZ+3i3LL9zKkvegWy2JyzyomUh p4YDfgZrDGXXea2D0aa8frEQobsC/vGZZeefalCAkvq9jqJ3XErmNjeP8skaGqU+T73W 1yN8mOfUPba2b2TrFg1SR2GarKbxqJMdvfKLO1OqnpISPUyME4mTTVexUlPgi33SNY4U fS9P5ZberaqvCVS4giMZCwdSonmF+emtY9xqVHk+OBH+BWL+4iByPW4M4C5dkG9xkqyO r6Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=L6I6KZ8g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h130si4601043pgc.780.2018.03.11.23.56.10; Sun, 11 Mar 2018 23:56:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=L6I6KZ8g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbeCLGzE (ORCPT + 99 others); Mon, 12 Mar 2018 02:55:04 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:52852 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932575AbeCLGzC (ORCPT ); Mon, 12 Mar 2018 02:55:02 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2C6r1g6015316; Mon, 12 Mar 2018 06:54:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=JgPTEWeIOUpjfGVbjC1tuLxaPLRiOzmxNGZQ2vCijHw=; b=L6I6KZ8gZ4sEq2y/RbtzjSx0VjcxC/gBK8jdWvypnDfKcHLlcW2cjSYdmIojXAjpS8er m77eh5x3fQY/BOMdEpPb6xofIutpAtkiS/d4/2EUinZbl/ezlhRyXmmW4m1Q8gwdjs+p eaVToj/Er2IJoXBCN5rpqtyLsvCxSYknOK9WdOZszRDNKfk264Rtfwoi28czWcr+6wRT x/6YKEXiDqda7o7vZHSDbut2qr5rsr2mnzdoQyv/zc+n9QiADOpxZq1l12Ad9xk9yHE2 N8wuRswdc0qUDomCuqWoUGPkz5zRkTUN+11hRnusQRDPV8orRD22YLO2Dgp2317b9JjX Ew== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2gnkad098d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Mar 2018 06:54:58 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w2C6svF0005768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Mar 2018 06:54:57 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2C6svgK029588; Mon, 12 Mar 2018 06:54:57 GMT Received: from santoshs-mbp.lan (/73.222.9.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 11 Mar 2018 23:54:57 -0700 Subject: Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static To: Colin King , "David S . Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180311170340.27696-1-colin.king@canonical.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Sun, 11 Mar 2018 23:54:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180311170340.27696-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8829 signatures=668690 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=607 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803120081 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/18 10:03 AM, Colin King wrote: > From: Colin Ian King > > Functions rds_info_from_znotifier and rds_message_zcopy_from_user are > local to the source and do not need to be in global scope, so make them > static. > > Cleans up sparse warnins: > net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was > not declared. Should it be static? > net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > net/rds/message.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Acked-by: Santosh Shilimkar