Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <VI1PR0402MB391795EEE76FBDCFDBD541BB89D30@VI1PR0402MB3917.eurprd04.prod.outlook.com>
References: <1520301032-10109-1-git-send-email-leechu729@gmail.com>
 <VI1PR0402MB39170322F313A03DC0018A8089D30@VI1PR0402MB3917.eurprd04.prod.outlook.com>
 <CAFaeLdQDHSdeoG9fPVrBheohBGMkG-KirFtF-ra48AXfMWhVNw@mail.gmail.com> <VI1PR0402MB391795EEE76FBDCFDBD541BB89D30@VI1PR0402MB3917.eurprd04.prod.outlook.com>
From:   =?UTF-8?B?5p2O5pu45biG?= <leechu729@gmail.com>
Date:   Mon, 12 Mar 2018 14:57:14 +0800
Message-ID: <CAFaeLdSBJ_SD9gtGbQsCchxQ03PBi3=6D4bjCpYrnm-xoRdvCg@mail.gmail.com>
Subject: Re: [PATCH v7] staging: typec: handle vendor defined part and modify
 drp toggling flow
To:     Jun Li <jun.li@nxp.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "greg@kroah.com" <greg@kroah.com>,
        "shufan_lee@richtek.com" <shufan_lee@richtek.com>,
        "cy_huang@richtek.com" <cy_huang@richtek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jun,

2018-03-12 13:58 GMT+08:00 Jun Li <jun.li@nxp.com>:
> Hi
>> -----Original Message-----
>> From: =E6=9D=8E=E6=9B=B8=E5=B8=86 [mailto:leechu729@gmail.com]
>> Sent: 2018=E5=B9=B43=E6=9C=8812=E6=97=A5 13:22
>> To: Jun Li <jun.li@nxp.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>;
>> heikki.krogerus@linux.intel.com; linux@roeck-us.net; greg@kroah.com;
>> shufan_lee@richtek.com; cy_huang@richtek.com;
>> linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
>> Subject: Re: [PATCH v7] staging: typec: handle vendor defined part and m=
odify
>> drp toggling flow
>>
>> Hi Jun,
>>
>>   Thank you.
>>
>> 2018-03-12 12:33 GMT+08:00 Jun Li <jun.li@nxp.com>:
>> > Hi,
>> >
>> >> +static irqreturn_t _tcpci_irq(int irq, void *dev_id) {
>> >> +     struct tcpci *tcpci =3D dev_id;
>> >> +
>> >> +     return tcpci_irq(tcpci);
>> >> +}
>> >>
>> > ...
>> >
>> >> +     err =3D devm_request_threaded_irq(&client->dev, client->irq, NU=
LL,
>> >> +                                     _tcpci_irq,
>> >>                                       IRQF_ONESHOT |
>> IRQF_TRIGGER_LOW,
>> >> -                                     dev_name(tcpci->dev), tcpci);
>> >> +                                     dev_name(&client->dev), chip);
>> >
>> > - dev_name(&client->dev), chip);
>> > + dev_name(&client->dev), chip->tcpci);
>> >
>> > Did you ever test this patch?
>> I've tested this patch with tcpci_rt1711h.c that will be sent out for re=
viewing in
>> the next patch after tcpci's modification is passed.
>> Because interrupt handler is registered in tcpci_rt1711h.c, here is the =
place I
>> didn't notice.
>
> Understood.
>
>> The interrupt handler for tcpci.c should be modified as following:
>>  static irqreturn_t _tcpci_irq(int irq, void *dev_id)  {
>> -       struct tcpci *tcpci =3D dev_id;
>> +       struct tcpci_chip *chip =3D dev_id;
>>
>> -       return tcpci_irq(tcpci);
>> +       return tcpci_irq(chip->tcpci);
>>  }
>>
>
> Either way is OK to fix it.
> You may send out your v8 and notify Greg to drop your v7 version.
>
> Jun Li

May I add you in the Reported-by list?

--=20
Best Regards,
=E6=9B=B8=E5=B8=86