Received: by 10.213.65.16 with SMTP id m16csp203671imf; Mon, 12 Mar 2018 00:08:14 -0700 (PDT) X-Google-Smtp-Source: AG47ELt0Yu2yAo3TsY4TmUHMqCm3j3/7dMmhAVWjFfwWCSVH4L+YW8K7SgJwCTS8txhRmoA1CDf7 X-Received: by 10.98.245.18 with SMTP id n18mr6857036pfh.25.1520838494775; Mon, 12 Mar 2018 00:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520838494; cv=none; d=google.com; s=arc-20160816; b=Xes4ftK54AKs5y14JYog5Ylq1ixJTZNrfidZzM/VLc6wOmFqdyRDLKf/0SP7gpDghV G8ceH3poDyENOkC7YSYwa1fBfrwogX60sJL7Xou+rfY6xectyuFVbWxnLn0bHWyXWsYC zFRn7wgzSG580BIbJC383whaBjTojSZ0aM0SU0AnDwGEwk1pOVimMZa9Cj9EOQuExqA6 0pV3kSCCKIC106vQgryNm5I5ir52dHZMbwLKpMOhUawuCqg6/vDvrljmsAWX+osI4H+U NUrThrF7dOrmv3V3ifZwFxhDNsUa2buQicRKPCsposPu4A79MtnqwhE/glbyio8qWxBC +4aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=2FNm3bUzfq1YFprYhNvw1Pm//3cTquFDtVyI3eSr+Tg=; b=WcecbGCfUFgbiy/tIzGVpys0e5QFOUm5fGYCYj+r+qzGJth8DoOPeNOMoPmyww+kec sTVi5K1lyhS3PZJseLZlQ3ipdhNOXWhxRdJ3IHSG3eh8Y+/1KY3guDxkQs4scWWzUndW t1FfwiCMEEHmnlDjoRggJiqFWTB/RZAQ7ALWJrJFLYCAe/E7t1heMa55ZFEZUutg314q LATS1oN7CjQitB+qUCg1Gyu+a6jm229ck/l4G7dfni/adSnDH6E2A3vW9nZ1+YPjo33b mgxFOyEpCSjcG3aK+7sVNjSg67fSovv75d4OJNYabTt/g48FHTkD7yvtUUTgcCe9rJVz 9wNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=TbUnyjfw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9si4584883pgt.533.2018.03.12.00.07.59; Mon, 12 Mar 2018 00:08:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=TbUnyjfw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932670AbeCLHGX (ORCPT + 99 others); Mon, 12 Mar 2018 03:06:23 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:56118 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbeCLHGV (ORCPT ); Mon, 12 Mar 2018 03:06:21 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2C72KQL154269; Mon, 12 Mar 2018 07:06:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=2FNm3bUzfq1YFprYhNvw1Pm//3cTquFDtVyI3eSr+Tg=; b=TbUnyjfwEA7NdOX8md9yzOj7oDIei++l4J9/9E9QsRcibIsvSc7JG3IxgISnXdRvxJMK oSVXS5q8phP32AMrT9yoiHROCi/0UJSC54c9CHCcqYXYu8zN9iDVy1HICBXiydf1GoIQ BLJxOdkmZP12tL+Yoraw5PvuBClYxNoMPTxuSsX6/G6n+tNDP39WlnWSRttNMgtRCJ+p SlW/Hseyljh0NpUZK0w9qm/lOFNNsNRbyotAOHNHzQVMuEYGfAyLFl5vl6p+Hi/v8yp9 qXexVmFEdVwN8LSWhgUjLD1ijo5GZUxcC6npBKU2EN8Sc0mbSIzURhyKdIrGn4B4HrCW Bg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2gnkf6g8d3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Mar 2018 07:06:04 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2C763GW010810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Mar 2018 07:06:03 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w2C7624n019461; Mon, 12 Mar 2018 07:06:02 GMT Received: from santoshs-mbp.lan (/73.222.9.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 12 Mar 2018 00:06:02 -0700 Subject: Re: [PATCH 1/2] net: rds: drop VLA in rds_for_each_conn_info() To: Salvatore Mesoraca , linux-kernel@vger.kernel.org Cc: kernel-hardening@lists.openwall.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Kees Cook References: <1520802470-17374-1-git-send-email-s.mesoraca16@gmail.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: <9f197147-c050-dd70-23ea-ec880d205201@oracle.com> Date: Mon, 12 Mar 2018 00:06:01 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520802470-17374-1-git-send-email-s.mesoraca16@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8829 signatures=668690 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=734 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803120084 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: > Avoid VLA[1] by using an already allocated buffer passed > by the caller. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca > --- Thanks for both VLA fixes Salvatore. FWIW, Acked-by: Santosh Shilimkar