Received: by 10.213.65.16 with SMTP id m16csp221457imf; Mon, 12 Mar 2018 01:03:08 -0700 (PDT) X-Google-Smtp-Source: AG47ELtzBJaTL/sCcDWciEpOVEKrzsekhxeKg74ZWYp6qWhtLYDJYiL/U4AredgUXFsq2pLHYPKF X-Received: by 2002:a17:902:6f17:: with SMTP id w23-v6mr7470734plk.336.1520841788426; Mon, 12 Mar 2018 01:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520841788; cv=none; d=google.com; s=arc-20160816; b=uyDB/4GvilTmIEwV4u6/pmxCUMCShRVqEjeg2e7stT0ydeK2FhETTMH+Eeo2drdcKW v+BLnjIkbi5Adawje3Z8Z9NoqRkzC8EHk28na6zK+Z4vllwKxNQZHvTdWY115YA3ek30 BQ4wZgPjQ4YrEyhBBTcBKI/tZLHCT67yekHxOz9QWKRjCBsfRIlHPn8PSlhMAP1R3SdM HuQThfIcbS3QaEdKSmmkZ8DDR6jRjZ7rNaSYVeRr/f0uBNp6CzmEWUd2yruh8QHn/vFO PuKFil+IWaviVEyWfJZdF11xkABpykuszdrY0AwrK9ISID5uRE6zZjDgV2c2aK6pZZ9A eQ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=8xMWBs+894OF9Zkrx2WttBcozHLk54L2+NMPnEfDTlU=; b=rLKXGtzQxetQMUVNL9o6fodEjTfDKGInjQXWkZQQ0Ubgx6zPyG0GQ3AO+1KaYue9Rx 6oRhkhVE/wwCCh6O9AQS7si3URIrmRf03/35j8eeuxb5NsEXiCRQUl063k9BIDjf+WKh 7C0vdxwxEZms3ySOXgzMDK0BLCX5fCr14ZSnPvrN5dHV9jVvwZajbzUWVplggCNJ/6x3 WwCLTk7dkALVNa8vP6PvcUn5RQyZNEkZ8z25xjHVfBeL12dYKNNusAt17NmgVF0lPqYn 71vjxXwwqVBBY20iNc3p/GpCbUasUiSOSufp+0//cbS5FfjFnItM1SkNentPuYjzQHgk kqeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=GAdy2Zeg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b61-v6si5487547plc.385.2018.03.12.01.02.53; Mon, 12 Mar 2018 01:03:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=GAdy2Zeg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932458AbeCLIBt (ORCPT + 99 others); Mon, 12 Mar 2018 04:01:49 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42092 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbeCLIBr (ORCPT ); Mon, 12 Mar 2018 04:01:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8xMWBs+894OF9Zkrx2WttBcozHLk54L2+NMPnEfDTlU=; b=GAdy2ZegM9307uFe1q0LRDRrM divBeYQa33AAs0pJKsikbMXFwdh0pqd9e640tJ/EVnm/Hr11VkvLZykZdW4GUoh2y9cLAPO+xLuJt GZtRCxw/n8yPvkJH3diMIWKxhJCXDhFGUv7UyYA2815uXAbhIHQcATkgVnbAPBlK8FLH7syeXMOqX Cxt4M8oLvGyBiIQUOvSs3y+U8or0rloP2ZyQktWqhB/Un5zi+xuCW8SfK0AhX+Mlq22jhXvyydQ38 Z7ELHZLowpkoNBNkD1cZJidfFH4wkfXFRVGMelwpEF1SaGeeaN1dtbMELNQdEo3EHzjXKWVc2syzb oDTpNK9QA==; Received: from hch by bombadil.infradead.org with local (Exim 4.89 #1 (Red Hat Linux)) id 1evIOx-0004ob-8y; Mon, 12 Mar 2018 08:01:47 +0000 Date: Mon, 12 Mar 2018 01:01:47 -0700 From: Christoph Hellwig To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Keith Busch , Sinan Kaya , Lukas Wunner , Frederick Lawler Subject: Re: [PATCH v2 06/13] PCI/portdrv: Remove pcie_port_bus_type link order dependency Message-ID: <20180312080147.GC10358@infradead.org> References: <152062141493.77693.9630397416694091342.stgit@bhelgaas-glaptop.roam.corp.google.com> <152062202196.77693.13201322126291517429.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152062202196.77693.13201322126291517429.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if ((driver->port_type != PCIE_ANY_PORT) && > + (driver->port_type != pci_pcie_type(pciedev->port))) No need for the inner braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig