Received: by 10.213.65.16 with SMTP id m16csp240350imf; Mon, 12 Mar 2018 01:59:01 -0700 (PDT) X-Google-Smtp-Source: AG47ELszJenb/MCWj7wTSRCV21yRqmPcO4D56nVtxHbGDtzAHTDoZFA+7s42OxejkmeyUACpjl8U X-Received: by 2002:a17:902:5481:: with SMTP id e1-v6mr7396633pli.300.1520845141058; Mon, 12 Mar 2018 01:59:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520845141; cv=none; d=google.com; s=arc-20160816; b=awX++co4do52NW63HFvvQCF6EDHKQRkBDMJ9bI9LJwOvnGiyTZU7lSphcY6mtjU3A/ q0stsCj0HACL18H1XHPkWWSFWb71gUcRd9SkZdpZJrN8XSetMjCThCJTiGOHFeeSVrMM 4goTC0IxVuq/3/H6uxBXgCtMbkvvJKbAK2PqtD3GXNEIXfxz2IOvSKXLlGFrKmwXBvkW XPEMNJiqu0abDK7G6/iI6MrdaMd835GJH45579LV5Qx+ujl+rie2vG5iJhjed9OIPWmr 6lsSt70Pqv+bRVEgKQqaSofc/W7Tk5JDBIL+M1kSyL+nRrIBycT7UXah7QzLwK3qS/9H ql8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=zNYNGfq/cLdTzCS8CgMGMXgChPVwH4Hh6v7a81gW4uo=; b=uOEC+JKYFxzkKqgbRasOZRjvpw4piqrKlo4BZPAqW+99VzPxPM98xT5J3QOpR41Tay QKPGD9HX/OfqHNp7X6HJPQ3vsY5aHBZzUiEj+R4aUEn3ClT5L5611b18YDzHDJBaPIy0 IgOEJWMy1m4Jyg1rawUxIxwMSNq+c307nJOl6s7R2YefgSMJ5YYB1ySWT2fX+Beh8K18 N4PjGOewlaUZcI3iXOIXsrjoQ3+Htl1gaDMi7gcHr6Wv5KejK6RCvGpiT002bwxpFTPc /F6qHdv/m0RtS9Z0g7d27o3HKuEiQhK/PbYiR0Z0SOrwBu7XGPDGVMltuqwicJXfYBlf 6lnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nz/M5ipf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc11-v6si5561925plb.43.2018.03.12.01.58.46; Mon, 12 Mar 2018 01:59:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nz/M5ipf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbeCLI5j (ORCPT + 99 others); Mon, 12 Mar 2018 04:57:39 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:45408 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbeCLI5h (ORCPT ); Mon, 12 Mar 2018 04:57:37 -0400 Received: by mail-wr0-f194.google.com with SMTP id h2so7508503wre.12 for ; Mon, 12 Mar 2018 01:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zNYNGfq/cLdTzCS8CgMGMXgChPVwH4Hh6v7a81gW4uo=; b=Nz/M5ipf1053F2mXfjFEW7yyEw04juZjrhbaHXVP5+QVDSQVwcskymLMSTfNeNLaLY mFzxm4fwEnqAw8gYs/eLvPIbmps9/ePJHHT7dK8kOwhIJijLpSvZqkJ/9SqelG2Sk7MP s0104Hl45BbVO183evfGn5vTGt7/6mQAgQAGk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zNYNGfq/cLdTzCS8CgMGMXgChPVwH4Hh6v7a81gW4uo=; b=RFaiOsvxOFAmW8iVuaABxooJBEjPg8afQlMKrdtPwPIc126vnHs/NKOoaeSF3xv/XA xXlg4h5nXAXbvehzkCo+cSw2sSFm51moMQXtmvIPaOhsh2Iz7T3TNN+LW6VmBJruQisJ 7A/ovW0fmz0nucIFi7Pe8M+1pDYNhxZHJIdVypI3QDrUY/Fz0qSbrIL6+cQVLvFMXEEP +QQ1iLBNCOZFJLC8rgYZB1Uur2ipt30VmaPW9dOLuykVFHkt64dkjfOOze3UMLfNKFB6 PQynZe1TzaJ8PIZ6WFPYvtjbZYSQegSLz2rOU+a51/56/YasyvpKPKu3UnqxNXxmoPo1 bHKA== X-Gm-Message-State: AElRT7HaY8LyrutfGv3I5GQ7F38Rx16koXYOEIgRFxXSB5ycNSyxShbJ w5aJKHbwKKlEzK6tWJrAM6EbWSYWCRw= X-Received: by 10.223.173.207 with SMTP id w73mr3134749wrc.234.1520845056354; Mon, 12 Mar 2018 01:57:36 -0700 (PDT) Received: from dell ([2.27.167.102]) by smtp.gmail.com with ESMTPSA id b9sm8193176wrh.68.2018.03.12.01.57.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Mar 2018 01:57:35 -0700 (PDT) Date: Mon, 12 Mar 2018 08:57:33 +0000 From: Lee Jones To: SF Markus Elfring Cc: Tony Lindgren , linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH v2 14/17 4/4] mfd: tps65910: Move an assignment in tps65910_sleepinit() Message-ID: <20180312085733.qkau2n3cos4743yj@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Mar 2018, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 9 Mar 2018 09:19:42 +0100 > > Move the assignment for the local variable "dev" so that its setting > will be performed after a configuration check by this function. > > Signed-off-by: Markus Elfring > --- > > v2: > Lee Jones requested a resend for this patch. The change was rebased > on source files from Linux next-20180308. Thanks. What happened here: [PATCH v2 14/17 4/4] How have you managed to insert 4 patches into the x/17 thread? It shouldn't matter for reviewing purposes. It just looks really odd. > drivers/mfd/tps65910.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c > index 7e7d3d1642c6..bf16cbe6fd88 100644 > --- a/drivers/mfd/tps65910.c > +++ b/drivers/mfd/tps65910.c > @@ -315,11 +315,11 @@ static int tps65910_sleepinit(struct tps65910 *tps65910, > struct device *dev; > int ret; > > - dev = tps65910->dev; > - > if (!pmic_pdata->en_dev_slp) > return 0; > > + dev = tps65910->dev; > + > /* enabling SLEEP device state */ > ret = tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL, > DEVCTRL_DEV_SLP_MASK); -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog