Received: by 10.213.65.16 with SMTP id m16csp245493imf;
        Mon, 12 Mar 2018 02:12:18 -0700 (PDT)
X-Google-Smtp-Source: AG47ELvt2o4KZ1V7ZCYT4u3b/pdoBkqFH/ZgLE6GywtlaaUAqOEZzka0Eo7d0QHGl2j/TIilGhDF
X-Received: by 2002:a17:902:74c5:: with SMTP id f5-v6mr5618006plt.91.1520845938923;
        Mon, 12 Mar 2018 02:12:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1520845938; cv=none;
        d=google.com; s=arc-20160816;
        b=Dmv1lUzejQPTm/4ECxanQ2jaaIvnH5FwaSmrmfrkUlBUta6H5Rmjt1cqN+cWbsPxk0
         K9jPcVxyHQEkD4YNAwr4RFmZrwzgwN/PGUcL6TUWv0jZ6luH+hbczaoTkZu4EMTqyX47
         RLywE6Cbnc2O6Hs2LZohp2afE/Nn9oc+XiL5OZYRyYQVCipaBoXLvr+h1aXbTF722uij
         ZvjYx/q9yQZ6fD9VpW2VMkif/hkm+nE3UZR6JOOSuYxxKh3R+jZrx93+wEevnYWnnyjx
         t1mlarrGeuDKCRyhY6IY9u+hRNBhY2Op9fu0yFVgWEmRXHagHOHuLui4T7uD4buTiQcl
         GzYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:arc-authentication-results;
        bh=m45vqITc/IGf3H8NV6H9zQtO6oggxonlkgp3noW17A0=;
        b=V2nn5ysDO3E0j9011EhyeA4BbDqwx4t3ZV86SnCoU+geoqBVMLbYxeWemo/D9UGHbK
         00jn4lvDqwSA85JECHFNJJ5E43NaUVuJZFvZqcxvDETfA92CEQQTjAI0hDNDpiGDDjLT
         +8uXrpDEi8jZvC11NqUNr/ClTUyF7LLsTtXLVmrtpZ0Xb0S8nVNZfJo5t+/ZX97AvBPy
         AajCSHz5+cRg1y/2FKp+TuidMfpHxlqe1nB3mjcPVi8c9LFJXH6E5VQDS1Ely7WzaHTx
         LW8m0lD7Ncgmj7pRd1nv7+cY0Cx+c9IbW/S0dACLKheo4wBqQXHNlGrPY96tq/fyJjLL
         umqQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id y14si4341046pgv.655.2018.03.12.02.12.04;
        Mon, 12 Mar 2018 02:12:18 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752034AbeCLJKo (ORCPT <rfc822;0330sisy@gmail.com> + 99 others);
        Mon, 12 Mar 2018 05:10:44 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:8004 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751180AbeCLJKm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Mar 2018 05:10:42 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com
        id <B5aa6440f0001>; Mon, 12 Mar 2018 02:10:39 -0700
Received: from HQMAIL103.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 12 Mar 2018 02:10:41 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 12 Mar 2018 02:10:41 -0700
Received: from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL103.nvidia.com
 (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 12 Mar
 2018 09:10:40 +0000
Received: from tbergstrom-lnx.Nvidia.com (10.21.24.170) by
 UKMAIL101.nvidia.com (10.26.138.13) with Microsoft SMTP Server (TLS) id
 15.0.1347.2; Mon, 12 Mar 2018 09:10:37 +0000
Received: by tbergstrom-lnx.Nvidia.com (Postfix, from userid 1002)
        id 2FFA3F80612; Mon, 12 Mar 2018 11:10:36 +0200 (EET)
Date:   Mon, 12 Mar 2018 11:10:36 +0200
From:   Peter De Schrijver <pdeschrijver@nvidia.com>
To:     Jon Hunter <jonathanh@nvidia.com>
CC:     <linux-tegra@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <devicetree@vger.kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 07/11] dt-bindings: tegra: Update DFLL binding for PWM
 regulator
Message-ID: <20180312091036.GR6190@tbergstrom-lnx.Nvidia.com>
References: <1517934852-23255-1-git-send-email-pdeschrijver@nvidia.com>
 <1517934852-23255-8-git-send-email-pdeschrijver@nvidia.com>
 <c747bc00-8c04-c297-e945-784e45655421@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c747bc00-8c04-c297-e945-784e45655421@nvidia.com>
X-NVConfidentiality: public
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [10.21.24.170]
X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com
 (10.26.138.13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 08, 2018 at 11:21:40PM +0000, Jon Hunter wrote:
> 
> On 06/02/18 16:34, Peter De Schrijver wrote:
> > Add new properties to configure the DFLL PWM regulator support. Also
> > add an example and make the I2C clock only required when I2C support is
> > used.
> > 
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > ---
> >  .../bindings/clock/nvidia,tegra124-dfll.txt        | 76 +++++++++++++++++++++-
> >  1 file changed, 74 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt b/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> > index dff236f..a4903f7 100644
> > --- a/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> > +++ b/Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> > @@ -23,7 +23,8 @@ Required properties:
> >  - clock-names: Must include the following entries:
> >    - soc: Clock source for the DFLL control logic.
> >    - ref: The closed loop reference clock
> > -  - i2c: Clock source for the integrated I2C master.
> > +  - i2c: Clock source for the integrated I2C master (only required when
> > +	 using I2C mode).
> >  - resets: Must contain an entry for each entry in reset-names.
> >    See ../reset/reset.txt for details.
> >  - reset-names: Must include the following entries:
> > @@ -45,10 +46,28 @@ Required properties for the control loop parameters:
> >  Optional properties for the control loop parameters:
> >  - nvidia,cg-scale: Boolean value, see the field DFLL_PARAMS_CG_SCALE in the TRM.
> >  
> > +Optional properties for mode selection:
> > +- nvidia,pwm-to-pmic: Use PWM to control regulator rather then I2C.
> > +
> 
> Do we need this property? Seems that we should be able to detect if it
> is I2C or PWM based upon the other properties.
> 

I guess we could look for nvidia,pwm-period and switch to PWM mode if this is
found, but I think it's more clear to have explicit property.

Peter.