Received: by 10.213.65.16 with SMTP id m16csp269489imf;
        Mon, 12 Mar 2018 03:15:39 -0700 (PDT)
X-Google-Smtp-Source: AG47ELtTnZI3iGWDs+Cu/0AWYOHKq8PdWfCcCF95Ab/oUrgJUwu8EzapL4VnF+aZhrr37odqZqjc
X-Received: by 10.101.70.203 with SMTP id n11mr48109pgr.166.1520849739748;
        Mon, 12 Mar 2018 03:15:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1520849739; cv=none;
        d=google.com; s=arc-20160816;
        b=XbKpb/gMR5pRq4T+vN+Qc6E7pbhLdfZbVL4BqKv1s8KDZtGztUp23Px6LU6a41aMqV
         KhXBwgwyFohoUGD70AMOKzccRUJDCi+gren8y1YK+PpT007COui8QXUrPr4c+XGtkMB5
         AFr4WCU33xalrBQ1Gt50enWf4Ebkpenmtv7QGM8m7d2iqT0I93GCa6uEILj6/VyZPBoA
         TlDafDYnSHwF75G0QrhrovpvVdjgXFnEqnYFVAiMg3VaoE9+qBeBjfSYda/H49U+RQO6
         VbjpPCyc1xuqJcZklkLo8/xXU1Vs8nOkors2u/kivnIjK5bgRzNxVYglmKBJaaZviVLl
         qUTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=aveaqLhy0Hpn6p//FnhsEBG49ohn2QEB1of3u3WaubY=;
        b=HWtym722L0jar8qEIfLr77RCFyN2WnEcPXBD330rS1aygdgaZcYXlnKQTXheH1aXtS
         FOp4ls3DwSv0GLY7lDrPVlgrw9i+5qTyFwzdJ6TJgnWOJQGS2YXUcxc+r6xm6wtQU9sk
         ssldLFwdlTvjUwDqdJRLszEiA2NTtcheVc9HQticDYzpMX30YtLJixt7WzGClhL4b74V
         61rQZB6BMDAp6OJrGJVngdm9EqbEEF2G7gWFlw+45kBlzi2mOcXf/NKup3lWZ/L80G6g
         Z3v7pyYKDGbGKxHhWbH3XXNXsNXJDOOTnouM1dMQa/yML9O42fBFBBDuLKX9aRB3WYy2
         Gl0Q==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id w20-v6si5826457plq.486.2018.03.12.03.15.24;
        Mon, 12 Mar 2018 03:15:39 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752579AbeCLKOb (ORCPT <rfc822;0330sisy@gmail.com> + 99 others);
        Mon, 12 Mar 2018 06:14:31 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:11940 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752003AbeCLKO3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Mar 2018 06:14:29 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com
        id <B5aa6530c0001>; Mon, 12 Mar 2018 03:14:36 -0700
Received: from HQMAIL107.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Mon, 12 Mar 2018 03:14:26 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Mon, 12 Mar 2018 03:14:26 -0700
Received: from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 12 Mar
 2018 10:14:27 +0000
Received: from [10.26.11.150] (10.26.11.150) by UKMAIL101.nvidia.com
 (10.26.138.13) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 12 Mar
 2018 10:14:18 +0000
Subject: Re: [PATCH v3 09/11] cpufreq: tegra124-cpufreq: extend to support
 Tegra210
To:     Peter De Schrijver <pdeschrijver@nvidia.com>
CC:     <linux-tegra@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <devicetree@vger.kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
References: <1517934852-23255-1-git-send-email-pdeschrijver@nvidia.com>
 <1517934852-23255-10-git-send-email-pdeschrijver@nvidia.com>
 <b7a25613-44b4-5e63-e8c7-91ce2b7cb56e@nvidia.com>
 <20180309081438.GO6190@tbergstrom-lnx.Nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <50b05dda-4577-0c86-a8e5-eb7095ee1f59@nvidia.com>
Date:   Mon, 12 Mar 2018 10:14:17 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180309081438.GO6190@tbergstrom-lnx.Nvidia.com>
X-Originating-IP: [10.26.11.150]
X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com
 (10.26.138.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 09/03/18 08:14, Peter De Schrijver wrote:
> On Thu, Mar 08, 2018 at 11:25:04PM +0000, Jon Hunter wrote:
>>
>> On 06/02/18 16:34, Peter De Schrijver wrote:
>>> Tegra210 has a very similar CPU clocking scheme than Tegra124. So add
>>> support in this driver. Also allow for the case where the CPU voltage is
>>> controlled directly by the DFLL rather than by a separate regulator object.
>>>
>>> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>>> ---
>>>  drivers/cpufreq/tegra124-cpufreq.c | 15 ++++++++-------
>>>  1 file changed, 8 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
>>> index 4353025..f8e01a8 100644
>>> --- a/drivers/cpufreq/tegra124-cpufreq.c
>>> +++ b/drivers/cpufreq/tegra124-cpufreq.c
>>> @@ -64,7 +64,8 @@ static void tegra124_cpu_switch_to_pllx(struct tegra124_cpufreq_priv *priv)
>>>  {
>>>  	clk_set_parent(priv->cpu_clk, priv->pllp_clk);
>>>  	clk_disable_unprepare(priv->dfll_clk);
>>> -	regulator_sync_voltage(priv->vdd_cpu_reg);
>>> +	if (priv->vdd_cpu_reg)
>>> +		regulator_sync_voltage(priv->vdd_cpu_reg);
>>>  	clk_set_parent(priv->cpu_clk, priv->pllx_clk);
>>>  }
>>>  
>>> @@ -89,10 +90,10 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev)
>>>  		return -ENODEV;
>>>  
>>>  	priv->vdd_cpu_reg = regulator_get(cpu_dev, "vdd-cpu");
>>> -	if (IS_ERR(priv->vdd_cpu_reg)) {
>>> -		ret = PTR_ERR(priv->vdd_cpu_reg);
>>> -		goto out_put_np;
>>> -	}
>>> +	if (IS_ERR(priv->vdd_cpu_reg) != -EPROBE_DEFER)
>>> +		priv->vdd_cpu_reg = NULL;
>>> +	else
>>> +		return -EPROBE_DEFER;
>>
>> I am still not sure that we should rely on the fact that the regulator
>> is not present in DT to imply that we do not need it. I think that we
>> should be checking if we are using I2C mode here.
>>
> 
> The cpufreq driver doesn't know this however. Also the current approach of
> setting the same voltage when switching to pll_x is incorrect. The CVB
> tables when using pll_x include more margin than when using the DFLL.

Ah yes I see now. However, we are going to need to update the DT doc,
because 'vdd-cpu-supply' is listed as required.

Cheers
Jon

-- 
nvpublic