Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180312110722.GB10444@kroah.com>
References: <1520848002-3801-1-git-send-email-leechu729@gmail.com> <20180312110722.GB10444@kroah.com>
From:   =?UTF-8?B?5p2O5pu45biG?= <leechu729@gmail.com>
Date:   Mon, 12 Mar 2018 19:26:07 +0800
Message-ID: <CAFaeLdSSqDok6_jaa4wwxuo+71qkv7ha5Rs81B7LvEAsRZDfYg@mail.gmail.com>
Subject: Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")
To:     Greg KH <greg@kroah.com>
Cc:     heikki.krogerus@linux.intel.com,
        Guenter Roeck <linux@roeck-us.net>,
        =?UTF-8?B?c2h1ZmFuX2xlZSjmnY7mm7jluIYp?= <shufan_lee@richtek.com>,
        =?UTF-8?B?Y3lfaHVhbmco6buD5ZWf5Y6fKQ==?= <cy_huang@richtek.com>,
        Jun Li <jun.li@nxp.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
>> From: ShuFan Lee <shufan_lee@richtek.com>
>
> Your subject is odd, that line should be below, in the signed-off-by:
> area, not as the subject of the patch :(
>
> Can you fix this up and resend?
Yes.
If I understand correctly, the title should be like
staging: typec: modify parameter of tcpci_irq
and the "Fixes" tag should be put in the signed-off-by area.

Should it be in the beginning of the area:
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")
Signed-off-by: xxx

or the end of the area?
Signed-off-by: xxx
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")

>
> thanks,
>
> greg k-h


--=20
Best Regards,
=E6=9B=B8=E5=B8=86