Received: by 10.213.65.16 with SMTP id m16csp309576imf; Mon, 12 Mar 2018 04:39:19 -0700 (PDT) X-Google-Smtp-Source: AG47ELsiLR8z8v8uy/N/UfKGGZS9K1r/LGN9rICn14k3pvVMQguYOQLdu8SRHrDv4wEkbENCVgA5 X-Received: by 10.98.17.147 with SMTP id 19mr7642068pfr.160.1520854759309; Mon, 12 Mar 2018 04:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520854759; cv=none; d=google.com; s=arc-20160816; b=UeUsFn/CWwGVE0rlzCXfaeelD9q9sif8+0HW84XSsu7jDNu7DYqrU8yhLMQBE9AWTU Iyo/goHs6G+HZgOmsBxgQAmfy2XUbSlC3Jeglfr2JwNgf1aQg2X9hvlpJdBQRvAA9LBi 2j1h+uJFQ1Uu1Fn9JezVm39BZjlTOt1FV3BSmQn36XbiPKNa7MhmTacMaVol0fE6sQKR P062Kemah8sStANufgKvF2fx4bylmLSAj0stPKrudEUvBVh8BwX7BNS6DQ2KuXDx4UM8 l1I7dnn8mZduk6zCugFSOG/9+b6M30O91T6tv9RnHuJJF+USQzwOutr3klSTeD5ZWFTe 9UmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=8+nXT9Ng+vl5F+TFhJk7+mnr+pM/3cc9EvNQaguChqg=; b=X+Jy9mYA1+87XpaXYXb5knMMzaAquOKH48eRKciagrcUmpaTJMhtnai9wOdmN2mLKp mmfJQeVZYkPFYwnuHafBuepJ6NKm5hEIb59YnokAo/1RTDVNnN/Z/9X7ETmj0/k9nLYf 4FJ6lMK8Fu+4MKkAMfbaGUi3X4DYZ2NSi+7g+3b4Mzxw90PYXjfD+xy6t9C+FxrLnqkH a9ZdqEQfJ9SeQzzJXBGYBhATE6O8/kFJmw2pKX7QQpNTYfuyhk2fhLoptWhEOsP9t7T8 ByVDGPn+NRUPv9T8AP5qXZyjSeUwaQIhR3gNdOPzQHSyL4Xfb6ej+d7/+qQO4DTIyDYB uqSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CS5hk9IK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j2si5553095pff.214.2018.03.12.04.39.04; Mon, 12 Mar 2018 04:39:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CS5hk9IK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbeCLLiC (ORCPT + 99 others); Mon, 12 Mar 2018 07:38:02 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:51604 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbeCLLiA (ORCPT ); Mon, 12 Mar 2018 07:38:00 -0400 Received: by mail-it0-f65.google.com with SMTP id u66so10740001ith.1 for ; Mon, 12 Mar 2018 04:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=8+nXT9Ng+vl5F+TFhJk7+mnr+pM/3cc9EvNQaguChqg=; b=CS5hk9IKwC6v8MEbiWvK34qL5M2YfQ6rq6rlvYPLInAy3KNq9Oqo6rR0AWNR4RRhi9 bV/nCXN4EoXOW53XV8Cg8osYCDEPfg8iB9xFl9vpQht32YI3K3yCfFgNWIbbdf0dQ/O4 ye6+/QHjHy7MqjHp5/iHlAZzgd3VhB5zFdbUAwebM7pEISNfLK3LvoLR3img3dxy9UCI 976Pm/IyPBrMldgAfhOWa7+SlSsrIKYnp9W7eB4jmRhuoy0jsIWNJhQ7k24W1LwP9osA lJ1LeG52Uzm4Y/NxFtTSTxdtcx0W1GDuPAbrcMGFWLrZOn6zzovOGEP7oSgeU3EDxbSC W6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=8+nXT9Ng+vl5F+TFhJk7+mnr+pM/3cc9EvNQaguChqg=; b=iNFiHhcWCZxu+2tnQm2eDCBAPgftncAg6GJmuhwlBy5/2ncagpad4uRgy9Kw5uj10E DrO6aHP1jKIQllUwyd5EVqfm8gWoK0BFVO7r6vTsT8d3qop3CcxIz910V/vzrCCO9Bbe EDd9zXyb0AIXiiv4vMmWJJjfSpRlXB5lEnhneBN01qXKt1vuzxhHAW5WELM6ruLm8EJF bEq9i+5wtf5ZZaBukxUZrKmXKkbKk/K6uzJoEuW9aWPas9uoaFYf8b8V0XtbpcYOJdZI gGodQTodiw8yw0uUKo3yWQlwnrkdjgw7HMukDFWj3CNH1zut9J1qJ81PShyS+4rWCp9U xVdg== X-Gm-Message-State: AElRT7GT/qgQyuq8SnCjMTEe700/Wo3iETGI8Nh4oMb17BdMjFTlVkZD ju3SmapkYeCSDvcgTgk1eOc= X-Received: by 10.36.70.210 with SMTP id j201mr7756654itb.8.1520854679505; Mon, 12 Mar 2018 04:37:59 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id i81sm3461021itb.21.2018.03.12.04.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Mar 2018 04:37:58 -0700 (PDT) From: Arvind Yadav To: sudeep.dutt@intel.com, ashutosh.dixit@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, fbarrat@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 2/2] misc: ocxl: use put_device() instead of device_unregister() Date: Mon, 12 Mar 2018 17:06:53 +0530 Message-Id: <8c4d28703e408b71284af68d07c117e7b8c8a75a.1520849284.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/misc/ocxl/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c index 0051d9e..21f4254 100644 --- a/drivers/misc/ocxl/pci.c +++ b/drivers/misc/ocxl/pci.c @@ -519,7 +519,7 @@ static struct ocxl_fn *init_function(struct pci_dev *dev) rc = device_register(&fn->dev); if (rc) { deconfigure_function(fn); - device_unregister(&fn->dev); + put_device(&fn->dev); return ERR_PTR(rc); } return fn; -- 1.9.1