Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1520859807.10722.591.camel@linux.intel.com>
Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Harish Jenny K N <harish_kandiga@mentor.com>,
        Avri Altman <Avri.Altman@wdc.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>
Cc:     "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Vladimir_Zapolskiy@mentor.com" <Vladimir_Zapolskiy@mentor.com>
Date:   Mon, 12 Mar 2018 15:03:27 +0200
In-Reply-To: <329d521d-1776-43ee-2f0e-e9690c29a693@mentor.com>
References: <1520829090-3567-1-git-send-email-harish_kandiga@mentor.com>
         <1520849262.10722.582.camel@linux.intel.com>
         <DM5PR04MB10854C79897A80023EF37F76FCD30@DM5PR04MB1085.namprd04.prod.outlook.com>
         <540fef96-aa2f-e6c3-467d-bc1d021dd55b@mentor.com>
         <DM5PR04MB10859F389CA2D1F2370C02CFFCD30@DM5PR04MB1085.namprd04.prod.outlook.com>
         <329d521d-1776-43ee-2f0e-e9690c29a693@mentor.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-03-12 at 18:00 +0530, Harish Jenny K N wrote:


> > > > > > +	for_each_set_bit(bit, (const unsigned long *)&caps,
> > > > > > BITS_PER_LONG)
> > > > > > +	for_each_set_bit(bit, (const unsigned long
> > > > > > *)&caps2,
> > > > > > BITS_PER_LONG)
> > > > > 
> > > > > Explicit casting is not needed anymore in both cases.
> > > > 
> > > > Also maybe use sizeof(mmc_host_capabilities) instead of
> > > > BITS_PER_LONG?
> > > 
> > > You mean sizeof(caps) and not sizeof(mmc_host_capabilities) .
> > > Right ?
> > 
> > meant ARRAY_SIZE(mmc_host_capabilities)

> ARRAY_SIZE(mmc_host_capabilities) will be 32 and this will be my old
> change for which I got a comment from Andy Shevchenko asking me to
> replace u32 with unsigned long.
> 
> This is the old comment:
> 
> > > +    int size = sizeof(u32) * BITS_PER_BYTE;
> > 
> > This is redundant. Use BITS_PER_LONG (why's that, see below) in the

There is nothing about ARRAY_SIZE().
ARRAY_SIZE() will work quite good as well.

> for_each_set_bit().
> 
> > > +    for_each_set_bit(bit, (const unsigned long *)&caps, size)
> > > +    for_each_set_bit(bit, (const unsigned long *)&caps2, size)
> > 
> > These are UB cases.
> > Fix is simple, replace u32 by unsigned long in (1) above.
> 
> Note: Without typecasting &caps to(const unsigned long *) will give
> compilation error in this case.

What kind of?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy