Received: by 10.213.65.68 with SMTP id h4csp73659imn; Mon, 12 Mar 2018 07:09:22 -0700 (PDT) X-Google-Smtp-Source: AG47ELtT9mARRlTj7lbMtJJNlnbAGFGBaFobSucHvNgfk6mE6fiG+OhXQnXVRCsg4ZBLQhrndaF+ X-Received: by 10.98.7.68 with SMTP id b65mr8108923pfd.39.1520863762430; Mon, 12 Mar 2018 07:09:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520863762; cv=none; d=google.com; s=arc-20160816; b=mm8kU0gMX5HuN8nzkngbeglqf5Im+zQAXmrjAD9kbwjOuA1l94sqOJ1DdMXvK3Ndvt 6p1z9awOraibI442OllAmDHwIeIcx/ZnU8H5YJbDTeJdIGwH9pzL+EtwFJGW1e01w7cI wDd/bvEQOCdJ574phzKeAym5GUZtMlHO/EFunT6yutZmITRGBpDNM6ogn7zpsXiPWdvb wR2z1aFsiqLUAM7oQXyrveBgM9ddu0hOvb7uoHnKidE2vRXXcicv/o1zfjLnE1t2V8FP kHwKixGG9b0AC3u7wnBYRD26a1WaLL6SHVodvsU+zweDQhv/WKxmg8vC9l/bcUlzQuuv 6pkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=NRaa5YUId8IFePzMYjC0dYMEBg/F+2vcCbEr1j/gTOw=; b=iKtq+ousIsT6PyC1Cqfp18Uq8xb7EF2pCzuTp870fOBieldCO5BnThYkhekHIfVj04 mTvvp/w7J/iI+4rXkRh3gZ0F0+pQddklmNV5IT8GkK0R1HFwaPtZhVEXDiIzpiN3Ps7M +gPDotMRfuW5l80zdBONYw0QIHZWrer1EteHzNWA+i4Vkilvc/mxhyrD7mesS5AeeULw orQ9lu2jyu2AnUJ+9jw0Fr/ynOTkKoXFn00a5N3Cw31cXbyq7GizSLkikGZC7HEg2NCL fBdAGB5qD9HwaivgrXNhUa+8KNnV5+eKW9/IhgNB4T+JynDL2J6TnFLPycMHJtiB3lDH 9f4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e12-v6si599202plj.126.2018.03.12.07.09.07; Mon, 12 Mar 2018 07:09:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932400AbeCLOIO (ORCPT + 99 others); Mon, 12 Mar 2018 10:08:14 -0400 Received: from mga03.intel.com ([134.134.136.65]:6517 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932203AbeCLOIN (ORCPT ); Mon, 12 Mar 2018 10:08:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 07:08:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,461,1515484800"; d="scan'208";a="23927061" Received: from linux.intel.com ([10.54.29.200]) by orsmga007.jf.intel.com with ESMTP; 12 Mar 2018 07:08:12 -0700 Received: from [10.254.111.82] (kliang2-mobl1.ccr.corp.intel.com [10.254.111.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 1FB6C5803E2; Mon, 12 Mar 2018 07:08:11 -0700 (PDT) Subject: Re: [tip:perf/core] perf/x86/intel: Disable userspace RDPMC usage for large PEBS To: Vince Weaver , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, eranian@google.com, acme@redhat.com, hpa@zytor.com, alexander.shishkin@linux.intel.com, mingo@kernel.org, jolsa@redhat.com, linux-tip-commits@vger.kernel.org References: <1518474035-21006-6-git-send-email-kan.liang@linux.intel.com> <20180309174218.GB4064@hirez.programming.kicks-ass.net> From: "Liang, Kan" Message-ID: Date: Mon, 12 Mar 2018 10:08:09 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/9/2018 2:10 PM, Vince Weaver wrote: > On Fri, 9 Mar 2018, Peter Zijlstra wrote: > >> On Fri, Mar 09, 2018 at 09:31:11AM -0500, Vince Weaver wrote: >>> On Fri, 9 Mar 2018, tip-bot for Kan Liang wrote: >>> >>>> Commit-ID: 1af22eba248efe2de25658041a80a3d40fb3e92e >>>> Gitweb: https://git.kernel.org/tip/1af22eba248efe2de25658041a80a3d40fb3e92e >>>> Author: Kan Liang >>>> AuthorDate: Mon, 12 Feb 2018 14:20:35 -0800 >>>> Committer: Ingo Molnar >>>> CommitDate: Fri, 9 Mar 2018 08:22:23 +0100 >>>> >>>> perf/x86/intel: Disable userspace RDPMC usage for large PEBS >>>> >>> >>> >>> So this whole commit log is about disabling RDPMC usage for "large PEBS" >>> but the actual change disables RDPMC if "PERF_X86_EVENT_FREERUNNING" >>> >>> Either the commit log is really misleading, or else a poor name was chosen >>> for this feature. >> >> Its the same thing, and yes that might want renaming I suppose. > > I apologize for noticing these things so late in the game, but I haven't > had time to keep up with a full lkml feed recently so I only see these > things once I'm CC'd on them. > > So to summarize this: rdpmc is only disabled on a per-event basis, and > only if that event is doing multi-pebs sampling? > If the event can do multi-pebs sampling, the rdpmc will be disabled. Other events which cannot do multi-pebs will not be impacted. To enable multi-pebs sampling for event, it requires a fixed period. It doesn't support callgraph. For older platform (before SKL), it doesn't support time stamp. Thanks, Kan > If that's true, then I don't think I have an issue with this. > > We finally got rdpmc support in a released PAPI, and it is a massive > improvement when self-monitoring (even moreso if KPTI is enabled) so I was > just trying to make sure this wouldn't suddenly disable rdpmc out from > under us. > > Vince >