Received: by 10.213.65.68 with SMTP id h4csp93104imn; Mon, 12 Mar 2018 07:44:49 -0700 (PDT) X-Google-Smtp-Source: AG47ELuMb6qdUUkVi5+9aC3ou4d4nt1WI80oHEXYGweeNbPOFLzqUjTkm5+nCcqXQXVAmuVxkqoR X-Received: by 10.98.72.204 with SMTP id q73mr8332592pfi.48.1520865889196; Mon, 12 Mar 2018 07:44:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520865889; cv=none; d=google.com; s=arc-20160816; b=XvrEuygjEkSy/lMNQyXzUhyTP/6Vkm5osD3w0FQQIqIw6XFVmuBW2Y1p1hJC2cZBp0 XDIG16NrI6HhCoavG1mA0SjFcig0AjG2FFdC9J1gMuBIy+elE755ezmC1Y96aGbS3dVA Z3hX1fpf2TDA6a7wclps+b5756gMfLWKBhde3ut2qmhGwzY1vmD76aXhqlUUV4ujDSLC UM2m83GBR3x9wHvKQmfecjBpiRj+UZCj7dffdmuRs3maXG753vmGijZ/oe2juHTbDWPc f0V477R/cRLPBFH1TuZiK1Yuouv28ctcD/ON5XdqUAoCYXilV7eY1jhjzXjMm3NpssTv E2yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=KiGdk5VO3ahZOP8pApu9Sbp7O+t4k/w24tPDjhj8N+M=; b=m0LGQoSJ71e9Fc4UlLToT9996dVXQLWLVvgdLlVO6bcipqoCx6Ivt1WnC2FvwIZTeC z4uxcZJbS/0IH/n2YLv2YMhRdCVvElvn90d98OCx8pnL6Z0MopRdGjapV1xTp001SNSe t2heuEpb2CUJLE9w3tn4SwZGrtlXpbhFyaAx8LJZrqpm6NpHigx0oqH54JMjNrE0afDA cxYSxZWHaynaCmo9V2/aF/zfPMd4RRPjnvpZ5h8t5DDcoDYWUxdyC5xPqzGXj/NnCpGc 78X4gFKXdh41JPCV9pO7l/gv3tCAtpZ3FdoJ2uxf5DkyVGlYJb7vVvV5yG4r72cV+Ln0 QqFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9-v6si6195745pli.445.2018.03.12.07.44.34; Mon, 12 Mar 2018 07:44:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbeCLOn1 (ORCPT + 99 others); Mon, 12 Mar 2018 10:43:27 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:59864 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbeCLOnZ (ORCPT ); Mon, 12 Mar 2018 10:43:25 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C32B61017B464; Mon, 12 Mar 2018 07:43:24 -0700 (PDT) Date: Mon, 12 Mar 2018 10:43:23 -0400 (EDT) Message-Id: <20180312.104323.14368638452528082.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, linyunsheng@huawei.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: hns: use put_device() if device_register fail From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 12 Mar 2018 07:43:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav I do not see anything giving cls_dev an initial non-zero reference count before this device_register() call. And I have no idea why you use a "!" when saying 'error' you this commit log message.