Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <6b1842619a6f1ba13194328e28b853c18c466c03.1520835596.git.rgb@redhat.com>
References: <cover.1520835596.git.rgb@redhat.com> <6b1842619a6f1ba13194328e28b853c18c466c03.1520835596.git.rgb@redhat.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Mon, 12 Mar 2018 11:01:13 -0400
Message-ID: <CAHC9VhTaHA0v-8=QkEDzTyXFvk1oFHnFj6EbHxGetU+pmr+iPQ@mail.gmail.com>
Subject: Re: [PATCH ghak21 V2 1/4] audit: make ANOM_LINK obey audit_enabled
 and audit_dummy_context
To:     Richard Guy Briggs <rgb@redhat.com>
Cc:     Linux-Audit Mailing List <linux-audit@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Eric Paris <eparis@redhat.com>,
        Steve Grubb <sgrubb@redhat.com>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 12, 2018 at 2:31 AM, Richard Guy Briggs <rgb@redhat.com> wrote:
> Audit link denied events emit disjointed records when audit is disabled.
> No records should be emitted when audit is disabled.
>
> See: https://github.com/linux-audit/audit-kernel/issues/21
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  kernel/audit.c | 3 +++
>  1 file changed, 3 insertions(+)

As stated previously, this has already been merged.  Ignoring.

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 1a3e75d..7026d69 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -2308,6 +2308,9 @@ void audit_log_link_denied(const char *operation, const struct path *link)
>         struct audit_buffer *ab;
>         struct audit_names *name;
>
> +       if (!audit_enabled || audit_dummy_context())
> +               return;
> +
>         name = kzalloc(sizeof(*name), GFP_NOFS);
>         if (!name)
>                 return;
> --
> 1.8.3.1

-- 
paul moore
www.paul-moore.com