Received: by 10.213.65.68 with SMTP id h4csp134967imn; Mon, 12 Mar 2018 09:01:27 -0700 (PDT) X-Google-Smtp-Source: AG47ELtAPAOPrPBSFpaw8YyJGPp3C+re3F7T6M0glTUpHuDfMFKWpEzjrmVTWCnBr4Zh8+/uFVw7 X-Received: by 2002:a17:902:8214:: with SMTP id x20-v6mr8794467pln.182.1520870487324; Mon, 12 Mar 2018 09:01:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520870487; cv=none; d=google.com; s=arc-20160816; b=a6lgeudoIigk6LogirvC8EwD2Sly+iKoULps2nfXDq0lcV+dYcZTGowYH9FbDQ7f45 Ig5k5upSlglVJgfBb4TLC3nLj/q+Dgn/LP+5MLaX07srld3lQ6fKs9QIDZDaRba4x1/w 1zW5eTIPzrmbAz64UB9Lu6WCoPyBeMHkkhnacKySR/GYOJax/Ug3Efx1gmZ8Lr/9Od+9 VLJy0s5aASoHIsF5h9NeF4KF5LGU8dYRW89PIvZd/mJKfnc+K40Pel9z36ksT6id86bh B8X2+iFiJSfMZz0T0EFo/61W1EYWHFC97vD8WMrS0u9hftqaVlJppf0yWfwmMeoUJXNL jkCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=pgeXwfhAK0kPQgXzdl/aAv+JOkNJjqdRYB5Ai7pGkQs=; b=YfHqC6UOnFmOzu6A8YOJWpi/MABldJbxGOqZh1INcdPV7O+GjJhRUpCPKotavVaXZW Fb9WvC6gPE+ahh9B1kQtME2dAXiXJsbmKLhTgsBJNzDzVW+nqxul/gjpiErNzYjeEaKZ MxuqU0UaBPLoy2zdvWUu7Yo8flk6WAa77CoEJpj+tG/iUfU3eZU/KB9AU1F1SXUFUXTB JYQMyWKvIR2oKEGNfr9/Cqfn/ldHT8onipBrQbb7MBcMHpywgWF6ubRpQDqzuRLqkQEy 8QwuJL5t4nJ0g+Pz2ZaKNdsyt6FGPFO0whddmaULKCfW7sjAUYdoxLbMw+vxNrAzya36 lG2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=f/GhpHDj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d90-v6si6177630pld.40.2018.03.12.09.01.11; Mon, 12 Mar 2018 09:01:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=f/GhpHDj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709AbeCLP6B (ORCPT + 99 others); Mon, 12 Mar 2018 11:58:01 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35099 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932621AbeCLP57 (ORCPT ); Mon, 12 Mar 2018 11:57:59 -0400 Received: by mail-lf0-f67.google.com with SMTP id t132-v6so7602350lfe.2 for ; Mon, 12 Mar 2018 08:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pgeXwfhAK0kPQgXzdl/aAv+JOkNJjqdRYB5Ai7pGkQs=; b=f/GhpHDjOWR+b6bU2+aXG8sPsybxcsON7Mcc3G/FKpvOMljVmZcaoyZV3RDeDPcePJ ZTFgiQPKIx9dQWesQdkPwZE5tCgGGzdPq9xM2hWYoKeNukN1SxU12VpW/NjNNMn7P57l Fv1Vda+Hq5cbtgmt1ROgHSj6Jd0Uelz6DZrMKLjZR47RU3P4niQi/eXkvfNw1UzSjW5p vEqhRH08iKONJdRE0nvyVT3Sq6HE3IYDk0+M5GzYe+J8sIOnkECw7+EnDvT1X2Gu5INU G+9DUPGHzjIRiu0JrVRywFyI4ueZGETff1Iy5NyJVcJsvUWbofleVuZu2+45oU+wkZix yN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pgeXwfhAK0kPQgXzdl/aAv+JOkNJjqdRYB5Ai7pGkQs=; b=EpKRiDqj87SDcEkQVDxWhuRrrohSakIfHdorb1gRR/EafnA5FneqjBFf3/dB4+chXf BkGTZEONEbAjZ1LeRs69BxsHOP88R79siSl2KEfBMUuRK6NH2UgQGE9OWLchRb4T59L4 kSIOrv3GphjxOZpIx/ZsWrdN97ISAuTAViZMxs6PS4Qj74XZ2Jm73iES+hzFTC3vrNZd 1fH9qGkqNygQg6UjEK6UnFG79BLd/pSnZzPjSjnhOZaufqG7c/FPLtuzl1hQYnywystV +2c5SaZSVK68jz8nthzJVFxiC7txBpULupd+cSbJWIEJU9Z29QHyPCVSFaSegOFd3HUW 8fNw== X-Gm-Message-State: AElRT7HRm+RpE60qjDNlXpWjGbTdame3DSkm4JDzDufUXjSMzehWhmGb ric/RuQCf/URlkhtV2RTTKs= X-Received: by 2002:a19:1508:: with SMTP id l8-v6mr5761351lfi.139.1520870277550; Mon, 12 Mar 2018 08:57:57 -0700 (PDT) Received: from localhost.localdomain (c83-253-254-90.bredband.comhem.se. [83.253.254.90]) by smtp.gmail.com with ESMTPSA id h11-v6sm1833448lfd.88.2018.03.12.08.57.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Mar 2018 08:57:56 -0700 (PDT) From: codekipper@gmail.com To: maxime.ripard@free-electrons.com, wens@csie.org, linux-sunxi@googlegroups.com Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, be17068@iperbole.bo.it, Marcus Cooper Subject: [PATCH v2 1/6] ASoC: sun4i-i2s: Add slot width override Date: Mon, 12 Mar 2018 16:57:48 +0100 Message-Id: <20180312155753.9478-2-codekipper@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180312155753.9478-1-codekipper@gmail.com> References: <20180312155753.9478-1-codekipper@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcus Cooper Some codecs require a different amount of a bit clocks per frame than what is calculated by using the sample width. Use a slot width override property to provide this mechanism. Signed-off-by: Marcus Cooper --- Documentation/devicetree/bindings/sound/sun4i-i2s.txt | 5 +++++ sound/soc/sunxi/sun4i-i2s.c | 15 ++++++++++++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt index b9d50d6cdef3..48addef65b8f 100644 --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt @@ -28,6 +28,11 @@ Required properties for the following compatibles: - "allwinner,sun8i-h3-i2s" - resets: phandle to the reset line for this codec +Optional properties: +- allwinner,slot-width-override:if this property is present then the dai is + configured to extend the slot width to the + value specified. Min 8, Max 32. + Example: i2s0: i2s@1c22400 { diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index a4aa931ebfae..873054a6c3be 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -193,6 +193,8 @@ struct sun4i_i2s { struct regmap_field *field_rxchansel; const struct sun4i_i2s_quirks *variant; + + unsigned int slot_width; }; struct sun4i_i2s_clk_div { @@ -344,7 +346,7 @@ static int sun4i_i2s_set_clk_rate(struct snd_soc_dai *dai, if (i2s->variant->has_fmt_set_lrck_period) regmap_update_bits(i2s->regmap, SUN4I_I2S_FMT0_REG, SUN8I_I2S_FMT0_LRCK_PERIOD_MASK, - SUN8I_I2S_FMT0_LRCK_PERIOD(32)); + SUN8I_I2S_FMT0_LRCK_PERIOD(word_size)); return 0; } @@ -418,7 +420,8 @@ static int sun4i_i2s_hw_params(struct snd_pcm_substream *substream, sr + i2s->variant->fmt_offset); return sun4i_i2s_set_clk_rate(dai, params_rate(params), - params_width(params)); + i2s->slot_width ? + i2s->slot_width : params_width(params)); } static int sun4i_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1029,7 +1032,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev) struct sun4i_i2s *i2s; struct resource *res; void __iomem *regs; - int irq, ret; + int irq, ret, val; i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); if (!i2s) @@ -1096,6 +1099,12 @@ static int sun4i_i2s_probe(struct platform_device *pdev) i2s->capture_dma_data.addr = res->start + SUN4I_I2S_FIFO_RX_REG; i2s->capture_dma_data.maxburst = 8; + if (!of_property_read_u32(pdev->dev.of_node, + "allwinner,slot-width-override", &val)) { + if (val >= 8 && val <= 32) + i2s->slot_width = val; + } + pm_runtime_enable(&pdev->dev); if (!pm_runtime_enabled(&pdev->dev)) { ret = sun4i_i2s_runtime_resume(&pdev->dev); -- 2.16.2