Received: by 10.213.65.68 with SMTP id h4csp175056imn; Mon, 12 Mar 2018 10:15:03 -0700 (PDT) X-Google-Smtp-Source: AG47ELsl6/hZAQDQtXbJ/1D7KU1jl/mPYiUIeYPvV3U870OisGbTZg+3dWfFfqZsOyZKNUUKdY3u X-Received: by 10.98.218.7 with SMTP id c7mr8646502pfh.162.1520874903748; Mon, 12 Mar 2018 10:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520874903; cv=none; d=google.com; s=arc-20160816; b=by0/feLqhXjsX/mA6gdb9y2IoYMWDiEJw/T5Wm4pC5NzxfPxEigL1POyCZ9dwelGZY Rk8rGVIOLc4+iY45d5iJG4yY/ZKRwsdasF9h0kaSlAtM7OOZaOT5JbP0r8wrtl5q4FO+ 8FqYbuHP4TynFpF1OjDPHR2c87NHp9tIlNlutLsEb4NUwgOjObVHs+HgxJ7pMnsyZ0Ls c3sXqqnqH9a6yFlQ0vQAosT4tNIxzUFeE67mStCxrXUYPbsMFomfMEAASRInprtb8U0p 9qOEMMh0XYNeHph0PDWMKopr0pbJFJ47d0sMLEHYj6m7sQPhd09pNK1iQv9wEMD+fpBV RSkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=HBBd+C/eYvaheMnKWOPH9HfooIh6eOgFydNS4/7c27c=; b=pUSynuQ/IYt/10GLelsaXdi1IvHfANasRwsUUY9zNwPB++ZrW7MtJYux/XJC4ZN1LH 9ar3aXP9QAQWforxPq5jIp3bUDkVDjjbIb3VCtRJi7/pApyGncL1hcWxfoW2VMGk4P3J Z/cZ812ZHu+EM/0ajteJi0H10wjMWTQZL6s6q/JPFIF9a5KY3Vh7rHD1e/o158ucHIYQ LBUugvuy5HEroSgWa5J0uziAVWRkaugf9tQmwrQoM9XrsbsBe1h4GO4AK3prsZANKsSx YUPsg+WnsbaL/Q65+YbDmzXZxfLNVdRJLY8E1ULICwj4Bu9PxyXKuGTgbTBaEaQxCBWd kKWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si5187628pgp.319.2018.03.12.10.14.47; Mon, 12 Mar 2018 10:15:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932699AbeCLRNl (ORCPT + 99 others); Mon, 12 Mar 2018 13:13:41 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38043 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932326AbeCLRNi (ORCPT ); Mon, 12 Mar 2018 13:13:38 -0400 Received: by mail-wr0-f193.google.com with SMTP id l8so2135558wrg.5 for ; Mon, 12 Mar 2018 10:13:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HBBd+C/eYvaheMnKWOPH9HfooIh6eOgFydNS4/7c27c=; b=GRl/Q4fCkDx5meujkYWKZyU5xhFyctUY8OUOoJubwkvF5Bpk9K5zPgnyf45lIBhIIC DWasuvc7+wzEfTmouaVHNfofzq6MvLVqZ6cY9O1U+skqVuOHzizzxMxkCA5yjKqnf6dk eH38ebdpKo3x0FI2RLhEhrna9iOSU6KWANdDBzuF6lgHFkuW/SyXnXUaaLoxxZxyD71k 0WK3CZXFt2YorKpVnwVETNHX8codqcSxIt/ZYdFIi/52QZh2QsOMnFeaK/7fNGtPo3mg q/CPTLrkHCqcDHi/tbb5z5VfdSZMRKLKGeVlG8tEDp7f5gmtuA7KEHdjQ62cPfzwPpPR DuaA== X-Gm-Message-State: AElRT7EbEOqmBElHhy/O9GFiMv3c3bv5d53M9PNilzHBBRR9K0j20d0n RCZ0nooq9FYA35RrT1hri3CrcWbf X-Received: by 10.223.171.167 with SMTP id s36mr6643797wrc.52.1520874817311; Mon, 12 Mar 2018 10:13:37 -0700 (PDT) Received: from localhost.localdomain (u-086-c252.eap.uni-tuebingen.de. [134.2.86.252]) by smtp.gmail.com with ESMTPSA id x17sm10954864wrg.32.2018.03.12.10.13.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Mar 2018 10:13:36 -0700 (PDT) From: Christian Brauner To: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, ebiederm@xmission.com, torvalds@linux-foundation.org Cc: Christian Brauner Subject: [PATCH 3/3 v3] selftests: add devpts selftests Date: Mon, 12 Mar 2018 18:13:30 +0100 Message-Id: <20180312171330.32054-4-christian.brauner@ubuntu.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180312171330.32054-1-christian.brauner@ubuntu.com> References: <20180312171330.32054-1-christian.brauner@ubuntu.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds a simple test to check whether /proc//fd/ symlinks are correctly pointing to /dev/pts/ devices when attached to a terminal. Signed-off-by: Christian Brauner --- ChangeLog v2->v3: * extend test for non-standard devpts mounts such as mount -t devpts e devpts /mnt ChangeLog v1->v2: * patch added ChangeLog v0->v1: * patch not present --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/filesystems/.gitignore | 1 + tools/testing/selftests/filesystems/Makefile | 2 +- tools/testing/selftests/filesystems/devpts_pts.c | 281 +++++++++++++++++++++++ 4 files changed, 284 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/filesystems/devpts_pts.c diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 7442dfb73b7f..dbda89c9d9b9 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -7,6 +7,7 @@ TARGETS += cpufreq TARGETS += cpu-hotplug TARGETS += efivarfs TARGETS += exec +TARGETS += filesystems TARGETS += firmware TARGETS += ftrace TARGETS += futex diff --git a/tools/testing/selftests/filesystems/.gitignore b/tools/testing/selftests/filesystems/.gitignore index 31d6e426b6d4..8449cf6716ce 100644 --- a/tools/testing/selftests/filesystems/.gitignore +++ b/tools/testing/selftests/filesystems/.gitignore @@ -1 +1,2 @@ dnotify_test +devpts_pts diff --git a/tools/testing/selftests/filesystems/Makefile b/tools/testing/selftests/filesystems/Makefile index 13a73bf725b5..4e6d09fb166f 100644 --- a/tools/testing/selftests/filesystems/Makefile +++ b/tools/testing/selftests/filesystems/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -TEST_PROGS := dnotify_test +TEST_PROGS := dnotify_test devpts_pts all: $(TEST_PROGS) include ../lib.mk diff --git a/tools/testing/selftests/filesystems/devpts_pts.c b/tools/testing/selftests/filesystems/devpts_pts.c new file mode 100644 index 000000000000..d71d2f1f3b69 --- /dev/null +++ b/tools/testing/selftests/filesystems/devpts_pts.c @@ -0,0 +1,281 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static bool terminal_dup2(int duplicate, int original) +{ + int ret; + + ret = dup2(duplicate, original); + if (ret < 0) + return false; + + return true; +} + +static int terminal_set_stdfds(int fd) +{ + int i; + + if (fd < 0) + return 0; + + for (i = 0; i < 3; i++) + if (!terminal_dup2(fd, (int[]){STDIN_FILENO, STDOUT_FILENO, + STDERR_FILENO}[i])) + return -1; + + return 0; +} + +static int login_pty(int fd) +{ + int ret; + + setsid(); + + ret = ioctl(fd, TIOCSCTTY, NULL); + if (ret < 0) + return -1; + + ret = terminal_set_stdfds(fd); + if (ret < 0) + return -1; + + if (fd > STDERR_FILENO) + close(fd); + + return 0; +} + +static int wait_for_pid(pid_t pid) +{ + int status, ret; + +again: + ret = waitpid(pid, &status, 0); + if (ret == -1) { + if (errno == EINTR) + goto again; + return -1; + } + if (ret != pid) + goto again; + + if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) + return -1; + + return 0; +} + +static int resolve_procfd_symlink(int fd, char *buf, size_t buflen) +{ + int ret; + char procfd[4096]; + + ret = snprintf(procfd, 4096, "/proc/self/fd/%d", fd); + if (ret < 0 || ret >= 4096) + return -1; + + ret = readlink(procfd, buf, buflen); + if (ret < 0 || (size_t)ret >= buflen) + return -1; + + buf[ret] = '\0'; + + return 0; +} + +static int do_tiocgptpeer(char *ptmx, char *expected_procfd_contents) +{ + int ret; + int master = -1, slave = -1, fret = -1; + + master = open(ptmx, O_RDWR | O_NOCTTY | O_CLOEXEC); + if (master < 0) { + fprintf(stderr, "Failed to open \"%s\": %s\n", ptmx, + strerror(errno)); + return -1; + } + + /* + * grantpt() makes assumptions about /dev/pts/ so ignore it. It's also + * not really needed. + */ + ret = unlockpt(master); + if (ret < 0) { + fprintf(stderr, "Failed to unlock terminal\n"); + goto do_cleanup; + } + +#ifdef TIOCGPTPEER + slave = ioctl(master, TIOCGPTPEER, O_RDWR | O_NOCTTY | O_CLOEXEC); +#endif + if (slave < 0) { + if (errno == EINVAL) { + fprintf(stderr, "TIOCGPTPEER is not supported. " + "Skipping test.\n"); + fret = EXIT_SUCCESS; + } + + fprintf(stderr, "Failed to perform TIOCGPTPEER ioctl\n"); + goto do_cleanup; + } + + pid_t pid = fork(); + if (pid < 0) + goto do_cleanup; + + if (pid == 0) { + char buf[4096]; + + ret = login_pty(slave); + if (ret < 0) { + fprintf(stderr, "Failed to setup terminal\n"); + _exit(EXIT_FAILURE); + } + + ret = resolve_procfd_symlink(STDIN_FILENO, buf, sizeof(buf)); + if (ret < 0) { + fprintf(stderr, "Failed to retrieve pathname of pts " + "slave file descriptor\n"); + _exit(EXIT_FAILURE); + } + + if (strncmp(expected_procfd_contents, buf, + strlen(expected_procfd_contents)) != 0) { + fprintf(stderr, "Received invalid contents for " + "\"/proc//fd/%d\" symlink: %s\n", + STDIN_FILENO, buf); + _exit(-1); + } + + fprintf(stderr, "Contents of \"/proc//fd/%d\" " + "symlink are valid: %s\n", STDIN_FILENO, buf); + + _exit(EXIT_SUCCESS); + } + + ret = wait_for_pid(pid); + if (ret < 0) + goto do_cleanup; + + fret = EXIT_SUCCESS; + +do_cleanup: + if (master >= 0) + close(master); + if (slave >= 0) + close(slave); + + return fret; +} + +static int verify_non_standard_devpts_mount(void) +{ + char *mntpoint; + int ret = -1; + char devpts[] = P_tmpdir "/devpts_fs_XXXXXX"; + char ptmx[] = P_tmpdir "/devpts_fs_XXXXXX/ptmx"; + + ret = umount("/dev/pts"); + if (ret < 0) { + fprintf(stderr, "Failed to unmount \"/dev/pts\": %s\n", + strerror(errno)); + return -1; + } + + (void)umount("/dev/ptmx"); + + mntpoint = mkdtemp(devpts); + if (!mntpoint) { + fprintf(stderr, "Failed to create temporary mountpoint: %s\n", + strerror(errno)); + return -1; + } + + ret = mount("devpts", mntpoint, "devpts", MS_NOSUID | MS_NOEXEC, + "newinstance,ptmxmode=0666,mode=0620,gid=5"); + if (ret < 0) { + fprintf(stderr, "Failed to mount devpts fs to \"%s\" in new " + "mount namespace: %s\n", mntpoint, + strerror(errno)); + unlink(mntpoint); + return -1; + } + + ret = snprintf(ptmx, sizeof(ptmx), "%s/ptmx", devpts); + if (ret < 0 || (size_t)ret >= sizeof(ptmx)) { + unlink(mntpoint); + return -1; + } + + ret = do_tiocgptpeer(ptmx, mntpoint); + unlink(mntpoint); + if (ret < 0) + return -1; + + return 0; +} + +static int verify_ptmx_bind_mount(void) +{ + int ret; + + ret = mount("/dev/pts/ptmx", "/dev/ptmx", NULL, MS_BIND, NULL); + if (ret < 0) { + fprintf(stderr, "Failed to bind mount \"/dev/pts/ptmx\" to " + "\"/dev/ptmx\" mount namespace\n"); + return -1; + } + + ret = do_tiocgptpeer("/dev/ptmx", "/dev/pts/"); + if (ret < 0) + return -1; + + return 0; +} + +int main(int argc, char *argv[]) +{ + int ret; + + if (!isatty(STDIN_FILENO)) { + fprintf(stderr, "Standard input file desciptor is not attached " + "to a terminal. Skipping test\n"); + exit(EXIT_FAILURE); + } + + ret = unshare(CLONE_NEWNS); + if (ret < 0) { + fprintf(stderr, "Failed to unshare mount namespace\n"); + exit(EXIT_FAILURE); + } + + ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0); + if (ret < 0) { + fprintf(stderr, "Failed to make \"/\" MS_PRIVATE in new mount " + "namespace\n"); + exit(EXIT_FAILURE); + } + + ret = verify_ptmx_bind_mount(); + if (ret < 0) + exit(EXIT_FAILURE); + + ret = verify_non_standard_devpts_mount(); + if (ret < 0) + exit(EXIT_FAILURE); + + exit(EXIT_SUCCESS); +} -- 2.15.1