Received: by 10.213.65.68 with SMTP id h4csp287250imn; Mon, 12 Mar 2018 13:53:36 -0700 (PDT) X-Google-Smtp-Source: AG47ELvpRskpiWB1p7lF6eRKMKSQh5U8QoXwdwXlfdwcswut6hnhKZYwj8DpXU4qpDAHWdx8XuLH X-Received: by 2002:a17:902:3383:: with SMTP id b3-v6mr9396577plc.224.1520888016889; Mon, 12 Mar 2018 13:53:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520888016; cv=none; d=google.com; s=arc-20160816; b=CReS5vRXADQzthGG7fsdi+5JGZ2SoIb/G61NxlrsyrRNkdkd38TQr2jSYdKGv5TIrF 6EIXD0pFqE+PGchDnZ6BvgEqHTUD6YsUkQE0Zt2H/kpu+CPqtoXKFx1teoVj4hIjjge2 Pymrj0ojwFgTLpHTOTwAUcQzShDAweg8gMPRHZJ+gfsEMfA/wfokP+YdNoB43MwXy3P+ JDuW0+6ToVQEvsetMw9J+3IimgHd5eQ1rHcCrncGHWSmkAB8zwzH2m+CwgoB3J0md/bB OPI71Zqde9eIlLJ4sfYH6nD/etqVJ8LI26T4A8kNan0GVoIewXM+DYwMi/ykYse5A+bz XBZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=HqNrLUsRLL/F7fhmvhPgT6QzoP9h7s7ix6oNYDhBblg=; b=0VXh/NUAwq2TA4PYSbqwYXDaiwrd8IlHuHhNPxquOUsmz5uk0cqjux4ii+kHkqadMQ LNtEh/XWOg5K/p2IBX0ZhCWn6k8/c6JR/XKslSZOc2WZCLWaMKzzZvfqLxs+CE8NUMBc jxdRk7lVT0hVYjsvG6XaHNIa3N2KZ80TVxSTcWJ39wNotQhWtvcznBcZuPLdXJNmGL6O WQVjHA5CYaZdRP5EkwnYNfvSdFxZDcThcmIBv/hpJgAFC1J+icQLF10rtgXq2wqThUQB C1OIm6i3t6Qn3fhIXESnwH1a95Wj6wWAAEGLJ6ueh4O7Ic+ciTq+oRhfoitgo8WHpNLV kHlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3-v6si2977998pls.530.2018.03.12.13.53.21; Mon, 12 Mar 2018 13:53:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932505AbeCLUwI (ORCPT + 99 others); Mon, 12 Mar 2018 16:52:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58766 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932387AbeCLUwF (ORCPT ); Mon, 12 Mar 2018 16:52:05 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 300FE1057; Mon, 12 Mar 2018 20:52:05 +0000 (UTC) Date: Mon, 12 Mar 2018 13:52:04 -0700 From: Andrew Morton To: Waiman Long Cc: "Luis R. Rodriguez" , Kees Cook , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Al Viro , Matthew Wilcox Subject: Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits Message-Id: <20180312135204.d56f7f1e64c96cf20786eb28@linux-foundation.org> In-Reply-To: <1520885744-1546-3-git-send-email-longman@redhat.com> References: <1520885744-1546-1-git-send-email-longman@redhat.com> <1520885744-1546-3-git-send-email-longman@redhat.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > Checking code is added to check for invalid flags in the ctl_table > and return error if an unknown flag is used. Why? What's wrong with the old code, what value does this change add, etc.