Received: by 10.213.65.68 with SMTP id h4csp6109imn; Mon, 12 Mar 2018 15:14:27 -0700 (PDT) X-Google-Smtp-Source: AG47ELt6Iv0tYTzRZkVSWxLumMnwkr6ve/yBCf59B91B+P5LlvTCrzBsQfZnc6Dos/KWl9cV8y4p X-Received: by 2002:a17:902:b101:: with SMTP id q1-v6mr9657900plr.287.1520892867005; Mon, 12 Mar 2018 15:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520892866; cv=none; d=google.com; s=arc-20160816; b=k2xsCTCWeX0kGjGOuOviw6N1P6zO+ZB9JkgSrjGlC1nT8lfDmJQlzUeh2EJSg+Kf+c IvBI04/WqfvkTmYwTkBnl5Eai27It+MeBZCP9LBdjYlNouQ/+BUiEEvUzj2W+7hOFR8z AsdwtMKb1bOta6BHg/yb8YYUumPMMqZObkEz0qbpEz3Bk2gYMaLAJrIFd2iBfOy2tuZ7 xHKRoaOz860Y3slInVHp9oSwW/zZb8g26sCdA6aOOvSfcu6afs417mUg5VfuBiah7H4m wXiQg+B7ypKjyW5DP8CyuMCfCsJNo3X8Px7eXjBvUXiNc8GW0v7RHW0n52q9jJK6wDeO ztcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=W4QuJUGAdwPRHKfVN73lTq0QgbAak+5Kt/nJRrr77ow=; b=QRaL/wj2F/FsX4cAnjjaC+IO82K5dxR3AP89B3LC2LNEZ8AxMZ3vSLRwqF9Y7AH3EZ MPS93dIKCd7ipnV/yuLBOIMOhP0HPZ3xRz3Xp4zAxJ3/ReuNQQMtBgrA3ajZ02d6uiI0 1z/UufWfEVbW4m9h429XhGtd0Fs2yVgtbRUfBXQMyJW0V9E+8ELuV2i4sND9gJuvpVRX aJ5xZXhF8Ph4QAtSyNQlYBfS6RAjkpEt1ObNu7CZuPVJR16LN0zQD1iqwmzO3q2mWLs+ GvsApKVuR/IFUAw4SFkueF2le/+yTTWkEr4pye+h1t1FUH914ppT/S/qALvrnJjzpOvQ 80+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k198si5617003pgc.545.2018.03.12.15.14.09; Mon, 12 Mar 2018 15:14:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932246AbeCLWMt (ORCPT + 99 others); Mon, 12 Mar 2018 18:12:49 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751282AbeCLWMs (ORCPT ); Mon, 12 Mar 2018 18:12:48 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA0C04000B6E; Mon, 12 Mar 2018 22:12:47 +0000 (UTC) Received: from llong.remote.csb (dhcp-17-75.bos.redhat.com [10.18.17.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AC7F1134CCD; Mon, 12 Mar 2018 22:12:47 +0000 (UTC) Subject: Re: [PATCH v4 2/6] proc/sysctl: Check for invalid flags bits To: Andrew Morton Cc: "Luis R. Rodriguez" , Kees Cook , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Al Viro , Matthew Wilcox References: <1520885744-1546-1-git-send-email-longman@redhat.com> <1520885744-1546-3-git-send-email-longman@redhat.com> <20180312135204.d56f7f1e64c96cf20786eb28@linux-foundation.org> From: Waiman Long Organization: Red Hat Message-ID: <42c1606b-304e-8cd5-d532-68a403a99dce@redhat.com> Date: Mon, 12 Mar 2018 18:12:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180312135204.d56f7f1e64c96cf20786eb28@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 12 Mar 2018 22:12:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 12 Mar 2018 22:12:47 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'longman@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/2018 04:52 PM, Andrew Morton wrote: > On Mon, 12 Mar 2018 16:15:40 -0400 Waiman Long wrote: > >> Checking code is added to check for invalid flags in the ctl_table >> and return error if an unknown flag is used. > Why? What's wrong with the old code, what value does this change add, > etc. This is an additional checking code requested by Luis. Cheers, Longman