Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1520899459.23626.87.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in
 genlmsg_multicast_allns()
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Nicolas Dichtel <nicolas.dichtel@6wind.com>,
        "David S. Miller" <davem@davemloft.net>
Cc:     stable@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Tue, 13 Mar 2018 00:04:19 +0000
In-Reply-To: <20180310001808.681346858@linuxfoundation.org>
References: <20180310001807.213987241@linuxfoundation.org>
         <20180310001808.681346858@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 
> 
> [ Upstream commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 ]
[...] 
> -	return nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
> +	err = nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
> +	if (!err)
> +		delivered = true;
> +	else if (err != -ESRCH)
> +		goto error;

This call to nlmsg_multicast() consumes skb rather than a clone, so we
must not free it again here.

Ben.

> +	return delivered ? 0 : -ESRCH;
>   error:
>  	kfree_skb(skb);
>  	return err;
> 
> 
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.