Received: by 10.213.65.68 with SMTP id h4csp54778imn; Mon, 12 Mar 2018 17:27:43 -0700 (PDT) X-Google-Smtp-Source: AG47ELvnO0Sq3XzFvL9daAU4s41Wl5pdueXTRmj9lV7bcAYrM7y5qmHZPBA+YDUhoTCnEH8n9Rd5 X-Received: by 10.101.89.65 with SMTP id g1mr3773770pgu.185.1520900863218; Mon, 12 Mar 2018 17:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520900863; cv=none; d=google.com; s=arc-20160816; b=PW9YT5ht93JJuu48ryKyd76eO0M4O9Fh1rbxn3A+fSYzQem6zpelyDw3rMhPejkfCF 32vRWm5PZZIOWPWFN9t8Qw7Z1/w/ICXJ309HPNOQus8bM9Xpi3294bAfiVdNV3zPCchM h7a7izcp/YAwYp/5MbssOgFmdOmzhkjnRvGRH6nZL+Tg5ys/0gznpHTdeYBZhfJZ55Bx 6PllEN+fj5/5ZTaQcoKdPJ4HDB83kocFsw/WY7RwJ/e+XnaTI81bB6SdYQtGum95d6Va f1cRBQDjLzZWjjvt6DHzu/hwHWcPoBYMZh+o4v6SwlC/TRxruSKCUdkQQ1oyRLI9MLiD 6nPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=ZgKLzytDz2LMAJjI88aCnDGsCbUUJ6kG4FsxWXKG0Qc=; b=t6Ai7mjy+zROeXb3jBVdoO1P0V7Co5rPjHklLDfaM9dDOfUQHdaZtA9hCly4yZab5R jCHlRPORGwIgzmGJUS4v4oAkCaOD3Nlb5Dn+TZee6qBvasN6l7nVGcf/GOusby49Csax Fp3xe1XCJkpYLLdoCuHFoq/4zdA/J9Q1Vi1hzBZzsQTaq9l0TV+nstVX2ik8LlVw6SKY 3wmSHa/mVxVS5Z2haH36twXC6jYHehukmJOHJAieq7gDOR6UUtFZ02KNgQlwEVXjg87U aLZy8Y3DbiX4fon0kBUB43ySdiw9UdSDtvJfCCNe2A7gk+Tv+TfXb6jdLBLD0w66cSb8 iS4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si5756867pgq.379.2018.03.12.17.27.28; Mon, 12 Mar 2018 17:27:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932252AbeCMA0e (ORCPT + 99 others); Mon, 12 Mar 2018 20:26:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55752 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751312AbeCMA0d (ORCPT ); Mon, 12 Mar 2018 20:26:33 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2D0O5MY108433 for ; Mon, 12 Mar 2018 20:26:33 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gp1v63wtd-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 12 Mar 2018 20:26:32 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Mar 2018 00:26:31 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 13 Mar 2018 00:26:28 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2D0QRlB56164454; Tue, 13 Mar 2018 00:26:27 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 917A74C04E; Tue, 13 Mar 2018 00:19:44 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F2684C040; Tue, 13 Mar 2018 00:19:44 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 13 Mar 2018 00:19:44 +0000 (GMT) Received: from [10.61.2.125] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id D237BA013A; Tue, 13 Mar 2018 11:26:25 +1100 (AEDT) Subject: Re: [PATCH 2/2] misc: ocxl: use put_device() instead of device_unregister() To: Arvind Yadav , sudeep.dutt@intel.com, ashutosh.dixit@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, fbarrat@linux.vnet.ibm.com Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <8c4d28703e408b71284af68d07c117e7b8c8a75a.1520849284.git.arvind.yadav.cs@gmail.com> From: Andrew Donnellan Date: Tue, 13 Mar 2018 11:26:25 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8c4d28703e408b71284af68d07c117e7b8c8a75a.1520849284.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18031300-0008-0000-0000-000004DBAF19 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031300-0009-0000-0000-00001E6EDF19 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-12_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803130004 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/18 22:36, Arvind Yadav wrote: > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav This looks right, thanks for picking it up. Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited