Received: by 10.213.65.68 with SMTP id h4csp97862imn; Mon, 12 Mar 2018 19:37:18 -0700 (PDT) X-Google-Smtp-Source: AG47ELuEQjdF2u146uI9TJH9IWWcoZyo1zD8UCNkWR7yw61p0f34/oyBIZ/yVvDu5k4YaBJZQIGX X-Received: by 10.99.115.68 with SMTP id d4mr8447539pgn.145.1520908638070; Mon, 12 Mar 2018 19:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520908638; cv=none; d=google.com; s=arc-20160816; b=IIrw9TuKl239yL+e5rFJperW2sdVnEa1q4wdqKtTxhVYdbUD7N0r89DBuF4udEaL3z JXsdDt82R+0OiR4p4TIPvVctg2YcACYL4IU+RtK7YqVJpQO1ZAGkXNNYMtZXeBPM+P+6 cN2UhsxQ5svkznTPiK9wGfQ1DpzLWOByHTUiyAupERStEXHDjKSzrq8tXLqiYBnXuibK zXO7oZn3B0WHM6XUSm/R7ZHlTdr/Uu3/itXDq3RQWRtvsCywh7narNPbh6Td8xB5nS9h DysWDkYWGfdOQgeR7FkfUWdNE4MliSayxvyho1MsBrlG0X/bhPyE9svL6QI4wiXETwrn LLMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=+Q1HSk86WthizWhv6PLf1WBHHLhbqU8Y2R2qWkc3rL8=; b=EUx7O03fbckl1f0HCcQo3aUSmq+sCOco7WhmNcuc9U3X+ADlZvIOgF0iCxVFPQNhDt iMWzdBpWWpYIAZdX28IYG2iL/35ta7o4X2pgpqWdbxW7jy8QwQGkleIcOB8GC1uAtuLp zbIpg0dx2o3XSMr3m2+SWAOt+q6NFvrxm9YYMHUfcFJ5UqtT9JpylcdTBgtyACN52lRF dtZQRIRn6cooZLsFaDPf0NlfzZaDYETetiXVuJyVcQlndarogbmq7p4GA+xKAd97eAaI gdmpwjjOxLq9jzqfuPjO49UuiEIpT2V2DaK+2VoQlL4ByjNEjefCyY13DCOB/rn9UGVF IP0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=PfOAemIZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12si5971686pge.263.2018.03.12.19.37.03; Mon, 12 Mar 2018 19:37:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=PfOAemIZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbeCMCgM (ORCPT + 99 others); Mon, 12 Mar 2018 22:36:12 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:60280 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932242AbeCMCgK (ORCPT ); Mon, 12 Mar 2018 22:36:10 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2D2VwE7062561; Tue, 13 Mar 2018 02:35:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=+Q1HSk86WthizWhv6PLf1WBHHLhbqU8Y2R2qWkc3rL8=; b=PfOAemIZnYINDOK08CFrak/Au9swNKnePPQvaSzTXMxDcTvR+ZTtI9ZkoNtqTPWpWnP5 iZSEZJ4Lh0vpURH/H6F0mDT+XrR7P8//w9tcJUaXjoBtr1EFuSyg0W2XLCpnbUizGFtD PVt8BoIFLjiCgSxAQddhGe8wi7FLhFqLK/Z7kPREI5fF/qUWSaQLYlNX65PzSKBKqWbH IoxtatP9/E4gdHopNR0My9x6/XIr5DJvbLNzSbIxWusi/emfGxf9gKu/nznCmjWej1hL CamXnslAWftgl7GfWkW3eeSYfAMGCixmU69snNJqy62r0Ggui5J0QaFYgDr1l5+UTKwR 4Q== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2gp5d7g2dm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Mar 2018 02:35:42 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2D2ZfdO018190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Mar 2018 02:35:41 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w2D2ZdCQ018542; Tue, 13 Mar 2018 02:35:39 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 12 Mar 2018 19:35:39 -0700 To: Linus Torvalds Cc: "Tobin C. Harding" , Arthur Marsh , Salvatore Mesoraca , Linux Kernel Mailing List , Kernel Hardening , Linux SCSI List , "James E.J. Bottomley" , "Martin K. Petersen" , Dario Ballabio , Kees Cook , kernelnewbies@kernelnewbies.org Subject: Re: [PATCH] scsi: eata: drop VLA in reorder() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1520802418-17284-1-git-send-email-s.mesoraca16@gmail.com> <20180312030834.GC8631@eros> Date: Mon, 12 Mar 2018 22:35:36 -0400 In-Reply-To: (Linus Torvalds's message of "Mon, 12 Mar 2018 11:45:53 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8830 signatures=668690 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=654 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803130031 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus, > That said, I wonder if the solution to this particular driver is > "delete it". Because the hardware is truly ancient and nobody sane > would use it any more. I'm not aware of anybody actively using these anymore. They are mid-nineties vintage with an M68K processor onboard. I ran a couple of these when they were new but haven't had a working board in probably a decade. No objections to Salvatore's patch but I have a slight affinity for retiring unused code over patching it. So unless there are objections... -- Martin K. Petersen Oracle Linux Engineering