Received: by 10.213.65.68 with SMTP id h4csp188038imn; Tue, 13 Mar 2018 00:26:29 -0700 (PDT) X-Google-Smtp-Source: AG47ELs5rdkKbTOI7580PzIb/8KKAiQa/XG3LOIaoG72bJE3OD0L1/FZJ0OUA2PKn9oFPHJ8SDco X-Received: by 10.99.138.202 with SMTP id y193mr7988116pgd.224.1520925989428; Tue, 13 Mar 2018 00:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520925989; cv=none; d=google.com; s=arc-20160816; b=ntGD6FLH/DzipgU+rzLw3AcvmrIf2r9QI9CPgcjm/V9wgRmUPMXhQE8+oLhSTKHd28 sif3U3DMmy8IMcBikfq6WoNOA4cDt3cziu3xWFEdVG8ukeVczmWnanP7FaKNSaXlspDm 8vvIyxqTaVQZ5o7bUpnC1KXYkRfmmN1dq5RPSShIGnpaqNXE+Z0O+cJ/vLHFWpYEM6yY ox8PDzXqtlKu0/r9R3O5U448XeuKaVwQdSUQN5n7bRBge7oswonHBOi6fLOrLBqhoYQR uXJEXwq8RrsxcHWS4j7f0fE4JmK7+aT8StL7Kxh8oCPkKriGjGZtCrLs0VfVHpFWgH4P nnbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=0aY5HQ906+3OSc4OVh9wVHGWrDxYRxyrYYccAsGCChI=; b=ByoNkTyhi/Gdoq+U0WhiDih6/7UzljP8w5KpTsKdvwUpSvgmUY6+3QGDz8gglHFMe6 AotInvIPPEM4qnc+YXIGmMw9X+faKH2YR9xzdQO5zc7iNKIXSVeZgWxzbgTmLkvcz0x3 f9HyRXPfB/6GnTFtiQd7Vz1dgnQn21+jTF+fHqM7N1JironWJsWmylD5WkCt9U61gcxz oD43BqWHqLNPq/B5Sf9nCq7UodNENxz2SDZ75qntkmhyN4I640kOEXeHnlU/WA0ivC// 2mg06+8cdZK8BQ1SUwQQFodt6vbpC+QkSunsLTLUEPPlSsQEwJRyz4eJwwc6VKG9m+E1 vtYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6si6136118pgu.633.2018.03.13.00.26.15; Tue, 13 Mar 2018 00:26:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbeCMHZP (ORCPT + 99 others); Tue, 13 Mar 2018 03:25:15 -0400 Received: from mout.web.de ([217.72.192.78]:51817 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbeCMHZN (ORCPT ); Tue, 13 Mar 2018 03:25:13 -0400 Received: from [192.168.1.2] ([77.181.227.194]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LkyIj-1eLD5G0TGn-00akMO; Tue, 13 Mar 2018 08:24:39 +0100 Subject: Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee() To: Oliver Neukum , linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, LKML , "Andrew F. Davis" , Andrew Lunn , =?UTF-8?Q?Bj=c3=b8rn_Mork?= , "David S. Miller" , Philippe Reynes , Yuval Shaia References: <019cc24b-d9c0-d782-35e8-f9f8be0534db@users.sourceforge.net> <1520849038.29340.3.camel@suse.com> From: SF Markus Elfring Message-ID: <7d45bd0c-5ab2-a2c0-d746-ef2d859eea08@users.sourceforge.net> Date: Tue, 13 Mar 2018 08:24:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520849038.29340.3.camel@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3kW1rPNkD1k5jOHSpGmBF4+oDnsSyNYZ2AldccBWObpe70zw8Pt NsmM9VjYL/QLRkWqSWUpDVhG4QER787VzrL9yj98AFd3N2UvAq70aBbygFn5VXuzMwYK7uR RymSJGPykBodMTY/Ob8MN+QlNZ4Hs8ILoveSx3NcJqbSUG5TLzoh2XshO+o0A3IM/icEAzZ we7jakIljxq3pPM5nQ8XA== X-UI-Out-Filterresults: notjunk:1;V01:K0:/QX5XO2vYD8=:NB1ZTN9Aajn82vjZabOZx4 G1TqlgeZ6wPpc3BIJTJb87Mk5JUxoiqogUESczASFK8ncACtSpOn7CabQRQILgT1JUy8gf5jv 35a+4Sy5Gdq98QXZUOlyJIAqJsR1jqLO/taCVVebRPH+lGpnTT0T9qqGUUVwosyFCP2jZ/pTR zjx6ERiwD26EQKqtZxB7BCqU/WI0lTYXLOs+jNSUm5tJMABnHWmftTPuYZMyKVjvf5Fg+4aZB pa1VSWZHCtbKKDW+5PAtw8Q7G2ug5GuIP2PPa1FbSeApBFz5jljwpNrSZ48VUuY31/DxKCCCz AgLB655f+l3BF9aKkDtuXXLjzTYd98MYioZh7lIdCUd5y9Myst6aclKNpydYhPdaJ/fXfA3eD tNilvY/ZldJ8NyrCJZgpZHMei1iDyr230ZA8Yyzbe/Ne6rxHOuLXBeeed/LZLgHZFgJEyzlvx 58mxGkrfxZaqBMLSQ3y5Ho7DyLQgsV3eaGiGMfdyzWefvi8aSvhzWyYmEftd4PAB+gTzzmAjq QQTIDt/W605yEr8yIEPMxR4EYRU4amIG+cMqgIXkp0PKow3BZ4rSU2/cSI84XLoxJRnJKP7Vi 4EsVb0q5i4AJ51sGb0cRYlzno3E2BoE8s24B+U88UQfYQFaXvOTHhCKVYBZLMWG6cy6Xq8pCT fzHzdv3KHtDZ5DiVoQZQgzBimXo5NLW0GoeQD3m7eh8iqFY2EmjFyj1f8xivOILjdTjGmAAH9 iLgSQEnSL3aWrzSFWCfor/xSfOebQ+IsocQoXXGgrn5e5MlMkld+a+PwhqB2/YXled8Yy9uMc pesc/koiL4oIMviy2/+yeBZROdQOW7goFfG1adDPhG8E9Jx1O4= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Use three values directly for a condition check without assigning them >> to intermediate variables. > > Hi, > > what is the benefit of this? I proposed a small source code reduction. Other software design directions might become more interesting for this use case. Regards, Markus