Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 13 Mar 2018 10:58:16 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Ajay Singh <ajay.kathat@microchip.com>
Cc:     hariprasath.elango@gmail.com, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org, vbabu3@visteon.com,
        linux-wireless@vger.kernel.org,
        Ganesh Krishna <ganesh.krishna@microchip.com>,
        aditya.shankar@microchip.com
Subject: Re: [PATCHv2] staging: wilc1000: use pre-defined macro
 is_broadcast_ether_addr
Message-ID: <20180313095816.GA1656@kroah.com>
References: <20180312093903.9147-1-hariprasath.elango@gmail.com>
 <20180313130051.43b087dd@ajaysk-VirtualBox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180313130051.43b087dd@ajaysk-VirtualBox>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> 
> Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
> 
> On Mon, 12 Mar 2018 15:09:03 +0530
> <hariprasath.elango@gmail.com> wrote:
> 
> > From: HariPrasath Elango <hariprasath.elango@gmail.com>
> >
> 
> Please avoid use of 'From' tag specially when there is only one
> 'Signed-off-by' tag and its same.

But the email client isn't putting the correct info in the email header,
so this line is needed.

And if it's redundant, not a problem, git handles it just fine, better
to be safe.

thanks,

greg k-h